fix flaky test with timestamp

elastic · Oct 9, 2024 · a492d7c · a492d7c
1 parent a31b16e
commit a492d7c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/...sture/public/pages/vulnerabilities/utils/create_detection_rule_from_vulnerability.test.ts b/...sture/public/pages/vulnerabilities/utils/create_detection_rule_from_vulnerability.test.ts
@@ -89,7 +89,7 @@ describe('CreateDetectionRuleFromVulnerability', () => {
       } as Vulnerability;
       const currentTimestamp = new Date().toISOString();
 
-      const query = generateVulnerabilitiesRuleQuery(mockVulnerability);
+      const query = generateVulnerabilitiesRuleQuery(mockVulnerability, currentTimestamp);
       expect(query).toEqual(
         `vulnerability.id: "CVE-2024-00005" AND event.ingested >= "${currentTimestamp}"`
       );

diff --git a/...ty_posture/public/pages/vulnerabilities/utils/create_detection_rule_from_vulnerability.ts b/...ty_posture/public/pages/vulnerabilities/utils/create_detection_rule_from_vulnerability.ts
@@ -53,10 +53,11 @@ export const getVulnerabilityRuleName = (vulnerability: Vulnerability) => {
   });
 };
 
-export const generateVulnerabilitiesRuleQuery = (vulnerability: Vulnerability) => {
-  const currentTimestamp = new Date().toISOString();
-
-  return `vulnerability.id: "${vulnerability.id}" AND event.ingested >= "${currentTimestamp}"`;
+export const generateVulnerabilitiesRuleQuery = (
+  vulnerability: Vulnerability,
+  startTimestamp = new Date().toISOString()
+) => {
+  return `vulnerability.id: "${vulnerability.id}" AND event.ingested >= "${startTimestamp}"`;
 };
 
 const CSP_RULE_TAG = 'Cloud Security';