-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Automatic Import] Add Error handling framework (#193577)
## Release Note Adds error handling framework that provides error message with more context to user. ## Summary Relates - [192916](#192916) This PR adds an error handling framework. - Add Error classes for specific error scenarios. - If the error caught is of the predefined Error type the `message` and `errorCode` is sent back to UI from server. - The original error message is used to track telemetry and the errorCode can be translated into a User visible error. - If there is any non-predefined error server still throws a `badRequest` with the error message. This PR also adds/updates the graph images for different langgraphs ## Screenshots for error messages <img width="690" alt="image" src="https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea"> <img width="691" alt="image" src="https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- Loading branch information
Showing
22 changed files
with
332 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+6.25 KB
(110%)
x-pack/plugins/integration_assistant/docs/imgs/categorization_graph.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-662 Bytes
(98%)
x-pack/plugins/integration_assistant/docs/imgs/ecs_graph.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.56 KB
(100%)
x-pack/plugins/integration_assistant/docs/imgs/ecs_subgraph.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+14.1 KB
(200%)
x-pack/plugins/integration_assistant/docs/imgs/log_detection_graph.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+8.49 KB
(130%)
x-pack/plugins/integration_assistant/docs/imgs/related_graph.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
x-pack/plugins/integration_assistant/server/lib/errors/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { ErrorThatHandlesItsOwnResponse } from './types'; | ||
|
||
export function isErrorThatHandlesItsOwnResponse( | ||
e: ErrorThatHandlesItsOwnResponse | ||
): e is ErrorThatHandlesItsOwnResponse { | ||
return typeof (e as ErrorThatHandlesItsOwnResponse).sendResponse === 'function'; | ||
} | ||
|
||
export { RecursionLimitError } from './recursion_limit_error'; | ||
export { UnsupportedLogFormatError } from './unsupported_error'; |
24 changes: 24 additions & 0 deletions
24
x-pack/plugins/integration_assistant/server/lib/errors/recursion_limit_error.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { KibanaResponseFactory } from '@kbn/core/server'; | ||
import { ErrorThatHandlesItsOwnResponse } from './types'; | ||
|
||
export class RecursionLimitError extends Error implements ErrorThatHandlesItsOwnResponse { | ||
private readonly errorCode: string; | ||
|
||
constructor(message: string, errorCode: string) { | ||
super(message); | ||
this.errorCode = errorCode; | ||
} | ||
|
||
public sendResponse(res: KibanaResponseFactory) { | ||
return res.badRequest({ | ||
body: { message: this.message, attributes: { errorCode: this.errorCode } }, | ||
}); | ||
} | ||
} |
12 changes: 12 additions & 0 deletions
12
x-pack/plugins/integration_assistant/server/lib/errors/types.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { KibanaResponseFactory, IKibanaResponse } from '@kbn/core/server'; | ||
|
||
export interface ErrorThatHandlesItsOwnResponse extends Error { | ||
sendResponse(res: KibanaResponseFactory): IKibanaResponse; | ||
} |
26 changes: 26 additions & 0 deletions
26
x-pack/plugins/integration_assistant/server/lib/errors/unsupported_error.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { KibanaResponseFactory } from '@kbn/core/server'; | ||
import { ErrorThatHandlesItsOwnResponse } from './types'; | ||
import { ErrorCode } from '../../../common/constants'; | ||
|
||
export class UnsupportedLogFormatError extends Error implements ErrorThatHandlesItsOwnResponse { | ||
private readonly errorCode: string = ErrorCode.UNSUPPORTED_LOG_SAMPLES_FORMAT; | ||
|
||
// eslint-disable-next-line @typescript-eslint/no-useless-constructor | ||
constructor(message: string) { | ||
super(message); | ||
} | ||
|
||
public sendResponse(res: KibanaResponseFactory) { | ||
return res.customError({ | ||
statusCode: 501, | ||
body: { message: this.message, attributes: { errorCode: this.errorCode } }, | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.