Skip to content

Commit

Permalink
[Security Solution] Fixes and unskips detection page filters tests (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
MadameSheema authored Nov 7, 2023
1 parent c26060e commit 9b8f0fa
Showing 1 changed file with 4 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ import {
import { TOASTER } from '../../../screens/alerts_detection_rules';
import { setEndDate, setStartDate } from '../../../tasks/date_picker';
import { fillAddFilterForm, openAddFilterPopover } from '../../../tasks/search_bar';
import { deleteAlertsAndRules } from '../../../tasks/common';

const customFilters = [
{
Expand Down Expand Up @@ -106,34 +107,20 @@ const assertFilterControlsWithFilterObject = (
});
};

// Failing: See https://github.com/elastic/kibana/issues/167914
describe.skip(`Detections : Page Filters`, { tags: ['@ess', '@serverless'] }, () => {
before(() => {
createRule(getNewRule({ rule_id: 'custom_rule_filters' }));
});

describe(`Detections : Page Filters`, { tags: ['@ess', '@serverless'] }, () => {
beforeEach(() => {
deleteAlertsAndRules();
createRule(getNewRule({ rule_id: 'custom_rule_filters' }));
login();
visitWithTimeRange(ALERTS_URL);
waitForAlerts();
resetFilters();
});

it('Default page filters are populated when nothing is provided in the URL', () => {
assertFilterControlsWithFilterObject();
});

context('Alert Page Filters Customization ', () => {
beforeEach(() => {
login();
visitWithTimeRange(ALERTS_URL);
waitForAlerts();
});

afterEach(() => {
resetFilters();
});

it('should be able to delete Controls', () => {
waitForPageFilters();
editFilterGroupControls();
Expand Down Expand Up @@ -234,10 +221,6 @@ describe.skip(`Detections : Page Filters`, { tags: ['@ess', '@serverless'] }, ()
});

context('with data modificiation', () => {
after(() => {
createRule(getNewRule({ rule_id: 'custom_rule_filters' }));
});

it(`Alert list is updated when the alerts are updated`, () => {
// mark status of one alert to be acknowledged
selectCountTable();
Expand Down

0 comments on commit 9b8f0fa

Please sign in to comment.