[Obs AI Assistant] Address PR comments (#176299)

elastic · Oct 31, 2024 · 98e0e2f · 98e0e2f
1 parent ae8cc37
commit 98e0e2f
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 13 deletions.
diff --git a/x-pack/packages/kbn-ai-assistant/src/chat/chat_flyout.tsx b/x-pack/packages/kbn-ai-assistant/src/chat/chat_flyout.tsx
@@ -47,15 +47,15 @@ export function ChatFlyout({
   isOpen,
   onClose,
   navigateToConversation,
-  hidePreviousConversations,
+  hideConversationList,
 }: {
   initialTitle: string;
   initialMessages: Message[];
   initialFlyoutPositionMode?: FlyoutPositionMode;
   isOpen: boolean;
   onClose: () => void;
   navigateToConversation?: (conversationId?: string) => void;
-  hidePreviousConversations?: boolean;
+  hideConversationList?: boolean;
 }) {
   const { euiTheme } = useEuiTheme();
   const breakpoint = useCurrentEuiBreakpoint();
@@ -176,7 +176,7 @@ export function ChatFlyout({
         }}
       >
         <EuiFlexGroup gutterSize="none" className={containerClassName}>
-          {!hidePreviousConversations ? (
+          {!hideConversationList ? (
             <EuiFlexItem className={breakpoint === 'xs' ? hideClassName : sidebarClass}>
               <EuiPopover
                 anchorPosition="downLeft"

diff --git a/...s/observability_solution/observability_ai_assistant/public/components/insight/insight.tsx b/...s/observability_solution/observability_ai_assistant/public/components/insight/insight.tsx
@@ -128,7 +128,7 @@ function ChatContent({
                     service.conversations.openNewConversation({
                       messages,
                       title: defaultTitle,
-                      hidePreviousConversations: true,
+                      hideConversationList: true,
                     });
                   }}
                 />

diff --git a/...lugins/observability_solution/observability_ai_assistant/public/service/create_service.ts b/...lugins/observability_solution/observability_ai_assistant/public/service/create_service.ts
@@ -39,7 +39,7 @@ export function createService({
   const predefinedConversation$ = new Subject<{
     messages: Message[];
     title?: string;
-    hidePreviousConversations?: boolean;
+    hideConversationList?: boolean;
   }>();
 
   const scope$ = new BehaviorSubject<AssistantScope[]>(scopes);
@@ -111,13 +111,13 @@ export function createService({
       openNewConversation: ({
         messages,
         title,
-        hidePreviousConversations = false,
+        hideConversationList = false,
       }: {
         messages: Message[];
         title?: string;
-        hidePreviousConversations?: boolean;
+        hideConversationList?: boolean;
       }) => {
-        predefinedConversation$.next({ messages, title, hidePreviousConversations });
+        predefinedConversation$.next({ messages, title, hideConversationList });
       },
       predefinedConversation$: predefinedConversation$.asObservable(),
     },

diff --git a/x-pack/plugins/observability_solution/observability_ai_assistant/public/types.ts b/x-pack/plugins/observability_solution/observability_ai_assistant/public/types.ts
@@ -94,12 +94,12 @@ export interface ObservabilityAIAssistantConversationService {
   openNewConversation: ({}: {
     messages: Message[];
     title?: string;
-    hidePreviousConversations?: boolean;
+    hideConversationList?: boolean;
   }) => void;
   predefinedConversation$: Observable<{
     messages: Message[];
     title?: string;
-    hidePreviousConversations?: boolean;
+    hideConversationList?: boolean;
   }>;
 }
 

diff --git a/...rvability_solution/observability_ai_assistant_app/public/components/nav_control/index.tsx b/...rvability_solution/observability_ai_assistant_app/public/components/nav_control/index.tsx
@@ -103,12 +103,12 @@ export function NavControl() {
     };
   }, [service.conversations.predefinedConversation$]);
 
-  const { messages, title, hidePreviousConversations } = useObservable(
+  const { messages, title, hideConversationList } = useObservable(
     service.conversations.predefinedConversation$
   ) ?? {
     messages: [],
     title: undefined,
-    hidePreviousConversations: false,
+    hideConversationList: false,
   };
 
   const theme = useTheme();
@@ -174,7 +174,7 @@ export function NavControl() {
                 )
               );
             }}
-            hidePreviousConversations={hidePreviousConversations}
+            hideConversationList={hideConversationList}
           />
         </ObservabilityAIAssistantChatServiceContext.Provider>
       ) : undefined}