feature(slo): Run transforms unattended (#167170)

x-pack/plugins/observability/server/assets/constants.ts

@@ -6,6 +6,7 @@
  */
 
 export const SLO_RESOURCES_VERSION = 2;
+export const SLO_SUMMARY_TRANSFORMS_VERSION = 3;
 
 export const SLO_COMPONENT_TEMPLATE_MAPPINGS_NAME = '.slo-observability.sli-mappings';
 export const SLO_COMPONENT_TEMPLATE_SETTINGS_NAME = '.slo-observability.sli-settings';

x-pack/plugins/observability/server/assets/transform_templates/slo_transform_template.ts

@@ -36,6 +36,7 @@ export const getSLOTransformTemplate = (
   dest: destination,
   settings: {
     deduce_mappings: false,
+    unattended: true,
   },
   sync: {
     time: {

x-pack/plugins/observability/server/services/slo/create_slo.test.ts

@@ -55,6 +55,7 @@ describe('CreateSLO', () => {
       expect(mockTransformManager.install).toHaveBeenCalledWith(
         expect.objectContaining({ ...sloParams, id: 'unique-id' })
       );
+      expect(mockTransformManager.preview).toHaveBeenCalledWith('slo-transform-id');
       expect(mockTransformManager.start).toHaveBeenCalledWith('slo-transform-id');
       expect(response).toEqual(expect.objectContaining({ id: 'unique-id' }));
       expect(esClientMock.index.mock.calls[0]).toMatchSnapshot();
@@ -100,6 +101,16 @@ describe('CreateSLO', () => {
       expect(mockRepository.deleteById).toBeCalled();
     });
 
+    it('removes the transform and deletes the SLO when transform preview fails', async () => {
+      mockTransformManager.install.mockResolvedValue('slo-transform-id');
+      mockTransformManager.preview.mockRejectedValue(new Error('Transform preview error'));
+      const sloParams = createSLOParams({ indicator: createAPMTransactionErrorRateIndicator() });
+
+      await expect(createSLO.execute(sloParams)).rejects.toThrowError('Transform preview error');
+      expect(mockTransformManager.uninstall).toBeCalledWith('slo-transform-id');
+      expect(mockRepository.deleteById).toBeCalled();
+    });
+
     it('removes the transform and deletes the SLO when transform start fails', async () => {
       mockTransformManager.install.mockResolvedValue('slo-transform-id');
       mockTransformManager.start.mockRejectedValue(new Error('Transform start error'));

x-pack/plugins/observability/server/services/slo/create_slo.ts

@@ -36,6 +36,7 @@ export class CreateSLO {
     }
 
     try {
+      await this.transformManager.preview(sloTransformId);
       await this.transformManager.start(sloTransformId);
     } catch (err) {
       await Promise.all([

x-pack/plugins/observability/server/services/slo/mocks/index.ts

@@ -28,6 +28,7 @@ const createSummaryTransformInstallerMock = (): jest.Mocked<SummaryTransformInst
 const createTransformManagerMock = (): jest.Mocked<TransformManager> => {
   return {
     install: jest.fn(),
+    preview: jest.fn(),
     uninstall: jest.fn(),
     start: jest.fn(),
     stop: jest.fn(),

x-pack/plugins/observability/server/services/slo/summary_transform/summary_transform_installer.ts

@@ -8,7 +8,7 @@
 import { TransformPutTransformRequest } from '@elastic/elasticsearch/lib/api/types';
 import type { ElasticsearchClient, Logger } from '@kbn/core/server';
 import {
-  SLO_RESOURCES_VERSION,
+  SLO_SUMMARY_TRANSFORMS_VERSION,
   SLO_SUMMARY_TRANSFORM_NAME_PREFIX,
 } from '../../../assets/constants';
 import { retryTransientEsErrors } from '../../../utils/retry';
@@ -32,7 +32,7 @@ export class DefaultSummaryTransformInstaller implements SummaryTransformInstall
     const alreadyInstalled =
       summaryTransforms.count === allTransformIds.length &&
       summaryTransforms.transforms.every(
-        (transform) => transform._meta?.version === SLO_RESOURCES_VERSION
+        (transform) => transform._meta?.version === SLO_SUMMARY_TRANSFORMS_VERSION
       ) &&
       summaryTransforms.transforms.every((transform) => allTransformIds.includes(transform.id));
 
@@ -46,9 +46,9 @@ export class DefaultSummaryTransformInstaller implements SummaryTransformInstall
       const transform = summaryTransforms.transforms.find((t) => t.id === transformId);
 
       const transformAlreadyInstalled =
-        !!transform && transform._meta?.version === SLO_RESOURCES_VERSION;
+        !!transform && transform._meta?.version === SLO_SUMMARY_TRANSFORMS_VERSION;
       const previousTransformAlreadyInstalled =
-        !!transform && transform._meta?.version !== SLO_RESOURCES_VERSION;
+        !!transform && transform._meta?.version !== SLO_SUMMARY_TRANSFORMS_VERSION;
 
       if (transformAlreadyInstalled) {
         this.logger.info(`SLO summary transform [${transformId}] already installed - skipping`);

x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_occurrences_30d_rolling.ts

@@ -8,9 +8,9 @@
 import { TransformPutTransformRequest } from '@elastic/elasticsearch/lib/api/types';
 import {
   SLO_DESTINATION_INDEX_PATTERN,
-  SLO_RESOURCES_VERSION,
   SLO_SUMMARY_DESTINATION_INDEX_NAME,
   SLO_SUMMARY_INGEST_PIPELINE_NAME,
+  SLO_SUMMARY_TRANSFORMS_VERSION,
   SLO_SUMMARY_TRANSFORM_NAME_PREFIX,
 } from '../../../../assets/constants';
 import { groupBy } from './common';
@@ -143,10 +143,10 @@ export const SUMMARY_OCCURRENCES_30D_ROLLING: TransformPutTransformRequest = {
   },
   settings: {
     deduce_mappings: false,
-    max_page_search_size: 8000,
+    unattended: true,
   },
   _meta: {
-    version: SLO_RESOURCES_VERSION,
+    version: SLO_SUMMARY_TRANSFORMS_VERSION,
     managed: true,
     managed_by: 'observability',
   },

x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_occurrences_7d_rolling.ts

@@ -8,9 +8,9 @@
 import { TransformPutTransformRequest } from '@elastic/elasticsearch/lib/api/types';
 import {
   SLO_DESTINATION_INDEX_PATTERN,
-  SLO_RESOURCES_VERSION,
   SLO_SUMMARY_DESTINATION_INDEX_NAME,
   SLO_SUMMARY_INGEST_PIPELINE_NAME,
+  SLO_SUMMARY_TRANSFORMS_VERSION,
   SLO_SUMMARY_TRANSFORM_NAME_PREFIX,
 } from '../../../../assets/constants';
 import { groupBy } from './common';
@@ -143,9 +143,10 @@ export const SUMMARY_OCCURRENCES_7D_ROLLING: TransformPutTransformRequest = {
   },
   settings: {
     deduce_mappings: false,
+    unattended: true,
   },
   _meta: {
-    version: SLO_RESOURCES_VERSION,
+    version: SLO_SUMMARY_TRANSFORMS_VERSION,
     managed: true,
     managed_by: 'observability',
   },

x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_occurrences_90d_rolling.ts

@@ -8,9 +8,9 @@
 import { TransformPutTransformRequest } from '@elastic/elasticsearch/lib/api/types';
 import {
   SLO_DESTINATION_INDEX_PATTERN,
-  SLO_RESOURCES_VERSION,
   SLO_SUMMARY_DESTINATION_INDEX_NAME,
   SLO_SUMMARY_INGEST_PIPELINE_NAME,
+  SLO_SUMMARY_TRANSFORMS_VERSION,
   SLO_SUMMARY_TRANSFORM_NAME_PREFIX,
 } from '../../../../assets/constants';
 import { groupBy } from './common';
@@ -143,9 +143,10 @@ export const SUMMARY_OCCURRENCES_90D_ROLLING: TransformPutTransformRequest = {
   },
   settings: {
     deduce_mappings: false,
+    unattended: true,
   },
   _meta: {
-    version: SLO_RESOURCES_VERSION,
+    version: SLO_SUMMARY_TRANSFORMS_VERSION,
     managed: true,
     managed_by: 'observability',
   },

x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_occurrences_monthly_aligned.ts

@@ -8,9 +8,9 @@
 import { TransformPutTransformRequest } from '@elastic/elasticsearch/lib/api/types';
 import {
   SLO_DESTINATION_INDEX_PATTERN,
-  SLO_RESOURCES_VERSION,
   SLO_SUMMARY_DESTINATION_INDEX_NAME,
   SLO_SUMMARY_INGEST_PIPELINE_NAME,
+  SLO_SUMMARY_TRANSFORMS_VERSION,
   SLO_SUMMARY_TRANSFORM_NAME_PREFIX,
 } from '../../../../assets/constants';
 import { groupBy } from './common';
@@ -141,9 +141,10 @@ export const SUMMARY_OCCURRENCES_MONTHLY_ALIGNED: TransformPutTransformRequest =
   },
   settings: {
     deduce_mappings: false,
+    unattended: true,
   },
   _meta: {
-    version: SLO_RESOURCES_VERSION,
+    version: SLO_SUMMARY_TRANSFORMS_VERSION,
     managed: true,
     managed_by: 'observability',
   },

x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_occurrences_weekly_aligned.ts

@@ -8,9 +8,9 @@
 import { TransformPutTransformRequest } from '@elastic/elasticsearch/lib/api/types';
 import {
   SLO_DESTINATION_INDEX_PATTERN,
-  SLO_RESOURCES_VERSION,
   SLO_SUMMARY_DESTINATION_INDEX_NAME,
   SLO_SUMMARY_INGEST_PIPELINE_NAME,
+  SLO_SUMMARY_TRANSFORMS_VERSION,
   SLO_SUMMARY_TRANSFORM_NAME_PREFIX,
 } from '../../../../assets/constants';
 import { groupBy } from './common';
@@ -141,9 +141,10 @@ export const SUMMARY_OCCURRENCES_WEEKLY_ALIGNED: TransformPutTransformRequest =
   },
   settings: {
     deduce_mappings: false,
+    unattended: true,
   },
   _meta: {
-    version: SLO_RESOURCES_VERSION,
+    version: SLO_SUMMARY_TRANSFORMS_VERSION,
     managed: true,
     managed_by: 'observability',
   },

x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_timeslices_30d_rolling.ts

@@ -8,9 +8,9 @@
 import { TransformPutTransformRequest } from '@elastic/elasticsearch/lib/api/types';
 import {
   SLO_DESTINATION_INDEX_PATTERN,
-  SLO_RESOURCES_VERSION,
   SLO_SUMMARY_DESTINATION_INDEX_NAME,
   SLO_SUMMARY_INGEST_PIPELINE_NAME,
+  SLO_SUMMARY_TRANSFORMS_VERSION,
   SLO_SUMMARY_TRANSFORM_NAME_PREFIX,
 } from '../../../../assets/constants';
 import { groupBy } from './common';
@@ -143,9 +143,10 @@ export const SUMMARY_TIMESLICES_30D_ROLLING: TransformPutTransformRequest = {
   },
   settings: {
     deduce_mappings: false,
+    unattended: true,
   },
   _meta: {
-    version: SLO_RESOURCES_VERSION,
+    version: SLO_SUMMARY_TRANSFORMS_VERSION,
     managed: true,
     managed_by: 'observability',
   },

x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_timeslices_7d_rolling.ts

@@ -8,9 +8,9 @@
 import { TransformPutTransformRequest } from '@elastic/elasticsearch/lib/api/types';
 import {
   SLO_DESTINATION_INDEX_PATTERN,
-  SLO_RESOURCES_VERSION,
   SLO_SUMMARY_DESTINATION_INDEX_NAME,
   SLO_SUMMARY_INGEST_PIPELINE_NAME,
+  SLO_SUMMARY_TRANSFORMS_VERSION,
   SLO_SUMMARY_TRANSFORM_NAME_PREFIX,
 } from '../../../../assets/constants';
 import { groupBy } from './common';
@@ -143,9 +143,10 @@ export const SUMMARY_TIMESLICES_7D_ROLLING: TransformPutTransformRequest = {
   },
   settings: {
     deduce_mappings: false,
+    unattended: true,
   },
   _meta: {
-    version: SLO_RESOURCES_VERSION,
+    version: SLO_SUMMARY_TRANSFORMS_VERSION,
     managed: true,
     managed_by: 'observability',
   },

x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_timeslices_90d_rolling.ts

@@ -8,9 +8,9 @@
 import { TransformPutTransformRequest } from '@elastic/elasticsearch/lib/api/types';
 import {
   SLO_DESTINATION_INDEX_PATTERN,
-  SLO_RESOURCES_VERSION,
   SLO_SUMMARY_DESTINATION_INDEX_NAME,
   SLO_SUMMARY_INGEST_PIPELINE_NAME,
+  SLO_SUMMARY_TRANSFORMS_VERSION,
   SLO_SUMMARY_TRANSFORM_NAME_PREFIX,
 } from '../../../../assets/constants';
 import { groupBy } from './common';
@@ -143,9 +143,10 @@ export const SUMMARY_TIMESLICES_90D_ROLLING: TransformPutTransformRequest = {
   },
   settings: {
     deduce_mappings: false,
+    unattended: true,
   },
   _meta: {
-    version: SLO_RESOURCES_VERSION,
+    version: SLO_SUMMARY_TRANSFORMS_VERSION,
     managed: true,
     managed_by: 'observability',
   },

x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_timeslices_monthly_aligned.ts

@@ -8,9 +8,9 @@
 import { TransformPutTransformRequest } from '@elastic/elasticsearch/lib/api/types';
 import {
   SLO_DESTINATION_INDEX_PATTERN,
-  SLO_RESOURCES_VERSION,
   SLO_SUMMARY_DESTINATION_INDEX_NAME,
   SLO_SUMMARY_INGEST_PIPELINE_NAME,
+  SLO_SUMMARY_TRANSFORMS_VERSION,
   SLO_SUMMARY_TRANSFORM_NAME_PREFIX,
 } from '../../../../assets/constants';
 import { groupBy } from './common';
@@ -171,9 +171,10 @@ export const SUMMARY_TIMESLICES_MONTHLY_ALIGNED: TransformPutTransformRequest =
   },
   settings: {
     deduce_mappings: false,
+    unattended: true,
   },
   _meta: {
-    version: SLO_RESOURCES_VERSION,
+    version: SLO_SUMMARY_TRANSFORMS_VERSION,
     managed: true,
     managed_by: 'observability',
   },