Skip to content

Commit

Permalink
[Enterprise Search]Render native connector docs conditionally (#169121)
Browse files Browse the repository at this point in the history
## Summary

<img width="772" alt="Screenshot 2023-10-17 at 16 36 45"
src="https://github.com/elastic/kibana/assets/1410658/f668ab82-485d-46a6-8598-c1c9973b6255">

## Release Note
External documentation links are rendered conditionally now to avoid
empty links.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
  • Loading branch information
efegurkan authored Oct 17, 2023
1 parent 2642147 commit 93f5d4e
Showing 1 changed file with 13 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,19 @@ export const ResearchConfiguration: React.FC<ResearchConfigurationProps> = ({
)}
</EuiLink>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiLink target="_blank" href={externalDocsUrl}>
{i18n.translate(
'xpack.enterpriseSearch.content.indices.configurationConnector.researchConfiguration.serviceDocumentationLinkLabel',
{
defaultMessage: '{name} documentation',
values: { name },
}
)}
</EuiLink>
</EuiFlexItem>
{externalDocsUrl && (
<EuiFlexItem grow={false}>
<EuiLink target="_blank" href={externalDocsUrl}>
{i18n.translate(
'xpack.enterpriseSearch.content.indices.configurationConnector.researchConfiguration.serviceDocumentationLinkLabel',
{
defaultMessage: '{name} documentation',
values: { name },
}
)}
</EuiLink>
</EuiFlexItem>
)}
</EuiFlexGroup>
</>
);
Expand Down

0 comments on commit 93f5d4e

Please sign in to comment.