[8.x] Move nested declarations above rule (#193931) (#194598)

# Backport This will backport the following commits from `main` to `8.x`: - [Move nested declarations above rule (#193931)](#193931)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Kurt <[email protected]>
elastic · Oct 1, 2024 · 9267266 · 9267266
1 parent bee5cc2
commit 9267266
Show file tree

Hide file tree

Showing 9 changed files with 21 additions and 13 deletions.
diff --git a/src/plugins/interactive_setup/public/app.scss b/src/plugins/interactive_setup/public/app.scss
@@ -9,10 +9,10 @@
 }
 
 .interactiveSetup__logo {
+  margin-bottom: $euiSizeXL;
+
   @include kibanaCircleLogo;
   @include euiBottomShadowMedium;
-
-  margin-bottom: $euiSizeXL;
 }
 
 .interactiveSetup__content {

diff --git a/x-pack/plugins/security/public/authentication/access_agreement/access_agreement_page.scss b/x-pack/plugins/security/public/authentication/access_agreement/access_agreement_page.scss
@@ -7,9 +7,10 @@
 }
 
 .secAccessAgreementPage__text {
-  @include euiYScrollWithShadows;
   max-height: 400px;
   padding: $euiSize $euiSizeL 0;
+
+  @include euiYScrollWithShadows;
 }
 
 .secAccessAgreementPage__footer {

diff --git a/...public/authentication/components/authentication_state_page/authentication_state_page.scss b/...public/authentication/components/authentication_state_page/authentication_state_page.scss
@@ -9,10 +9,10 @@
 }
 
 .secAuthenticationStatePage__logo {
+  margin-bottom: $euiSizeXL;
+
   @include kibanaCircleLogo;
   @include euiBottomShadowMedium;
-
-  margin-bottom: $euiSizeXL;
 }
 
 .secAuthenticationStatePage__content {

diff --git a/x-pack/plugins/security/public/authentication/login/components/login_form/login_form.scss b/x-pack/plugins/security/public/authentication/login/components/login_form/login_form.scss
@@ -23,11 +23,11 @@
   }
 
   &:focus {
-    @include euiFocusRing;
-
     border-color: transparent;
     border-radius: $euiBorderRadius;
 
+    @include euiFocusRing;
+
     .secLoginCard__title {
       text-decoration: underline;
     }

diff --git a/x-pack/plugins/security/public/authentication/login/login_page.scss b/x-pack/plugins/security/public/authentication/login/login_page.scss
@@ -9,10 +9,10 @@
 }
 
 .loginWelcome__logo {
+  margin-bottom: $euiSizeXL;
+
   @include kibanaCircleLogo;
   @include euiBottomShadowMedium;
-
-  margin-bottom: $euiSizeXL;
 }
 
 .loginWelcome__content {

diff --git a/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.scss b/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.scss
@@ -3,8 +3,9 @@
 }
 
 .spcMenu__spacesList {
-  @include euiYScrollWithShadows;
   max-height: $euiSizeXL * 10;
+
+  @include euiYScrollWithShadows;
 }
 
 .spcMenu__searchFieldWrapper {

diff --git a/x-pack/plugins/spaces/public/space_selector/__snapshots__/space_selector.test.tsx.snap b/x-pack/plugins/spaces/public/space_selector/__snapshots__/space_selector.test.tsx.snap
diff --git a/x-pack/plugins/spaces/public/space_selector/space_selector.scss b/x-pack/plugins/spaces/public/space_selector/space_selector.scss
@@ -4,6 +4,9 @@
 
 .spcSelectorBackground {
   @include kibanaFullScreenGraphics;
+}
+
+.spcSelectorBackground__nonMixinAttributes {
   z-index: -1;
   pointer-events: none;
 }

diff --git a/x-pack/plugins/spaces/public/space_selector/space_selector.tsx b/x-pack/plugins/spaces/public/space_selector/space_selector.tsx
@@ -124,7 +124,10 @@ export class SpaceSelector extends Component<Props, State> {
       >
         {/* Portal the fixed background graphic so it doesn't affect page positioning or overlap on top of global banners */}
         <EuiPortal>
-          <div className="spcSelectorBackground" role="presentation" />
+          <div
+            className="spcSelectorBackground spcSelectorBackground__nonMixinAttributes"
+            role="presentation"
+          />
         </EuiPortal>
 
         <KibanaPageTemplate.Section color="transparent" paddingSize="xl">