Skip to content

Commit

Permalink
[8.x] [Dashboard] fix Export CSV doesnt work (#198547) (#198583)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dashboard] fix Export CSV doesnt work
(#198547)](#198547)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T16:37:51Z","message":"[Dashboard]
fix Export CSV doesnt work (#198547)\n\nCloses
https://github.com/elastic/kibana/issues/198517\r\n\r\nhttps://github.com/elastic/kibana/pull/193644
refactored Dashboard\r\nservices. Part of this refactor moved
`fieldFormats` from\r\n`data.fieldFormats` to getting `fieldFormats`
directly from the\r\nfieldFormats plugin. That is because
`data.fieldFormats` is marked as\r\ndeprecated. The problem is that the
fieldFormats plugin was not defined\r\nunder `requiredPlugins` and thus
was undefined at runtime.\r\n\r\n### Test instructions\r\n1) install web
logs sample data\r\n2) open web logs sample data dashboard\r\n3) hover
over \"[Logs] Response Codes Over Time + Annotations\" panel
and\r\nselect \"three dots\" icon. Then select \"Download CSV\". Verify
there are\r\nno errors in web browser console and CSV is
downloaded.","sha":"0cd2d924dea85ec02d65bcf967b28dac96714ed3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:version","v8.17.0","v8.16.1"],"title":"[Dashboard]
fix Export CSV doesnt
work","number":198547,"url":"https://github.com/elastic/kibana/pull/198547","mergeCommit":{"message":"[Dashboard]
fix Export CSV doesnt work (#198547)\n\nCloses
https://github.com/elastic/kibana/issues/198517\r\n\r\nhttps://github.com/elastic/kibana/pull/193644
refactored Dashboard\r\nservices. Part of this refactor moved
`fieldFormats` from\r\n`data.fieldFormats` to getting `fieldFormats`
directly from the\r\nfieldFormats plugin. That is because
`data.fieldFormats` is marked as\r\ndeprecated. The problem is that the
fieldFormats plugin was not defined\r\nunder `requiredPlugins` and thus
was undefined at runtime.\r\n\r\n### Test instructions\r\n1) install web
logs sample data\r\n2) open web logs sample data dashboard\r\n3) hover
over \"[Logs] Response Codes Over Time + Annotations\" panel
and\r\nselect \"three dots\" icon. Then select \"Download CSV\". Verify
there are\r\nno errors in web browser console and CSV is
downloaded.","sha":"0cd2d924dea85ec02d65bcf967b28dac96714ed3"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198547","number":198547,"mergeCommit":{"message":"[Dashboard]
fix Export CSV doesnt work (#198547)\n\nCloses
https://github.com/elastic/kibana/issues/198517\r\n\r\nhttps://github.com/elastic/kibana/pull/193644
refactored Dashboard\r\nservices. Part of this refactor moved
`fieldFormats` from\r\n`data.fieldFormats` to getting `fieldFormats`
directly from the\r\nfieldFormats plugin. That is because
`data.fieldFormats` is marked as\r\ndeprecated. The problem is that the
fieldFormats plugin was not defined\r\nunder `requiredPlugins` and thus
was undefined at runtime.\r\n\r\n### Test instructions\r\n1) install web
logs sample data\r\n2) open web logs sample data dashboard\r\n3) hover
over \"[Logs] Response Codes Over Time + Annotations\" panel
and\r\nselect \"three dots\" icon. Then select \"Download CSV\". Verify
there are\r\nno errors in web browser console and CSV is
downloaded.","sha":"0cd2d924dea85ec02d65bcf967b28dac96714ed3"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
  • Loading branch information
kibanamachine and nreese authored Oct 31, 2024
1 parent 7dc66db commit 8ae5e55
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/plugins/dashboard/kibana.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"dataViews",
"dataViewEditor",
"embeddable",
"fieldFormats",
"controls",
"inspector",
"navigation",
Expand Down

0 comments on commit 8ae5e55

Please sign in to comment.