-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SLO] multi group by - replace instanceId runtime type with script pr…
…ocessor (#179864) ## Summary Removes the runtime type for generating the instanceId for multi group by, in favor of utilizing a script processor to generate the instanceId. This was done to improve the aggregation speed for the transform aggregation. Results from search profiler suggest a 3x reduction in overall aggregation speed. This PR also introduces the concept of `SLO_RESOURCE_VERSION_MAJOR` in order for us to bump resource versions for additive changes like the change present in this PR. Updating the `instanceId` to utilize a script processor can break search for existing SLOs. The update is only intended to apply to newly created or updated SLOs. To account for this, it's important that this feature is tested against currently stable SLOs, both with and without a group by ### Testing 1. The most faithful test would be going from 8.13.1 to this branch. However going from main to this branch is acceptable as well. 2. Checkout tag v8.13.1 (or main). Create an SLO with a group by and another SLO without a group by. Wait for both to calculate and be stable. 3. Check out this PR. 4. Ensure your previous SLOs remain stable 5. Create a new SLO with a group by. Wait for the calculations to occur and ensure everything is working as expected. 6. Create a new SLO without a group by. Wait for the calculations to occur and ensure everything is working as expected. --------- Co-authored-by: Chris Cowan <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
- Loading branch information
1 parent
19c697d
commit 8564b7c
Showing
17 changed files
with
281 additions
and
340 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
.../plugins/observability_solution/slo/server/services/__snapshots__/create_slo.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
...k/plugins/observability_solution/slo/server/services/__snapshots__/reset_slo.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
54 changes: 6 additions & 48 deletions
54
.../server/services/transform_generators/__snapshots__/apm_transaction_duration.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
54 changes: 6 additions & 48 deletions
54
...erver/services/transform_generators/__snapshots__/apm_transaction_error_rate.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.