Maintenance window page displays dead breadcrumb for management

elastic · Nov 21, 2024 · 8045cfa · 8045cfa
1 parent 7e65cde
commit 8045cfa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 14 deletions.
diff --git a/x-pack/plugins/alerting/public/hooks/use_breadcrumbs.test.tsx b/x-pack/plugins/alerting/public/hooks/use_breadcrumbs.test.tsx
@@ -51,18 +51,14 @@ describe('useBreadcrumbs', () => {
     renderHook(() => useBreadcrumbs(MAINTENANCE_WINDOW_DEEP_LINK_IDS.maintenanceWindows), {
       wrapper: appMockRenderer.AppWrapper,
     });
-    expect(mockSetBreadcrumbs).toHaveBeenCalledWith([
-      { href: '/test', onClick: expect.any(Function), text: 'Stack Management' },
-      { text: 'Maintenance Windows' },
-    ]);
+    expect(mockSetBreadcrumbs).toHaveBeenCalledWith([{ text: 'Maintenance Windows' }]);
   });
 
   test('set create maintenance windows breadcrumbs', () => {
     renderHook(() => useBreadcrumbs(MAINTENANCE_WINDOW_DEEP_LINK_IDS.maintenanceWindowsCreate), {
       wrapper: appMockRenderer.AppWrapper,
     });
     expect(mockSetBreadcrumbs).toHaveBeenCalledWith([
-      { href: '/test', onClick: expect.any(Function), text: 'Stack Management' },
       {
         href: MAINTENANCE_WINDOW_DEEP_LINK_IDS.maintenanceWindows,
         onClick: expect.any(Function),
@@ -77,7 +73,6 @@ describe('useBreadcrumbs', () => {
       wrapper: appMockRenderer.AppWrapper,
     });
     expect(mockSetBreadcrumbs).toHaveBeenCalledWith([
-      { href: '/test', onClick: expect.any(Function), text: 'Stack Management' },
       {
         href: MAINTENANCE_WINDOW_DEEP_LINK_IDS.maintenanceWindows,
         onClick: expect.any(Function),

diff --git a/x-pack/plugins/alerting/public/hooks/use_breadcrumbs.ts b/x-pack/plugins/alerting/public/hooks/use_breadcrumbs.ts
@@ -72,19 +72,14 @@ export const useBreadcrumbs = (pageDeepLink: MaintenanceWindowDeepLinkIds) => {
     services: {
       chrome: { docTitle, setBreadcrumbs },
       application: { navigateToUrl },
+      serverless,
     },
   } = useKibana();
   const setTitle = docTitle.change;
   const { getAppUrl } = useNavigation(MANAGEMENT_APP_ID);
 
   useEffect(() => {
     const breadcrumbs = [
-      {
-        text: i18n.translate('xpack.alerting.breadcrumbs.stackManagementLinkText', {
-          defaultMessage: 'Stack Management',
-        }),
-        href: getAppUrl(),
-      },
       ...(topLevelBreadcrumb[pageDeepLink]
         ? [
             {
@@ -98,11 +93,14 @@ export const useBreadcrumbs = (pageDeepLink: MaintenanceWindowDeepLinkIds) => {
       },
     ];
 
-    if (setBreadcrumbs) {
+    if (serverless && serverless.setBreadcrumbs) {
+      serverless.setBreadcrumbs(breadcrumbs);
+    } else {
       setBreadcrumbs(addClickHandlers(breadcrumbs, navigateToUrl));
     }
+
     if (setTitle) {
       setTitle(getTitleFromBreadCrumbs(breadcrumbs));
     }
-  }, [pageDeepLink, getAppUrl, navigateToUrl, setBreadcrumbs, setTitle]);
+  }, [pageDeepLink, getAppUrl, navigateToUrl, setBreadcrumbs, setTitle, serverless]);
 };