fix ES|QL query required validator

elastic · Nov 27, 2024 · 7a474af · 7a474af
1 parent cbd97a8
commit 7a474af
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 20 deletions.
diff --git a/...tion/public/detection_engine/rule_creation/components/esql_query_edit/esql_query_edit.tsx b/...tion/public/detection_engine/rule_creation/components/esql_query_edit/esql_query_edit.tsx
@@ -13,7 +13,7 @@ import type { FieldConfig } from '../../../../shared_imports';
 import { UseField } from '../../../../shared_imports';
 import type { FieldValueQueryBar } from '../../../rule_creation_ui/components/query_bar_field';
 import { QueryBarField } from '../../../rule_creation_ui/components/query_bar_field';
-import { esqlQueryRequiredValidatorFactory } from './validators/esql_query_required_validator_factory';
+import { esqlQueryRequiredValidator } from './validators/esql_query_required_validator';
 import { esqlQueryValidatorFactory } from './validators/esql_query_validator_factory';
 import { EsqlInfoIcon } from './esql_info_icon';
 import * as i18n from './translations';
@@ -62,7 +62,7 @@ export const EsqlQueryEdit = memo(function EsqlQueryEdit({
         ...(required
           ? [
               {
-                validator: esqlQueryRequiredValidatorFactory(),
+                validator: esqlQueryRequiredValidator,
               },
             ]
           : []),

diff --git a/.../esql_query_required_validator_factory.ts → ...lidators/esql_query_required_validator.ts b/.../esql_query_required_validator_factory.ts → ...lidators/esql_query_required_validator.ts
@@ -9,22 +9,14 @@ import { fieldValidators, type FormData, type ValidationFunc } from '../../../..
 import type { FieldValueQueryBar } from '../../../../rule_creation_ui/components/query_bar_field';
 import * as i18n from './translations';
 
-export function esqlQueryRequiredValidatorFactory(): ValidationFunc<
-  FormData,
-  string,
-  FieldValueQueryBar
-> {
-  return async (data) => {
-    const { value } = data;
-    const esqlQuery = value.query.query as string;
+export const esqlQueryRequiredValidator: ValidationFunc<FormData, string, FieldValueQueryBar> = (
+  data
+) => {
+  const { value } = data;
+  const esqlQuery = value.query.query as string;
 
-    if (esqlQuery.trim() === '') {
-      return;
-    }
-
-    return fieldValidators.emptyField(i18n.ESQL_QUERY_VALIDATION_REQUIRED)({
-      ...data,
-      value: esqlQuery,
-    });
-  };
-}
+  return fieldValidators.emptyField(i18n.ESQL_QUERY_VALIDATION_REQUIRED)({
+    ...data,
+    value: esqlQuery,
+  });
+};