Improve Lens code preventing an endless loop of update

elastic · Dec 15, 2023 · 75cc235 · 75cc235
1 parent 454592c
commit 75cc235
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/x-pack/plugins/lens/public/datasources/form_based/datapanel.tsx b/x-pack/plugins/lens/public/datasources/form_based/datapanel.tsx
@@ -299,11 +299,14 @@ export const InnerFormBasedDataPanel = function InnerFormBasedDataPanel({
     frame.dataViews.indexPatterns,
     data.search.session,
   ]);
+
   useEffect(() => {
     if (hasNewFields) {
       refreshFieldList();
     }
-  }, [hasNewFields, refreshFieldList]);
+    // Preventing a race condition, making sure refreshFieldList is just executed once when hasNewFields is true
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [hasNewFields]);
 
   const editField = useMemo(
     () =>