Skip to content

Commit

Permalink
[Synthetics] Require unifiedSearch plugin and include in top-level …
Browse files Browse the repository at this point in the history
…Kibana Context Provider (#178421)

## Summary

Resolves #173751.

Despite our reliance on `unifiedSearch`, our usage seems to have been
imperfect. This includes `unifiedSearch` in the list of required
plugins, and explicitly adds it to the creation of our
`KibanaContextProvider` at the root of the app. This seems to have
resolved the problem.

## Testing

Load the Synthetics UI and open the alerting flyout at the top of the
page. Add a connector. If you're able to toggle on the `If alert matches
query` feature, then the fix should be working. You can learn a bit more
about the expected failure by clicking through to the linked issue.


![20240311135128](https://github.com/elastic/kibana/assets/18429259/4625946d-e7f2-4bc0-96e6-69c38f609861)
  • Loading branch information
justinkambic authored Mar 12, 2024
1 parent 7981e5e commit 73a6e90
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
"taskManager",
"triggersActionsUi",
"usageCollection",
"bfetch"
"bfetch",
"unifiedSearch"
],
"optionalPlugins": [
"cloud",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ const Application = (props: SyntheticsAppProps) => {
cases: startPlugins.cases,
spaces: startPlugins.spaces,
fleet: startPlugins.fleet,
unifiedSearch: startPlugins.unifiedSearch,
}}
>
<SyntheticsDataViewContextProvider dataViews={startPlugins.dataViews}>
Expand Down

0 comments on commit 73a6e90

Please sign in to comment.