Skip to content

Commit

Permalink
[8.x] [FieldFormatters] Add support for rawValue in url label (#204192)…
Browse files Browse the repository at this point in the history
… (#204271)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[FieldFormatters] Add support for rawValue in url label
(#204192)](#204192)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-13T17:39:05Z","message":"[FieldFormatters]
Add support for rawValue in url label (#204192)\n\n##
Summary\r\n\r\nThis PR adds support for ```` in url
label.\r\n\r\nCloses:
#188973","sha":"f0d3a448eafab076b474a4aef1281be07ed680db","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:FieldFormatters","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[FieldFormatters]
Add support for rawValue in url
label","number":204192,"url":"https://github.com/elastic/kibana/pull/204192","mergeCommit":{"message":"[FieldFormatters]
Add support for rawValue in url label (#204192)\n\n##
Summary\r\n\r\nThis PR adds support for ```` in url
label.\r\n\r\nCloses:
#188973","sha":"f0d3a448eafab076b474a4aef1281be07ed680db"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204192","number":204192,"mergeCommit":{"message":"[FieldFormatters]
Add support for rawValue in url label (#204192)\n\n##
Summary\r\n\r\nThis PR adds support for ```` in url
label.\r\n\r\nCloses:
#188973","sha":"f0d3a448eafab076b474a4aef1281be07ed680db"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <[email protected]>
  • Loading branch information
kibanamachine and kowalczyk-krzysztof authored Dec 13, 2024
1 parent 5ee2c6a commit 712508c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
10 changes: 9 additions & 1 deletion src/plugins/field_formats/common/converters/url.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,22 @@ describe('UrlFormat', () => {
expect(url.convert('url', TEXT_CONTEXT_TYPE)).toBe('external url');
});

test('can use the raw value', () => {
test('can use the raw value with {{value}}', () => {
const url = new UrlFormat({
labelTemplate: 'external {{value}}',
});

expect(url.convert('url?', TEXT_CONTEXT_TYPE)).toBe('external url?');
});

test('can use the raw value with {{rawValue}}', () => {
const url = new UrlFormat({
labelTemplate: 'external {{rawValue}}',
});

expect(url.convert('url?', TEXT_CONTEXT_TYPE)).toBe('external url?');
});

test('can use the url', () => {
const url = new UrlFormat({
urlTemplate: 'http://google.com/{{value}}',
Expand Down
1 change: 1 addition & 0 deletions src/plugins/field_formats/common/converters/url.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export class UrlFormat extends FieldFormat {
return this.compileTemplate(template)({
value,
url,
rawValue: value,
});
}

Expand Down

0 comments on commit 712508c

Please sign in to comment.