Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.x] fix: [Search:SearchApplications:Connect page]Missing modal dial…
…og title from announcement (#199738) (#199870) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Search:SearchApplications:Connect page]Missing modal dialog title from announcement (#199738)](#199738) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T19:28:33Z","message":"fix: [Search:SearchApplications:Connect page]Missing modal dialog title from announcement (#199738)\n\nCloses: #199627\r\n\r\n## Description\r\nTitles for the dialogs are announced for the users, that users using\r\nassistive technology would know that the dialog opened and what dialog\r\nopened.\r\n\r\n## What was changed?:\r\n\r\n1. `aria-labelledby={modalTitleId}` was added. See\r\nhttps://eui.elastic.co/#/layout/modal for details\r\n\r\n## Screen: \r\n\r\n<img width=\"1289\" alt=\"Screenshot 2024-11-12 at 11 35 28\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3e1764-6617-4f50-82de-d6565a0e9c73\">","sha":"7fce0f0b2a91a3f384dbbb097d4de93fa00cf62e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix: [Search:SearchApplications:Connect page]Missing modal dialog title from announcement","number":199738,"url":"https://github.com/elastic/kibana/pull/199738","mergeCommit":{"message":"fix: [Search:SearchApplications:Connect page]Missing modal dialog title from announcement (#199738)\n\nCloses: #199627\r\n\r\n## Description\r\nTitles for the dialogs are announced for the users, that users using\r\nassistive technology would know that the dialog opened and what dialog\r\nopened.\r\n\r\n## What was changed?:\r\n\r\n1. `aria-labelledby={modalTitleId}` was added. See\r\nhttps://eui.elastic.co/#/layout/modal for details\r\n\r\n## Screen: \r\n\r\n<img width=\"1289\" alt=\"Screenshot 2024-11-12 at 11 35 28\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3e1764-6617-4f50-82de-d6565a0e9c73\">","sha":"7fce0f0b2a91a3f384dbbb097d4de93fa00cf62e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199738","number":199738,"mergeCommit":{"message":"fix: [Search:SearchApplications:Connect page]Missing modal dialog title from announcement (#199738)\n\nCloses: #199627\r\n\r\n## Description\r\nTitles for the dialogs are announced for the users, that users using\r\nassistive technology would know that the dialog opened and what dialog\r\nopened.\r\n\r\n## What was changed?:\r\n\r\n1. `aria-labelledby={modalTitleId}` was added. See\r\nhttps://eui.elastic.co/#/layout/modal for details\r\n\r\n## Screen: \r\n\r\n<img width=\"1289\" alt=\"Screenshot 2024-11-12 at 11 35 28\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3e1764-6617-4f50-82de-d6565a0e9c73\">","sha":"7fce0f0b2a91a3f384dbbb097d4de93fa00cf62e"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
- Loading branch information