[Sustainable Kibana Architecture] Address security group dependenci…

…es' issues (#197480) ## Summary In the scope of [Sustainable Kibana Architecture](elastic/kibana-team#1179), this PR fixes invalid dependencies from `security solution` code towards packages that are categorised as `group: 'platform', visibility: 'private'`. --------- Co-authored-by: kibanamachine <[email protected]>
elastic · Oct 25, 2024 · 6e3bf77 · 6e3bf77
1 parent 3ece950
commit 6e3bf77
Show file tree

Hide file tree

Showing 57 changed files with 114 additions and 112 deletions.
diff --git a/src/plugins/saved_objects_tagging_oss/common/index.ts b/src/plugins/saved_objects_tagging_oss/common/index.ts
@@ -10,6 +10,7 @@
 export type {
   Tag,
   TagAttributes,
+  CreateTagOptions,
   GetAllTagsOptions,
   ITagsClient,
   TagWithOptionalId,

diff --git a/x-pack/plugins/fleet/server/services/epm/kibana/assets/tag_assets.ts b/x-pack/plugins/fleet/server/services/epm/kibana/assets/tag_assets.ts
@@ -9,7 +9,8 @@ import { v5 as uuidv5 } from 'uuid';
 import { uniqBy } from 'lodash';
 import type { SavedObjectsImportSuccess } from '@kbn/core-saved-objects-common';
 import { taggableTypes } from '@kbn/saved-objects-tagging-plugin/common/constants';
-import type { IAssignmentService, ITagsClient } from '@kbn/saved-objects-tagging-plugin/server';
+import type { IAssignmentService } from '@kbn/saved-objects-tagging-plugin/server';
+import type { ITagsClient } from '@kbn/saved-objects-tagging-plugin/common/types';
 
 import type { KibanaAssetType } from '../../../../../common';
 import type { PackageSpecTags } from '../../../../types';

diff --git a/x-pack/plugins/global_search_bar/public/components/result_tag_list.tsx b/x-pack/plugins/global_search_bar/public/components/result_tag_list.tsx
@@ -5,10 +5,10 @@
  * 2.0.
  */
 
-import React, { FC } from 'react';
+import React, { type FC } from 'react';
 import { i18n } from '@kbn/i18n';
 import { EuiBadge } from '@elastic/eui';
-import type { Tag } from '@kbn/saved-objects-tagging-plugin/public';
+import type { Tag } from '@kbn/saved-objects-tagging-oss-plugin/common';
 
 const MAX_TAGS_TO_SHOW = 3;
 

diff --git a/x-pack/plugins/global_search_bar/public/lib/result_to_option.test.ts b/x-pack/plugins/global_search_bar/public/lib/result_to_option.test.ts
@@ -6,7 +6,7 @@
  */
 
 import type { GlobalSearchResult } from '@kbn/global-search-plugin/common/types';
-import { Tag } from '@kbn/saved-objects-tagging-plugin/public';
+import type { Tag } from '@kbn/saved-objects-tagging-oss-plugin/common';
 import { resultToOption } from './result_to_option';
 
 const createSearchResult = (parts: Partial<GlobalSearchResult> = {}): GlobalSearchResult => ({

diff --git a/x-pack/plugins/global_search_bar/public/lib/result_to_option.tsx b/x-pack/plugins/global_search_bar/public/lib/result_to_option.tsx
@@ -8,7 +8,8 @@
 import React from 'react';
 import type { EuiSelectableTemplateSitewideOption } from '@elastic/eui';
 import type { GlobalSearchResult } from '@kbn/global-search-plugin/common/types';
-import type { SavedObjectTaggingPluginStart, Tag } from '@kbn/saved-objects-tagging-plugin/public';
+import type { SavedObjectTaggingPluginStart } from '@kbn/saved-objects-tagging-plugin/public';
+import type { Tag } from '@kbn/saved-objects-tagging-oss-plugin/common';
 import { ResultTagList } from '../components/result_tag_list';
 
 const cleanMeta = (str: string) => (str.charAt(0).toUpperCase() + str.slice(1)).replace(/-/g, ' ');

diff --git a/x-pack/plugins/saved_objects_tagging/common/index.ts b/x-pack/plugins/saved_objects_tagging/common/index.ts
@@ -8,14 +8,6 @@
 export type { TagsCapabilities } from './capabilities';
 export { getTagsCapabilities } from './capabilities';
 export { tagFeatureId, tagSavedObjectTypeName, tagManagementSectionId } from './constants';
-export type {
-  TagWithRelations,
-  TagAttributes,
-  Tag,
-  ITagsClient,
-  TagSavedObject,
-  TagWithOptionalId,
-} from './types';
 export type { TagValidation } from './validation';
 export {
   validateTagColor,

diff --git a/x-pack/plugins/saved_objects_tagging/common/test_utils/index.ts b/x-pack/plugins/saved_objects_tagging/common/test_utils/index.ts
@@ -5,10 +5,10 @@
  * 2.0.
  */
 
-import { SavedObject, SavedObjectReference } from '@kbn/core/types';
-import { Tag, TagAttributes } from '../types';
-import { TagsCapabilities } from '../capabilities';
-import { AssignableObject } from '../assignments';
+import type { SavedObject, SavedObjectReference } from '@kbn/core/types';
+import type { Tag, TagAttributes } from '../types';
+import type { TagsCapabilities } from '../capabilities';
+import type { AssignableObject } from '../assignments';
 
 export const createReference = (type: string, id: string): SavedObjectReference => ({
   type,

diff --git a/x-pack/plugins/saved_objects_tagging/common/types.ts b/x-pack/plugins/saved_objects_tagging/common/types.ts
@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { SavedObject } from '@kbn/core/types';
+import type { SavedObject } from '@kbn/core/types';
 import type { Tag, TagAttributes } from '@kbn/saved-objects-tagging-oss-plugin/common';
 
 export type TagSavedObject = SavedObject<TagAttributes>;
@@ -20,6 +20,7 @@ export type TagWithRelations = Tag & {
 // re-export types from oss definition
 export type {
   Tag,
+  CreateTagOptions,
   TagAttributes,
   TagWithOptionalId,
   GetAllTagsOptions,

diff --git a/x-pack/plugins/saved_objects_tagging/common/validation.ts b/x-pack/plugins/saved_objects_tagging/common/validation.ts
@@ -6,7 +6,7 @@
  */
 
 import { i18n } from '@kbn/i18n';
-import { Tag } from './types';
+import type { Tag } from './types';
 
 export const tagNameMinLength = 2;
 export const tagNameMaxLength = 50;

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/base/tag_badge.tsx b/x-pack/plugins/saved_objects_tagging/public/components/base/tag_badge.tsx
@@ -5,10 +5,10 @@
  * 2.0.
  */
 
-import React, { ReactElement } from 'react';
+import React, { type ReactElement } from 'react';
 import { EuiBadge } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
-import { TagAttributes } from '../../../common/types';
+import type { TagAttributes } from '../../../common/types';
 
 export interface TagBadgeProps<T> {
   tag: T;

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/base/tag_list.tsx b/x-pack/plugins/saved_objects_tagging/public/components/base/tag_list.tsx
@@ -5,9 +5,9 @@
  * 2.0.
  */
 
-import React, { FC } from 'react';
+import React, { type FC } from 'react';
 import { EuiBadgeGroup } from '@elastic/eui';
-import { TagWithOptionalId } from '../../../common/types';
+import type { TagWithOptionalId } from '../../../common/types';
 import { TagBadge } from './tag_badge';
 
 export interface TagListProps {

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/base/tag_searchbar_option.tsx b/x-pack/plugins/saved_objects_tagging/public/components/base/tag_searchbar_option.tsx
@@ -5,9 +5,9 @@
  * 2.0.
  */
 
-import React, { FC } from 'react';
+import React, { type FC } from 'react';
 import { EuiHealth, EuiText } from '@elastic/eui';
-import { Tag } from '../../../common';
+import type { Tag } from '../../../common/types';
 import { testSubjFriendly } from '../../utils';
 
 export interface TagSearchBarOptionProps {

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/base/tag_selector.tsx b/x-pack/plugins/saved_objects_tagging/public/components/base/tag_selector.tsx
@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import React, { FC, useMemo, useCallback, useState } from 'react';
+import React, { type FC, useMemo, useCallback, useState } from 'react';
 import {
   EuiComboBox,
   EuiHealth,
@@ -17,9 +17,9 @@ import {
   EuiComboBoxProps,
 } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n-react';
-import { Tag } from '../../../common';
+import type { Tag } from '../../../common/types';
 import { testSubjFriendly } from '../../utils';
-import { CreateModalOpener } from '../edition_modal';
+import type { CreateModalOpener } from '../edition_modal';
 
 interface CreateOption {
   type: '__create_option__';

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/connected/tag_list.tsx b/x-pack/plugins/saved_objects_tagging/public/components/connected/tag_list.tsx
@@ -5,14 +5,14 @@
  * 2.0.
  */
 
-import React, { FC, useMemo } from 'react';
+import React, { type FC, useMemo } from 'react';
 import useObservable from 'react-use/lib/useObservable';
-import { SavedObjectReference } from '@kbn/core/types';
-import { TagListComponentProps } from '@kbn/saved-objects-tagging-oss-plugin/public';
-import { Tag, TagWithOptionalId } from '../../../common/types';
+import type { SavedObjectReference } from '@kbn/core/types';
+import type { TagListComponentProps } from '@kbn/saved-objects-tagging-oss-plugin/public';
+import type { Tag, TagWithOptionalId } from '../../../common/types';
 import { getObjectTags } from '../../utils';
 import { TagList } from '../base';
-import { ITagsCache } from '../../services';
+import type { ITagsCache } from '../../services';
 import { byNameTagSorter } from '../../utils';
 
 interface SavedObjectTagListProps {

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/connected/tag_selector.tsx b/x-pack/plugins/saved_objects_tagging/public/components/connected/tag_selector.tsx
@@ -5,13 +5,13 @@
  * 2.0.
  */
 
-import React, { FC } from 'react';
+import React, { type FC } from 'react';
 import useObservable from 'react-use/lib/useObservable';
-import { TagSelectorComponentProps } from '@kbn/saved-objects-tagging-oss-plugin/public';
-import { TagsCapabilities } from '../../../common';
+import type { TagSelectorComponentProps } from '@kbn/saved-objects-tagging-oss-plugin/public';
+import type { TagsCapabilities } from '../../../common';
 import { TagSelector } from '../base';
-import { ITagsCache } from '../../services';
-import { CreateModalOpener } from '../edition_modal';
+import type { ITagsCache } from '../../services';
+import type { CreateModalOpener } from '../edition_modal';
 
 interface GetConnectedTagSelectorOptions {
   cache: ITagsCache;

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/create_modal.test.tsx b/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/create_modal.test.tsx
@@ -8,8 +8,8 @@
 import React from 'react';
 import { render, screen } from '@testing-library/react';
 import { CreateTagModal } from './create_modal';
-import { IToasts, NotificationsStart } from '@kbn/core-notifications-browser';
-import { ITagsClient, Tag } from '@kbn/saved-objects-tagging-oss-plugin/common';
+import type { IToasts, NotificationsStart } from '@kbn/core-notifications-browser';
+import type { ITagsClient, Tag } from '../../../common/types';
 import { I18nProvider } from '@kbn/i18n-react';
 import userEvent from '@testing-library/user-event';
 import { duplicateTagNameErrorMessage, managedTagConflictMessage } from './utils';

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/create_modal.tsx b/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/create_modal.tsx
@@ -5,12 +5,12 @@
  * 2.0.
  */
 
-import React, { FC, useState, useCallback } from 'react';
+import React, { type FC, useState, useCallback } from 'react';
 import { first, lastValueFrom } from 'rxjs';
 import { i18n } from '@kbn/i18n';
 import type { NotificationsStart } from '@kbn/core/public';
 
-import { ITagsClient, Tag, TagAttributes } from '../../../common/types';
+import type { ITagsClient, Tag, TagAttributes } from '../../../common/types';
 import { isServerValidationError } from '../../services/tags';
 import { getRandomColor, validateTag } from './utils';
 import { CreateOrEditModal } from './create_or_edit_modal';

diff --git a/...ck/plugins/saved_objects_tagging/public/components/edition_modal/create_or_edit_modal.tsx b/...ck/plugins/saved_objects_tagging/public/components/edition_modal/create_or_edit_modal.tsx
@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import React, { FC, useState, useCallback, useMemo, useRef } from 'react';
+import React, { type FC, useState, useCallback, useMemo, useRef } from 'react';
 import {
   EuiButtonEmpty,
   EuiButton,
@@ -28,9 +28,9 @@ import {
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n-react';
 import useDebounce from 'react-use/lib/useDebounce';
+import type { TagAttributes } from '../../../common/types';
 import {
-  TagAttributes,
-  TagValidation,
+  type TagValidation,
   validateTagColor,
   tagNameMaxLength,
   tagDescriptionMaxLength,

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/edit_modal.tsx b/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/edit_modal.tsx
@@ -5,11 +5,11 @@
  * 2.0.
  */
 
-import React, { FC, useState, useCallback } from 'react';
+import React, { type FC, useState, useCallback } from 'react';
 import { i18n } from '@kbn/i18n';
 import type { NotificationsStart } from '@kbn/core/public';
 import { first, lastValueFrom } from 'rxjs';
-import { ITagsClient, Tag, TagAttributes } from '../../../common/types';
+import type { ITagsClient, Tag, TagAttributes } from '../../../common/types';
 import { isServerValidationError } from '../../services/tags';
 import { CreateOrEditModal } from './create_or_edit_modal';
 import { validateTag } from './utils';

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/open_modal.tsx b/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/open_modal.tsx
@@ -9,9 +9,9 @@ import React from 'react';
 import { EuiDelayRender, EuiLoadingSpinner } from '@elastic/eui';
 import type { OverlayRef } from '@kbn/core/public';
 import { toMountPoint } from '@kbn/react-kibana-mount';
-import { Tag, TagAttributes } from '../../../common/types';
-import { ITagInternalClient } from '../../services';
-import { StartServices } from '../../types';
+import type { Tag, TagAttributes } from '../../../common/types';
+import type { ITagInternalClient } from '../../services';
+import type { StartServices } from '../../types';
 
 interface GetModalOpenerOptions extends StartServices {
   tagClient: ITagInternalClient;

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/use_validation.ts b/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/use_validation.ts
@@ -9,8 +9,8 @@ import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
 import { BehaviorSubject } from 'rxjs';
 import useObservable from 'react-use/lib/useObservable';
 
-import { type TagValidation, validateTagName } from '../../../common';
 import type { ITagsClient, TagAttributes } from '../../../common/types';
+import { type TagValidation, validateTagName } from '../../../common';
 import { duplicateTagNameErrorMessage, managedTagConflictMessage, validateTag } from './utils';
 
 const initialValidation: TagValidation = {

diff --git a/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/utils.ts b/x-pack/plugins/saved_objects_tagging/public/components/edition_modal/utils.ts
@@ -8,9 +8,9 @@
 import { useCallback, useEffect, useRef } from 'react';
 import { i18n } from '@kbn/i18n';
 
+import type { TagAttributes } from '../../../common/types';
 import {
-  TagAttributes,
-  TagValidation,
+  type TagValidation,
   validateTagColor,
   validateTagName,
   validateTagDescription,

diff --git a/x-pack/plugins/saved_objects_tagging/public/index.ts b/x-pack/plugins/saved_objects_tagging/public/index.ts
@@ -9,7 +9,6 @@ import { PluginInitializerContext } from '@kbn/core/public';
 import { SavedObjectTaggingPlugin } from './plugin';
 
 export type { SavedObjectTaggingPluginStart } from './types';
-export type { Tag } from '../common';
 
 export const plugin = (initializerContext: PluginInitializerContext) =>
   new SavedObjectTaggingPlugin(initializerContext);
diff --git a/x-pack/plugins/saved_objects_tagging/public/management/actions/assign.ts b/x-pack/plugins/saved_objects_tagging/public/management/actions/assign.ts
@@ -7,7 +7,7 @@
 
 import { i18n } from '@kbn/i18n';
 import { Observable, from, takeUntil } from 'rxjs';
-import { TagWithRelations } from '../../../common';
+import { TagWithRelations } from '../../../common/types';
 import { getAssignFlyoutOpener } from '../../components/assign_flyout';
 import { ITagAssignmentService } from '../../services/assignments';
 import { ITagsCache } from '../../services/tags';

diff --git a/x-pack/plugins/saved_objects_tagging/public/management/actions/delete.ts b/x-pack/plugins/saved_objects_tagging/public/management/actions/delete.ts
@@ -7,7 +7,7 @@
 
 import { i18n } from '@kbn/i18n';
 import { NotificationsStart, OverlayStart } from '@kbn/core/public';
-import { TagWithRelations } from '../../../common';
+import { TagWithRelations } from '../../../common/types';
 import { ITagInternalClient } from '../../services/tags';
 import { TagAction } from './types';
 

diff --git a/x-pack/plugins/saved_objects_tagging/public/management/actions/edit.ts b/x-pack/plugins/saved_objects_tagging/public/management/actions/edit.ts
@@ -6,7 +6,7 @@
  */
 
 import { i18n } from '@kbn/i18n';
-import { TagWithRelations } from '../../../common';
+import { TagWithRelations } from '../../../common/types';
 import { getEditModalOpener } from '../../components/edition_modal';
 import { ITagInternalClient } from '../../services/tags';
 import { StartServices } from '../../types';

diff --git a/x-pack/plugins/saved_objects_tagging/public/management/actions/types.ts b/x-pack/plugins/saved_objects_tagging/public/management/actions/types.ts
@@ -6,7 +6,7 @@
  */
 
 import { Action as EuiTableAction } from '@elastic/eui/src/components/basic_table/action_types';
-import { TagWithRelations } from '../../../common';
+import { TagWithRelations } from '../../../common/types';
 
 export type TagAction = EuiTableAction<TagWithRelations> & {
   id: string;

diff --git a/x-pack/plugins/saved_objects_tagging/public/management/components/table.tsx b/x-pack/plugins/saved_objects_tagging/public/management/components/table.tsx
@@ -10,7 +10,8 @@ import { EuiInMemoryTable, EuiBasicTableColumn, EuiLink, Query, EuiIconTip } fro
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n-react';
 import { euiThemeVars } from '@kbn/ui-theme';
-import { TagsCapabilities, TagWithRelations } from '../../../common';
+import { TagsCapabilities } from '../../../common';
+import type { TagWithRelations } from '../../../common/types';
 import { TagBadge } from '../../components';
 import { TagAction } from '../actions';
 

diff --git a/x-pack/plugins/saved_objects_tagging/public/management/tag_management_page.tsx b/x-pack/plugins/saved_objects_tagging/public/management/tag_management_page.tsx
@@ -12,10 +12,11 @@ import { Query } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import { ChromeBreadcrumb, CoreStart } from '@kbn/core/public';
 import { EuiSpacer } from '@elastic/eui';
-import { TagWithRelations, TagsCapabilities } from '../../common';
+import { TagsCapabilities } from '../../common';
+import type { TagWithRelations } from '../../common/types';
 import { getCreateModalOpener } from '../components/edition_modal';
 import { ITagInternalClient, ITagAssignmentService, ITagsCache } from '../services';
-import { TagBulkAction } from './types';
+import type { TagBulkAction } from './types';
 import { Header, TagTable, ActionBar } from './components';
 import { getTableActions } from './actions';
 import { getBulkActions } from './bulk_actions';

diff --git a/x-pack/plugins/saved_objects_tagging/public/management/utils/get_tag_connections_url.test.ts b/x-pack/plugins/saved_objects_tagging/public/management/utils/get_tag_connections_url.test.ts
@@ -7,7 +7,7 @@
 
 import { httpServiceMock } from '@kbn/core/public/mocks';
 import { getTagConnectionsUrl } from './get_tag_connections_url';
-import { TagWithRelations } from '../../../common/types';
+import type { TagWithRelations } from '../../../common/types';
 
 const createTag = (name: string): TagWithRelations => ({
   id: 'tag-id',

diff --git a/x-pack/plugins/saved_objects_tagging/public/management/utils/get_tag_connections_url.ts b/x-pack/plugins/saved_objects_tagging/public/management/utils/get_tag_connections_url.ts
@@ -5,8 +5,8 @@
  * 2.0.
  */
 
-import { IBasePath } from '@kbn/core/public';
-import { TagWithRelations } from '../../../common/types';
+import type { IBasePath } from '@kbn/core/public';
+import type { TagWithRelations } from '../../../common/types';
 
 /**
  * Returns the url to use to redirect to the SavedObject management section with given tag

diff --git a/x-pack/plugins/saved_objects_tagging/public/services/tags/tags_cache.test.ts b/x-pack/plugins/saved_objects_tagging/public/services/tags/tags_cache.test.ts
@@ -6,8 +6,8 @@
  */
 
 import moment from 'moment';
-import { Tag, TagAttributes } from '../../../common/types';
-import { TagsCache, CacheRefreshHandler } from './tags_cache';
+import type { Tag, TagAttributes } from '../../../common/types';
+import { TagsCache, type CacheRefreshHandler } from './tags_cache';
 
 const createTag = (parts: Partial<Tag>): Tag => ({
   id: 'tag-id',