Skip to content

Commit

Permalink
[8.x] [Index Management] Small copy change for index settings callout (
Browse files Browse the repository at this point in the history
…#201264) (#201615)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Index Management] Small copy change for index settings callout
(#201264)](#201264)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Elena
Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T14:40:16Z","message":"[Index
Management] Small copy change for index settings callout (#201264)\n\n##
Summary\r\n\r\nA small update on the copy of the index settings callout,
based on\r\nfeedback we received from @tylerperk.\r\n\r\n<img
width=\"1516\" alt=\"Screenshot 2024-11-21 at 18 07
40\"\r\nsrc=\"https://github.com/user-attachments/assets/7e50b60c-abb8-472d-b0c2-6b98fc0d1026\">","sha":"cb63818b6faccdd9602cc1992b8bb337913fc9a7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor","v8.17.0","v8.18.0"],"title":"[Index
Management] Small copy change for index settings
callout","number":201264,"url":"https://github.com/elastic/kibana/pull/201264","mergeCommit":{"message":"[Index
Management] Small copy change for index settings callout (#201264)\n\n##
Summary\r\n\r\nA small update on the copy of the index settings callout,
based on\r\nfeedback we received from @tylerperk.\r\n\r\n<img
width=\"1516\" alt=\"Screenshot 2024-11-21 at 18 07
40\"\r\nsrc=\"https://github.com/user-attachments/assets/7e50b60c-abb8-472d-b0c2-6b98fc0d1026\">","sha":"cb63818b6faccdd9602cc1992b8bb337913fc9a7"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201264","number":201264,"mergeCommit":{"message":"[Index
Management] Small copy change for index settings callout (#201264)\n\n##
Summary\r\n\r\nA small update on the copy of the index settings callout,
based on\r\nfeedback we received from @tylerperk.\r\n\r\n<img
width=\"1516\" alt=\"Screenshot 2024-11-21 at 18 07
40\"\r\nsrc=\"https://github.com/user-attachments/assets/7e50b60c-abb8-472d-b0c2-6b98fc0d1026\">","sha":"cb63818b6faccdd9602cc1992b8bb337913fc9a7"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Elena Stoeva <[email protected]>
  • Loading branch information
kibanamachine and ElenaStoeva authored Nov 25, 2024
1 parent ab9316d commit 6df27c8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ describe('<TemplateCreate />', () => {

expect(exists('indexModeCallout')).toBe(true);
expect(find('indexModeCallout').text()).toContain(
'The index.mode setting has been set to Standard within template Logistics.'
'The index.mode setting has been set to Standard within the Logistics step.'
);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const StepSettings: React.FunctionComponent<Props> = React.memo(
title={
<FormattedMessage
id="xpack.idxMgmt.formWizard.stepSettings.indexModeCallout.title"
defaultMessage="The {settingName} setting has been set to {indexMode} within template {logisticsLink}. Any changes to {settingName} set on this page will be overwritten by the Logistics selection."
defaultMessage="The {settingName} setting has been set to {indexMode} within the {logisticsLink}. Any changes to {settingName} set on this page will be overwritten by the Logistics selection."
values={{
settingName: (
<EuiCode>
Expand All @@ -110,7 +110,7 @@ export const StepSettings: React.FunctionComponent<Props> = React.memo(
{i18n.translate(
'xpack.idxMgmt.formWizard.stepSettings.indexModeCallout.logisticsLinkLabel',
{
defaultMessage: 'Logistics',
defaultMessage: 'Logistics step',
}
)}
</EuiLink>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
// Verify that index mode callout is displayed
const indexModeCalloutText = await testSubjects.getVisibleText('indexModeCallout');
expect(indexModeCalloutText).to.be(
'The index.mode setting has been set to Standard within template Logistics. Any changes to index.mode set on this page will be overwritten by the Logistics selection.'
'The index.mode setting has been set to Standard within the Logistics step. Any changes to index.mode set on this page will be overwritten by the Logistics selection.'
);

// Click Next button
Expand Down

0 comments on commit 6df27c8

Please sign in to comment.