Self-code review 1/10

elastic · Nov 26, 2024 · 6d6ce5a · 6d6ce5a
1 parent 1845efb
commit 6d6ce5a
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 13 deletions.
diff --git a/...lugins/security_solution/common/api/entity_analytics/entity_store/engine/list.schema.yaml b/...lugins/security_solution/common/api/entity_analytics/entity_store/engine/list.schema.yaml
@@ -9,7 +9,6 @@ paths:
       x-codegen-enabled: true
       operationId: ListEntityEngines
       summary: List the Entity Engines
-
       responses:
         '200':
           description: Successful response

diff --git a/...ns/security_solution/server/lib/entity_analytics/entity_store/entity_store_data_client.ts b/...ns/security_solution/server/lib/entity_analytics/entity_store/entity_store_data_client.ts
@@ -265,17 +265,6 @@ export class EntityStoreDataClient {
     }
   }
 
-  // [x] TS types and openAPI
-  // [x] check if this change should be part of another API
-  // [x] fix UI types
-  // [x] refactor UI
-  // TODO test for error state
-  // TODO API tests
-  // TODO Unit tests?
-  // TODO create openAPI doc and defines returned types  interface EntityState {}
-  // TODO does calling `GET kbn:/api/entity_store/engines/user` on a clean cluster kill Kibana?
-  // TODO investigate why we list engines for user without saved object privileges (see message from Mark)
-
   public async init(
     entityType: EntityType,
     { indexPattern = '', filter = '', fieldHistoryLength = 10 }: InitEntityEngineRequestBody,

diff --git a/x-pack/plugins/security_solution/server/lib/entity_analytics/entity_store/routes/list.ts b/x-pack/plugins/security_solution/server/lib/entity_analytics/entity_store/routes/list.ts
@@ -39,7 +39,6 @@ export const listEntityEnginesRoute = (
 
         try {
           const secSol = await context.securitySolution;
-          // should includeStatus be snake case?
           const body = await secSol.getEntityStoreDataClient().list();
 
           return response.ok({ body });