-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Custom threshold] Add group by filters to the custom threshold view …
…in app URL (#177016) Resolves #173713 ## Summary This PR adds group by filters to the view in the app URL for the custom threshold rule: ![image](https://github.com/elastic/kibana/assets/12370520/c84eecfc-b196-4268-acdd-57bae86ac4c4) I also moved some types to the common folder and adjusted them to match the reality. ## 🧪 How to test - Create a custom threshold rule with group by - One with persisted data view - One with an ad-hoc data view - Check the view in app link in the alerts table, you should also see the group filters there. - Check the view in app URL from the actions, it should also include the group filters.
- Loading branch information
1 parent
bf4b70c
commit 637de1d
Showing
33 changed files
with
301 additions
and
142 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 28 additions & 28 deletions
56
...plugins/alerting/server/integration_tests/__snapshots__/alert_as_data_fields.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.