Revert "remove error_boundary from core-application-browser-internal"

This reverts commit bf11b802b2258482349deb65740f4d96ff1a81b5.
elastic · Oct 14, 2023 · 6371301 · 6371301
1 parent 642c396
commit 6371301
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/packages/core/application/core-application-browser-internal/src/ui/app_container.tsx b/packages/core/application/core-application-browser-internal/src/ui/app_container.tsx
@@ -22,6 +22,11 @@ import {
   type AppUnmount,
   type ScopedHistory,
 } from '@kbn/core-application-browser';
+import {
+  KibanaErrorBoundary,
+  KibanaErrorBoundaryKibanaProvider,
+} from '@kbn/shared-ux-error-boundary';
+
 import type { Mounter } from '../types';
 import { AppNotFound } from './app_not_found_screen';
 
@@ -53,6 +58,7 @@ export const AppContainer: FC<Props> = ({
 }: Props) => {
   const [showSpinner, setShowSpinner] = useState(true);
   const [appNotFound, setAppNotFound] = useState(false);
+  const [appError, setAppError] = useState<Error | null>(null);
   const elementRef = useRef<HTMLDivElement>(null);
   const unmountRef: MutableRefObject<AppUnmount | null> = useRef<AppUnmount>(null);
 
@@ -87,9 +93,9 @@ export const AppContainer: FC<Props> = ({
             setHeaderActionMenu: (menuMount) => setAppActionMenu(appId, menuMount),
           })) || null;
       } catch (e) {
-        // TODO: add error UI
         // eslint-disable-next-line no-console
         console.error(e);
+        setAppError(e);
       } finally {
         if (elementRef.current) {
           setShowSpinner(false);
@@ -113,7 +119,11 @@ export const AppContainer: FC<Props> = ({
     theme$,
   ]);
 
-  return (
+  return appError ? (
+    <KibanaErrorBoundaryKibanaProvider toasts={null}>
+      <KibanaErrorBoundary as="callout" error={appError} />
+    </KibanaErrorBoundaryKibanaProvider>
+  ) : (
     <Fragment>
       {appNotFound && <AppNotFound />}
       {showSpinner && !appNotFound && (

diff --git a/packages/core/application/core-application-browser-internal/tsconfig.json b/packages/core/application/core-application-browser-internal/tsconfig.json
@@ -36,6 +36,7 @@
     "@kbn/core-analytics-browser-mocks",
     "@kbn/core-analytics-browser",
     "@kbn/shared-ux-router",
+    "@kbn/shared-ux-error-boundary",
   ],
   "exclude": [
     "target/**/*",