Skip to content

Commit

Permalink
[8.x] Clean code related to savedObjectClientContrat that wasn't bein…
Browse files Browse the repository at this point in the history
…g used (#200629) (#200859)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Clean code related to savedObjectClientContrat that wasn't being used
(#200629)](#200629)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jesus
Wahrman","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-19T10:46:18Z","message":"Clean
code related to savedObjectClientContrat that wasn't being used
(#200629)\n\n## Summary\r\n\r\nResolves:
https://github.com/elastic/kibana/issues/197216\r\n\r\nRemoved all code
that wasn't being used
in\r\nhttps://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public.\r\nDidn't
remove the actual client since it's still being used
here:\r\nhttps://github.com/elastic/kibana/blob/dbab2214e9451d3a262007660cc0b7cdcea5307c/src/plugins/home/public/application/kibana_services.ts#L46-L48\r\n\r\nChecked
everything with `node scripts/type_check`\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] The PR description includes the appropriate Release
Notes section,\r\nand the correct `release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"d900299e731fccaca5c70889371a2760da794da1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Saved
Objects","release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"number":200629,"url":"https://github.com/elastic/kibana/pull/200629","mergeCommit":{"message":"Clean
code related to savedObjectClientContrat that wasn't being used
(#200629)\n\n## Summary\r\n\r\nResolves:
https://github.com/elastic/kibana/issues/197216\r\n\r\nRemoved all code
that wasn't being used
in\r\nhttps://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public.\r\nDidn't
remove the actual client since it's still being used
here:\r\nhttps://github.com/elastic/kibana/blob/dbab2214e9451d3a262007660cc0b7cdcea5307c/src/plugins/home/public/application/kibana_services.ts#L46-L48\r\n\r\nChecked
everything with `node scripts/type_check`\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] The PR description includes the appropriate Release
Notes section,\r\nand the correct `release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"d900299e731fccaca5c70889371a2760da794da1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200629","number":200629,"mergeCommit":{"message":"Clean
code related to savedObjectClientContrat that wasn't being used
(#200629)\n\n## Summary\r\n\r\nResolves:
https://github.com/elastic/kibana/issues/197216\r\n\r\nRemoved all code
that wasn't being used
in\r\nhttps://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public.\r\nDidn't
remove the actual client since it's still being used
here:\r\nhttps://github.com/elastic/kibana/blob/dbab2214e9451d3a262007660cc0b7cdcea5307c/src/plugins/home/public/application/kibana_services.ts#L46-L48\r\n\r\nChecked
everything with `node scripts/type_check`\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] The PR description includes the appropriate Release
Notes section,\r\nand the correct `release_node:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"d900299e731fccaca5c70889371a2760da794da1"}}]}]
BACKPORT-->
  • Loading branch information
jesuswr authored Nov 20, 2024
1 parent f175595 commit 600d6d0
Show file tree
Hide file tree
Showing 24 changed files with 7 additions and 1,014 deletions.
2 changes: 1 addition & 1 deletion src/plugins/saved_objects/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { SavedObjectsPublicPlugin } from './plugin';

export type { OnSaveProps, OriginSaveModalProps, SaveModalState, SaveResult } from './save_modal';
export { SavedObjectSaveModal, SavedObjectSaveModalOrigin, showSaveModal } from './save_modal';
export { checkForDuplicateTitle, saveWithConfirmation, isErrorNonFatal } from './saved_object';
export { isErrorNonFatal } from './saved_object';
export type { SavedObjectSaveOpts, SavedObject, SavedObjectConfig } from './types';

export const plugin = () => new SavedObjectsPublicPlugin();
101 changes: 0 additions & 101 deletions src/plugins/saved_objects/public/saved_object/helpers/apply_es_resp.ts

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 600d6d0

Please sign in to comment.