Skip to content

Commit

Permalink
[Dashboard] Fix incorrect actions in edit mode after discarding unsav…
Browse files Browse the repository at this point in the history
…ed changes (#200230)

## Summary

Closes #197870.

The `isCompatible` check on the edit drilldown action was throwing an
unhandled promise error that prevented the actions for drilldown
compatible panels when trying to access `event` off an undefined
`dynamicActions` object. This ensures that `dynamicActions` is always a
defined object.

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
  • Loading branch information
cqliu1 authored Nov 14, 2024
1 parent ba6ffec commit 53dd55b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions x-pack/plugins/embeddable_enhanced/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ export class EmbeddableEnhancedPlugin
);
const api: DynamicActionStorageApi = {
dynamicActionsState$,
setDynamicActions: (newState) => {
dynamicActionsState$.next(newState);
setDynamicActions: (enhancements) => {
dynamicActionsState$.next(getDynamicActionsState(enhancements));
},
};
const storage = new DynamicActionStorage(uuid, getTitle, api);
Expand Down

0 comments on commit 53dd55b

Please sign in to comment.