Disabling try again button while model is still deploying

elastic · Oct 30, 2024 · 518a96e · 518a96e
1 parent 7d673b8
commit 518a96e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...t/__jest__/client_integration/index_details_page/trained_models_deployment_modal.test.tsx b/...t/__jest__/client_integration/index_details_page/trained_models_deployment_modal.test.tsx
@@ -173,11 +173,8 @@ describe('When semantic_text is enabled', () => {
       );
     });
 
-    it('should call saveMappings if refresh button is pressed', async () => {
-      await act(async () => {
-        find('tryAgainModalButton').simulate('click');
-      });
-      expect(saveMappings.mock.calls).toHaveLength(1);
+    it('should disable the try again button', () => {
+      expect(find('tryAgainModalButton').props().disabled).toBe(true);
     });
     it('should disable the force save mappings button if checkbox is not checked', async () => {
       expect(find('forceSaveMappingsButton').props().disabled).toBe(true);

diff --git a/...lic/application/sections/home/index_list/details_page/trained_models_deployment_modal.tsx b/...lic/application/sections/home/index_list/details_page/trained_models_deployment_modal.tsx
@@ -155,7 +155,9 @@ export function TrainedModelsDeploymentModal({
       aria-labelledby={modalTitleId}
       onClose={closeModal}
       data-test-subj="trainedModelsDeploymentModal"
-      initialFocus="[data-test-subj=tryAgainModalButton]"
+      initialFocus={
+        erroredDeployments.length === 0 ? undefined : '[data-test-subj=tryAgainModalButton]'
+      }
     >
       <EuiModalHeader>
         <EuiModalHeaderTitle title={modalTitleId}>
@@ -260,6 +262,7 @@ export function TrainedModelsDeploymentModal({
               onClick={saveMappings}
               data-test-subj="tryAgainModalButton"
               isLoading={saveMappingsLoading}
+              disabled={erroredDeployments.length === 0}
             >
               {i18n.translate(
                 'xpack.idxMgmt.indexDetails.trainedModelsDeploymentModal.tryAgainButtonLabel',