Skip to content

Commit

Permalink
fix: (Accessibility) Map visualization Layers palette has duplicated …
Browse files Browse the repository at this point in the history
…IDs (#195577)

Closes: #151925

## Description  
Map visualization Layers palette has duplicated IDs

## Steps to reproduce

1. Load the Flights sample data set into Kibana
2. Navigate to the Dashboard view
3. Run an axe scan using the [Axe browser
plugin](https://deque.com/axe/) (Chrome, Edge, or Firefox required)
4. Under the `Minor` issue type there should be 3 "ID attribute values
must be unique" errors

## What was changed?:

1. Removed unnecessary id's attributes.

## Screen: 

<img width="1017" alt="image"
src="https://github.com/user-attachments/assets/bda0128f-4757-4879-af1e-6a449938b1e0">
  • Loading branch information
alexwizp authored Oct 14, 2024
1 parent 500ac5b commit 4ef2a3f
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 19 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -324,12 +324,7 @@ export class TOCEntry extends Component<Props, State> {
this.props.depth > 0 ? { paddingLeft: `${8 + this.props.depth * 24}px` } : {};

return (
<div
style={depthStyle}
className={classes}
id={this.props.layer.getId()}
data-layerid={this.props.layer.getId()}
>
<div style={depthStyle} className={classes} data-layerid={this.props.layer.getId()}>
{this._renderLayerHeader()}

{this.props.isLegendDetailsOpen &&
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ export class TOCEntryActionsPopover extends Component<Props, State> {
<>
{removeModal}
<EuiPopover
id={this.props.layer.getId()}
className="mapLayTocActions"
button={
<TOCEntryButton
Expand Down

0 comments on commit 4ef2a3f

Please sign in to comment.