code review feedback

elastic · Sep 19, 2024 · 460084b · 460084b
1 parent b0fb938
commit 460084b
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/plugins/dashboard/public/dashboard_app/dashboard_app.test.tsx b/src/plugins/dashboard/public/dashboard_app/dashboard_app.test.tsx
@@ -60,6 +60,7 @@ describe('Dashboard App', () => {
     render(<DashboardApp redirectTo={jest.fn()} history={mockHistory} />);
 
     await waitFor(() => {
+      expect(expandPanelSpyInRouter).not.toHaveBeenCalled();
       // this value should be undefined by default
       expect(mockDashboard.expandedPanelId.getValue()).toBe(undefined);
       // history should not be called
@@ -87,6 +88,7 @@ describe('Dashboard App', () => {
 
     // simulate minimizing a panel
     mockDashboard.expandedPanelId.next(undefined);
+
     await waitFor(() => {
       expect(mockDashboard.expandedPanelId.getValue()).toBe(undefined);
       expect(historySpy).toHaveBeenCalledTimes(1);