[SLO] Rename Partition by to Group by (#173239)

Resolves #172210
elastic · Dec 13, 2023 · 43b48ad · 43b48ad
1 parent fd25bb1
commit 43b48ad
Show file tree

Hide file tree

Showing 13 changed files with 36 additions and 45 deletions.
diff --git a/...k/plugins/observability/public/components/burn_rate_rule_editor/burn_rate_rule_editor.tsx b/...k/plugins/observability/public/components/burn_rate_rule_editor/burn_rate_rule_editor.tsx
@@ -111,7 +111,7 @@ export function BurnRateRuleEditor(props: Props) {
             size="s"
             title={i18n.translate('xpack.observability.slo.rules.groupByMessage', {
               defaultMessage:
-                'The SLO you selected has been created with a partition on "{groupByField}". This rule will monitor and generate an alert for every instance found in the partition field.',
+                'The SLO you selected has been created with a group-by on "{groupByField}". This rule will monitor and generate an alert for every instance found in the group-by field.',
               values: { groupByField: selectedSlo.groupBy },
             })}
           />

diff --git a/...ability/public/components/slo/delete_confirmation_modal/slo_delete_confirmation_modal.tsx b/...ability/public/components/slo/delete_confirmation_modal/slo_delete_confirmation_modal.tsx
@@ -42,14 +42,11 @@ export function SloDeleteConfirmationModal({
       onConfirm={onConfirm}
     >
       {groupBy !== ALL_VALUE
-        ? i18n.translate(
-            'xpack.observability.slo.deleteConfirmationModal.partitionByDisclaimerText',
-            {
-              defaultMessage:
-                'This SLO has been generated with a partition key on "{partitionKey}". Deleting this SLO definition will result in all instances being deleted.',
-              values: { partitionKey: groupBy },
-            }
-          )
+        ? i18n.translate('xpack.observability.slo.deleteConfirmationModal.groupByDisclaimerText', {
+            defaultMessage:
+              'This SLO has been generated with a group key on "{groupKey}". Deleting this SLO definition will result in all instances being deleted.',
+            values: { groupKey: groupBy },
+          })
         : i18n.translate('xpack.observability.slo.deleteConfirmationModal.descriptionText', {
             defaultMessage: "You can't recover this SLO after deleting it.",
           })}

diff --git a/x-pack/plugins/observability/public/components/slo/slo_status_badge/slo_group_by_badge.tsx b/x-pack/plugins/observability/public/components/slo/slo_status_badge/slo_group_by_badge.tsx
@@ -26,10 +26,10 @@ export function SloGroupByBadge({ slo, color }: Props) {
       <EuiBadge color={color ?? euiLightVars.euiColorDisabled}>
         <EuiToolTip
           position="top"
-          content={i18n.translate('xpack.observability.slo.partitionByBadge', {
-            defaultMessage: 'Partition by {partitionKey}',
+          content={i18n.translate('xpack.observability.slo.groupByBadge', {
+            defaultMessage: 'Group by {groupKey}',
             values: {
-              partitionKey: slo.groupBy,
+              groupKey: slo.groupBy,
             },
           })}
           display="block"

diff --git a/...ublic/pages/slo_edit/components/apm_availability/apm_availability_indicator_type_form.tsx b/...ublic/pages/slo_edit/components/apm_availability/apm_availability_indicator_type_form.tsx
@@ -30,7 +30,7 @@ export function ApmAvailabilityIndicatorTypeForm() {
 
   const { isLoading: isIndexFieldsLoading, data: indexFields = [] } =
     useFetchIndexPatternFields(apmIndex);
-  const partitionByFields = indexFields.filter((field) => field.aggregatable);
+  const groupByFields = indexFields.filter((field) => field.aggregatable);
 
   return (
     <EuiFlexGroup direction="column" gutterSize="l">
@@ -135,13 +135,13 @@ export function ApmAvailabilityIndicatorTypeForm() {
       </EuiFlexGroup>
 
       <IndexFieldSelector
-        indexFields={partitionByFields}
+        indexFields={groupByFields}
         name="groupBy"
         defaultValue={ALL_VALUE}
         label={
           <span>
             {i18n.translate('xpack.observability.slo.sloEdit.groupBy.label', {
-              defaultMessage: 'Partition by',
+              defaultMessage: 'Group by',
             })}{' '}
             <EuiIconTip
               content={i18n.translate('xpack.observability.slo.sloEdit.groupBy.tooltip', {
@@ -152,7 +152,7 @@ export function ApmAvailabilityIndicatorTypeForm() {
           </span>
         }
         placeholder={i18n.translate('xpack.observability.slo.sloEdit.groupBy.placeholder', {
-          defaultMessage: 'Select an optional field to partition by',
+          defaultMessage: 'Select an optional field to group by',
         })}
         isLoading={!!apmIndex && isIndexFieldsLoading}
         isDisabled={!apmIndex}

diff --git a/...vability/public/pages/slo_edit/components/apm_latency/apm_latency_indicator_type_form.tsx b/...vability/public/pages/slo_edit/components/apm_latency/apm_latency_indicator_type_form.tsx
@@ -30,7 +30,7 @@ export function ApmLatencyIndicatorTypeForm() {
 
   const { isLoading: isIndexFieldsLoading, data: indexFields = [] } =
     useFetchIndexPatternFields(apmIndex);
-  const partitionByFields = indexFields.filter((field) => field.aggregatable);
+  const groupByFields = indexFields.filter((field) => field.aggregatable);
 
   return (
     <EuiFlexGroup direction="column" gutterSize="l">
@@ -178,13 +178,13 @@ export function ApmLatencyIndicatorTypeForm() {
       </EuiFlexGroup>
 
       <IndexFieldSelector
-        indexFields={partitionByFields}
+        indexFields={groupByFields}
         name="groupBy"
         defaultValue={ALL_VALUE}
         label={
           <span>
             {i18n.translate('xpack.observability.slo.sloEdit.groupBy.label', {
-              defaultMessage: 'Partition by',
+              defaultMessage: 'Group by',
             })}{' '}
             <EuiIconTip
               content={i18n.translate('xpack.observability.slo.sloEdit.groupBy.tooltip', {
@@ -195,7 +195,7 @@ export function ApmLatencyIndicatorTypeForm() {
           </span>
         }
         placeholder={i18n.translate('xpack.observability.slo.sloEdit.groupBy.placeholder', {
-          defaultMessage: 'Select an optional field to partition by',
+          defaultMessage: 'Select an optional field to group by',
         })}
         isLoading={!!apmIndex && isIndexFieldsLoading}
         isDisabled={!apmIndex}

diff --git a/...ervability/public/pages/slo_edit/components/custom_kql/custom_kql_indicator_type_form.tsx b/...ervability/public/pages/slo_edit/components/custom_kql/custom_kql_indicator_type_form.tsx
@@ -23,7 +23,7 @@ export function CustomKqlIndicatorTypeForm() {
   const { isLoading: isIndexFieldsLoading, data: indexFields = [] } =
     useFetchIndexPatternFields(index);
   const timestampFields = indexFields.filter((field) => field.type === 'date');
-  const partitionByFields = indexFields.filter((field) => field.aggregatable);
+  const groupByFields = indexFields.filter((field) => field.aggregatable);
 
   return (
     <EuiFlexGroup direction="column" gutterSize="l">
@@ -135,13 +135,13 @@ export function CustomKqlIndicatorTypeForm() {
       </EuiFlexItem>
 
       <IndexFieldSelector
-        indexFields={partitionByFields}
+        indexFields={groupByFields}
         name="groupBy"
         defaultValue={ALL_VALUE}
         label={
           <span>
             {i18n.translate('xpack.observability.slo.sloEdit.groupBy.label', {
-              defaultMessage: 'Partition by',
+              defaultMessage: 'Group by',
             })}{' '}
             <EuiIconTip
               content={i18n.translate('xpack.observability.slo.sloEdit.groupBy.tooltip', {
@@ -152,7 +152,7 @@ export function CustomKqlIndicatorTypeForm() {
           </span>
         }
         placeholder={i18n.translate('xpack.observability.slo.sloEdit.groupBy.placeholder', {
-          defaultMessage: 'Select an optional field to partition by',
+          defaultMessage: 'Select an optional field to group by',
         })}
         isLoading={!!index && isIndexFieldsLoading}
         isDisabled={!index}

diff --git a/.../observability/public/pages/slo_edit/components/custom_metric/custom_metric_type_form.tsx b/.../observability/public/pages/slo_edit/components/custom_metric/custom_metric_type_form.tsx
@@ -36,7 +36,7 @@ export function CustomMetricIndicatorTypeForm() {
   const { isLoading: isIndexFieldsLoading, data: indexFields = [] } =
     useFetchIndexPatternFields(index);
   const timestampFields = indexFields.filter((field) => field.type === 'date');
-  const partitionByFields = indexFields.filter((field) => field.aggregatable);
+  const groupByFields = indexFields.filter((field) => field.aggregatable);
   const metricFields = indexFields.filter((field) =>
     SUPPORTED_METRIC_FIELD_TYPES.includes(field.type)
   );
@@ -152,13 +152,13 @@ export function CustomMetricIndicatorTypeForm() {
         </EuiFlexItem>
 
         <IndexFieldSelector
-          indexFields={partitionByFields}
+          indexFields={groupByFields}
           name="groupBy"
           defaultValue={ALL_VALUE}
           label={
             <span>
               {i18n.translate('xpack.observability.slo.sloEdit.groupBy.label', {
-                defaultMessage: 'Partition by',
+                defaultMessage: 'Group by',
               })}{' '}
               <EuiIconTip
                 content={i18n.translate('xpack.observability.slo.sloEdit.groupBy.tooltip', {
@@ -169,7 +169,7 @@ export function CustomMetricIndicatorTypeForm() {
             </span>
           }
           placeholder={i18n.translate('xpack.observability.slo.sloEdit.groupBy.placeholder', {
-            defaultMessage: 'Select an optional field to partition by',
+            defaultMessage: 'Select an optional field to group by',
           })}
           isLoading={!!index && isIndexFieldsLoading}
           isDisabled={!index}

diff --git a/...bservability/public/pages/slo_edit/components/histogram/histogram_indicator_type_form.tsx b/...bservability/public/pages/slo_edit/components/histogram/histogram_indicator_type_form.tsx
@@ -34,7 +34,7 @@ export function HistogramIndicatorTypeForm() {
     useFetchIndexPatternFields(index);
   const histogramFields = indexFields.filter((field) => field.type === 'histogram');
   const timestampFields = indexFields.filter((field) => field.type === 'date');
-  const partitionByFields = indexFields.filter((field) => field.aggregatable);
+  const groupByFields = indexFields.filter((field) => field.aggregatable);
 
   return (
     <>
@@ -139,13 +139,13 @@ export function HistogramIndicatorTypeForm() {
         </EuiFlexItem>
 
         <IndexFieldSelector
-          indexFields={partitionByFields}
+          indexFields={groupByFields}
           name="groupBy"
           defaultValue={ALL_VALUE}
           label={
             <span>
               {i18n.translate('xpack.observability.slo.sloEdit.groupBy.label', {
-                defaultMessage: 'Partition by',
+                defaultMessage: 'Group by',
               })}{' '}
               <EuiIconTip
                 content={i18n.translate('xpack.observability.slo.sloEdit.groupBy.tooltip', {
@@ -156,7 +156,7 @@ export function HistogramIndicatorTypeForm() {
             </span>
           }
           placeholder={i18n.translate('xpack.observability.slo.sloEdit.groupBy.placeholder', {
-            defaultMessage: 'Select an optional field to partition by',
+            defaultMessage: 'Select an optional field to group by',
           })}
           isLoading={!!index && isIndexFieldsLoading}
           isDisabled={!index}

diff --git a/...vability/public/pages/slo_edit/components/timeslice_metric/timeslice_metric_indicator.tsx b/...vability/public/pages/slo_edit/components/timeslice_metric/timeslice_metric_indicator.tsx
@@ -37,7 +37,7 @@ export function TimesliceMetricIndicatorTypeForm() {
   const { isLoading: isIndexFieldsLoading, data: indexFields = [] } =
     useFetchIndexPatternFields(index);
   const timestampFields = indexFields.filter((field) => field.type === 'date');
-  const partitionByFields = indexFields.filter((field) => field.aggregatable);
+  const groupByFields = indexFields.filter((field) => field.aggregatable);
   const { uiSettings } = useKibana().services;
   const threshold = watch('indicator.params.metric.threshold');
   const comparator = watch('indicator.params.metric.comparator');
@@ -129,13 +129,13 @@ export function TimesliceMetricIndicatorTypeForm() {
         </EuiFlexItem>
 
         <IndexFieldSelector
-          indexFields={partitionByFields}
+          indexFields={groupByFields}
           name="groupBy"
           defaultValue={ALL_VALUE}
           label={
             <span>
               {i18n.translate('xpack.observability.slo.sloEdit.groupBy.label', {
-                defaultMessage: 'Partition by',
+                defaultMessage: 'Group by',
               })}{' '}
               <EuiIconTip
                 content={i18n.translate('xpack.observability.slo.sloEdit.groupBy.tooltip', {
@@ -146,7 +146,7 @@ export function TimesliceMetricIndicatorTypeForm() {
             </span>
           }
           placeholder={i18n.translate('xpack.observability.slo.sloEdit.groupBy.placeholder', {
-            defaultMessage: 'Select an optional field to partition by',
+            defaultMessage: 'Select an optional field to group by',
           })}
           isLoading={!!index && isIndexFieldsLoading}
           isDisabled={!index}

diff --git a/...plugins/observability/public/pages/slos/components/compact_view/slo_list_compact_view.tsx b/...plugins/observability/public/pages/slos/components/compact_view/slo_list_compact_view.tsx
@@ -272,10 +272,10 @@ export function SloListCompactView({ sloList, loading, error }: Props) {
         slo.groupBy !== ALL_VALUE ? (
           <EuiToolTip
             position="top"
-            content={i18n.translate('xpack.observability.slo.partitionByBadge', {
-              defaultMessage: 'Partition by {partitionKey}',
+            content={i18n.translate('xpack.observability.slo.groupByBadge', {
+              defaultMessage: 'Group by {groupKey}',
               values: {
-                partitionKey: slo.groupBy,
+                groupKey: slo.groupBy,
               },
             })}
             display="block"

diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json
@@ -28803,7 +28803,6 @@
     "xpack.observability.slo.clone.successNotification": "{name} créé avec succès",
     "xpack.observability.slo.create.errorNotification": "Un problème est survenu lors de la création de {name}",
     "xpack.observability.slo.create.successNotification": "{name} créé avec succès",
-    "xpack.observability.slo.deleteConfirmationModal.partitionByDisclaimerText": "Ce SLO a été généré avec une clé de partition sur \"{partitionKey}\". La suppression de cette définition de SLO entraînera la suppression de toutes les instances.",
     "xpack.observability.slo.deleteConfirmationModal.title": "Supprimer {name} ?",
     "xpack.observability.slo.duration.day": "{duration, plural, one {1 jour} many {# jours} other {# jours}}",
     "xpack.observability.slo.duration.hour": "{duration, plural, one {1 heure} many {# heures} other {# heures}}",
@@ -28812,7 +28811,6 @@
     "xpack.observability.slo.duration.week": "{duration, plural, one {1 semaine} many {# semaines} other {# prochaines semaines}}",
     "xpack.observability.slo.indicatorTypeBadge.exploreInApm": "Afficher les détails de {service}",
     "xpack.observability.slo.list.sortByType": "Trier par {type}",
-    "xpack.observability.slo.partitionByBadge": "Partition par {partitionKey}",
     "xpack.observability.slo.rules.burnRate.errors.invalidThresholdValue": "Le seuil du taux d'avancement doit être compris entre 1 et {maxBurnRate}.",
     "xpack.observability.slo.rules.groupByMessage": "Le SLO que vous avez sélectionné a été créé avec une partition sur \"{groupByField}\". Cette règle surveille et génère une alerte pour chaque instance trouvée dans le champ de partition.",
     "xpack.observability.slo.rules.longWindowDuration.tooltip": "Période historique sur laquelle le taux d'avancement est calculé. Une période historique plus courte de {shortWindowDuration} minutes (1/12 de la période historique) sera utilisée pour une récupération plus rapide",

diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
@@ -28803,7 +28803,6 @@
     "xpack.observability.slo.clone.successNotification": "{name}の作成が正常に完了しました",
     "xpack.observability.slo.create.errorNotification": "{name}の作成中に問題が発生しました",
     "xpack.observability.slo.create.successNotification": "{name}の作成が正常に完了しました",
-    "xpack.observability.slo.deleteConfirmationModal.partitionByDisclaimerText": "このSLOは\"{partitionKey}\"のパーティションキーで生成されました。このSLO定義を削除すると、すべてのインスタンスが削除されます。",
     "xpack.observability.slo.deleteConfirmationModal.title": "{name}を削除しますか？",
     "xpack.observability.slo.duration.day": "{duration, plural, other {#日}}",
     "xpack.observability.slo.duration.hour": "{duration, plural, other {#時間}}",
@@ -28812,7 +28811,6 @@
     "xpack.observability.slo.duration.week": "{duration, plural, other {#週}}",
     "xpack.observability.slo.indicatorTypeBadge.exploreInApm": "{service}詳細を表示",
     "xpack.observability.slo.list.sortByType": "{type}で並べ替え",
-    "xpack.observability.slo.partitionByBadge": "{partitionKey}でパーティション",
     "xpack.observability.slo.rules.burnRate.errors.invalidThresholdValue": "バーンレートしきい値は1以上{maxBurnRate}以下でなければなりません。",
     "xpack.observability.slo.rules.groupByMessage": "選択したSLOは\"{groupByField}\"にパーティションが作成されました。このルールは、パーティションフィールドで見つかったすべてのインスタンスを監視し、アラートを生成します。",
     "xpack.observability.slo.rules.longWindowDuration.tooltip": "バーンレートが計算されるルックバック期間。ルックバック期間を{shortWindowDuration}分（ルックバック期間の1/12）と短くすることで、より高速な復帰が可能になります",

diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -28800,7 +28800,6 @@
     "xpack.observability.slo.clone.successNotification": "已成功创建 {name}",
     "xpack.observability.slo.create.errorNotification": "创建 {name} 时出现问题",
     "xpack.observability.slo.create.successNotification": "已成功创建 {name}",
-    "xpack.observability.slo.deleteConfirmationModal.partitionByDisclaimerText": "已使用分区密钥“{partitionKey}”生成此 SLO。删除此 SLO 定义将导致删除所有实例。",
     "xpack.observability.slo.deleteConfirmationModal.title": "删除 {name}？",
     "xpack.observability.slo.duration.day": "{duration, plural, other {# 天}}",
     "xpack.observability.slo.duration.hour": "{duration, plural, other {# 小时}}",
@@ -28809,7 +28808,6 @@
     "xpack.observability.slo.duration.week": "{duration, plural, other {# 周}}",
     "xpack.observability.slo.indicatorTypeBadge.exploreInApm": "查看 {service} 详情",
     "xpack.observability.slo.list.sortByType": "按 {type} 排序",
-    "xpack.observability.slo.partitionByBadge": "按 {partitionKey} 分区",
     "xpack.observability.slo.rules.burnRate.errors.invalidThresholdValue": "消耗速度阈值必须介于 1 和 {maxBurnRate} 之间。",
     "xpack.observability.slo.rules.groupByMessage": "已使用分区在“{groupByField}”上创建您选定的 SLO。此规则将监测在分区字段中发现的每个实例并为其生成告警。",
     "xpack.observability.slo.rules.longWindowDuration.tooltip": "在其间计算消耗速度的回顾期。将使用 {shortWindowDuration} 分钟的较短回顾期（1/12 的回顾期）以便更快恢复",