Skip to content

Commit

Permalink
[FTR] update svl search config and custom role test (#196126)
Browse files Browse the repository at this point in the history
## Summary

This PR removes `xpack.cloud.serverless.project_type` from FTR config,
the value breaks mockIdpPlugin that expects it to be defined as
`search`. We will address project type unification separately.

Closes #195976
  • Loading branch information
dmlemeshko authored Oct 14, 2024
1 parent 7f032b1 commit 41850b6
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 10 deletions.
3 changes: 2 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -1487,6 +1487,7 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib
/x-pack/plugins/enterprise_search/public/applications/shared/doc_links @elastic/platform-docs
/x-pack/test_serverless/api_integration/test_suites/search/serverless_search @elastic/search-kibana
/x-pack/test_serverless/functional/test_suites/search/ @elastic/search-kibana
/x-pack/test_serverless/functional/test_suites/search/config.ts @elastic/search-kibana @elastic/appex-qa
x-pack/test/api_integration/apis/management/index_management/inference_endpoints.ts @elastic/search-kibana
/x-pack/test_serverless/api_integration/test_suites/search @elastic/search-kibana
/x-pack/test_serverless/functional/page_objects/svl_api_keys.ts @elastic/search-kibana
Expand All @@ -1512,7 +1513,7 @@ x-pack/test/api_integration/apis/management/index_management/inference_endpoints
#CC# /x-pack/plugins/cross_cluster_replication/ @elastic/kibana-management

# Security Solution
/x-pack/test_serverless/functional/test_suites/security/config.ts @elastic/security-solution
/x-pack/test_serverless/functional/test_suites/security/config.ts @elastic/security-solution @elastic/appex-qa
/x-pack/test_serverless/functional/test_suites/security/config.feature_flags.ts @elastic/security-solution
/x-pack/test_serverless/api_integration/test_suites/observability/config.feature_flags.ts @elastic/security-solution
/x-pack/test_serverless/functional/test_suites/common/spaces/multiple_spaces_enabled.ts @elastic/security-solution
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export default createTestConfig({
`--xpack.cloud.id=ES3_FTR_TESTS:ZmFrZS1kb21haW4uY2xkLmVsc3RjLmNvJGZha2Vwcm9qZWN0aWQuZXMkZmFrZXByb2plY3RpZC5rYg==`,
`--xpack.cloud.serverless.project_id=fakeprojectid`,
`--xpack.cloud.serverless.project_name=ES3_FTR_TESTS`,
`--xpack.cloud.serverless.project_type=elasticsearch`,
`--xpack.cloud.base_url=https://fake-cloud.elastic.co`,
`--xpack.cloud.profile_url=/user/settings/`,
`--xpack.cloud.billing_url=/billing/overview/`,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
let roleAuthc: RoleCredentials;

// Failing: See https://github.com/elastic/kibana/issues/195976
describe.skip('With custom role', function () {
describe('With custom role', function () {
// skipping on MKI while we are working on a solution
this.tags(['skipMKI']);
before(async () => {
Expand Down Expand Up @@ -59,12 +58,14 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
it('should have limited navigation menu', async () => {
await pageObjects.svlCommonPage.assertUserAvatarExists();
// discover navigation link is present
await testSubjects.existOrFail('~nav-item-search_project_nav.kibana.discover');
// dashboard and index_management navigation links are hidden
await testSubjects.missingOrFail('~nav-item-search_project_nav.kibana.dashboard');
await testSubjects.missingOrFail(
'nav-item-search_project_nav.content.management:index_management'
);
await testSubjects.existOrFail('~nav-item-id-discover');
// index management, dev tools, dashboards and maps navigation links are hidden
await testSubjects.missingOrFail('~nav-item-id-management:index_management');
await testSubjects.missingOrFail('~nav-item-id-dev_tools');
// Playground should be also hidden, probably a bug
// await testSubjects.missingOrFail('~nav-item-id-searchPlayground');
await testSubjects.missingOrFail('~nav-item-id-dashboards');
await testSubjects.missingOrFail('~nav-item-id-maps');
});

it('should access Discover app', async () => {
Expand Down

0 comments on commit 41850b6

Please sign in to comment.