Skip to content

Commit

Permalink
[8.x] [Search][Connectors] Elastic managed as default and some typos (#…
Browse files Browse the repository at this point in the history
…197571) (#198466)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search][Connectors] Elastic managed as default and some typos
(#197571)](#197571)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"José Luis
González","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T08:11:39Z","message":"[Search][Connectors]
Elastic managed as default and some typos (#197571)\n\n##
Summary\r\n\r\nFixing **Elastic managed** as a default option when
creating a new\r\nconnector. And fixing _Self managed_ typo to become
_Self-managed_\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"7dea07f90dd41d0c69586393afbd0f2496479212","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0"],"title":"[Search][Connectors]
Elastic managed as default and some
typos","number":197571,"url":"https://github.com/elastic/kibana/pull/197571","mergeCommit":{"message":"[Search][Connectors]
Elastic managed as default and some typos (#197571)\n\n##
Summary\r\n\r\nFixing **Elastic managed** as a default option when
creating a new\r\nconnector. And fixing _Self managed_ typo to become
_Self-managed_\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"7dea07f90dd41d0c69586393afbd0f2496479212"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197571","number":197571,"mergeCommit":{"message":"[Search][Connectors]
Elastic managed as default and some typos (#197571)\n\n##
Summary\r\n\r\nFixing **Elastic managed** as a default option when
creating a new\r\nconnector. And fixing _Self managed_ typo to become
_Self-managed_\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"7dea07f90dd41d0c69586393afbd0f2496479212"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: José Luis González <[email protected]>
  • Loading branch information
kibanamachine and JoseLuisGJ authored Oct 31, 2024
1 parent fe3a0ff commit 40c5cdd
Showing 1 changed file with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,8 @@ export const CreateConnector: React.FC = () => {

useEffect(() => {
// TODO: separate this to ability and preference
if (!selectedConnector?.isNative || !selfManagePreference) {
if (selectedConnector && !selectedConnector.isNative && selfManagePreference === 'native') {
setSelfManagePreference('selfManaged');
} else {
setSelfManagePreference('native');
}
}, [selectedConnector]);

Expand Down Expand Up @@ -276,11 +274,11 @@ export const CreateConnector: React.FC = () => {
</EuiFormRow>
<EuiSpacer size="s" />
<EuiBadge color="hollow">
{selfManagePreference
{selfManagePreference === 'selfManaged'
? i18n.translate(
'xpack.enterpriseSearch.createConnector.badgeType.selfManaged',
{
defaultMessage: 'Self managed',
defaultMessage: 'Self-managed',
}
)
: i18n.translate(
Expand Down

0 comments on commit 40c5cdd

Please sign in to comment.