Skip to content

Commit

Permalink
[8.12] [ES|QL] Small improvements on the warnings/errors (#172782) (#…
Browse files Browse the repository at this point in the history
…172843)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[ES|QL] Small improvements on the warnings/errors
(#172782)](#172782)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T15:35:34Z","message":"[ES|QL]
Small improvements on the warnings/errors (#172782)\n\n##
Summary\r\n\r\nThis is a PR which:\r\n\r\n- Corrects the icon shown in
warnings (it was displaying the error icon\r\nwhich is wrong)\r\n<img
width=\"1253\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/17003240/4f388edd-734c-4299-9def-841ac6fccba1\">\r\n\r\n-
Makes the icon also clickable (opens the popover with the list
of\r\nwarnings/errors)\r\n\r\nCo-authored-by: Marco Liberati
<[email protected]>","sha":"71ed936685042fb4073e9d035bdb8bd777e8cabd","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport:prev-minor","Feature:ES|QL","v8.12.0","v8.13.0"],"number":172782,"url":"https://github.com/elastic/kibana/pull/172782","mergeCommit":{"message":"[ES|QL]
Small improvements on the warnings/errors (#172782)\n\n##
Summary\r\n\r\nThis is a PR which:\r\n\r\n- Corrects the icon shown in
warnings (it was displaying the error icon\r\nwhich is wrong)\r\n<img
width=\"1253\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/17003240/4f388edd-734c-4299-9def-841ac6fccba1\">\r\n\r\n-
Makes the icon also clickable (opens the popover with the list
of\r\nwarnings/errors)\r\n\r\nCo-authored-by: Marco Liberati
<[email protected]>","sha":"71ed936685042fb4073e9d035bdb8bd777e8cabd"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172782","number":172782,"mergeCommit":{"message":"[ES|QL]
Small improvements on the warnings/errors (#172782)\n\n##
Summary\r\n\r\nThis is a PR which:\r\n\r\n- Corrects the icon shown in
warnings (it was displaying the error icon\r\nwhich is wrong)\r\n<img
width=\"1253\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/17003240/4f388edd-734c-4299-9def-841ac6fccba1\">\r\n\r\n-
Makes the icon also clickable (opens the popover with the list
of\r\nwarnings/errors)\r\n\r\nCo-authored-by: Marco Liberati
<[email protected]>","sha":"71ed936685042fb4073e9d035bdb8bd777e8cabd"}}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <[email protected]>
  • Loading branch information
kibanamachine and stratoula authored Dec 7, 2023
1 parent f917515 commit 3b9c879
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion packages/kbn-text-based-editor/src/editor_footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,14 @@ export function ErrorsWarningsPopover({
<EuiFlexItem grow={false}>
<EuiFlexGroup gutterSize="xs" responsive={false} alignItems="center">
<EuiFlexItem grow={false}>
<EuiIcon type="error" color={strings.color} size="s" />
<EuiIcon
type={type}
color={strings.color}
size="s"
onClick={() => {
setIsPopoverOpen(!isPopoverOpen);
}}
/>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiPopover
Expand Down

0 comments on commit 3b9c879

Please sign in to comment.