Skip to content

Commit

Permalink
fix: incorrect import causes storybook build to fail (#171033)
Browse files Browse the repository at this point in the history
## Summary
[This
change](https://github.com/darnautov/kibana/blob/b6f20b2219b5ccf22316ee36e0c079b9e3d1327c/x-pack/plugins/ml/public/application/components/collapsible_panel/panel_header_items.tsx#L9)
in this PR: #167998 is causing an
error in building storybooks:
https://buildkite.com/elastic/kibana-on-merge/builds/38046#018bb9d2-7820-43ad-9144-e40d33d28c3b

In brief, the import looks like this:
```typescript
import { css } from '@emotion/react/dist/emotion-react.cjs';
```
but it should be like this:
```typescript
import { css } from '@emotion/react';
```

It looks it's a bad import, we should set up a pre-merge check for these
accidental auto-imports.

cc: @darnautov please review
  • Loading branch information
delanni authored Nov 10, 2023
1 parent 41cacd1 commit 33757f6
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

import { EuiFlexGroup, EuiFlexItem } from '@elastic/eui';
import { css } from '@emotion/react/dist/emotion-react.cjs';
import { css } from '@emotion/react';
import React, { type FC } from 'react';
import { useCurrentThemeVars } from '../../contexts/kibana';

Expand Down

0 comments on commit 33757f6

Please sign in to comment.