Fix IS_NOT_BETWEEN comparator for the custom threshold, Infra, Metric…

… rules
elastic · Nov 24, 2023 · 307fe3f · 307fe3f
1 parent b2ca784
commit 307fe3f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/...ugins/infra/server/lib/alerting/inventory_metric_threshold/lib/create_condition_script.ts b/...ugins/infra/server/lib/alerting/inventory_metric_threshold/lib/create_condition_script.ts
@@ -25,7 +25,8 @@ export const createConditionScript = (
   }
   if (comparator === Comparator.OUTSIDE_RANGE && threshold.length === 2) {
     return {
-      source: `params.value < params.threshold0 && params.value > params.threshold1 ? 1 : 0`,
+      // OUTSIDE_RANGE/NOT BETWEEN is the opposite of BETWEEN. Use the BETWEEN condition and switch the 1 and 0
+      source: `params.value > params.threshold0 && params.value < params.threshold1 ? 0 : 1`,
       params: {
         threshold0: threshold[0],
         threshold1: threshold[1],

diff --git a/x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/create_condition_script.ts b/x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/create_condition_script.ts
@@ -18,7 +18,8 @@ export const createConditionScript = (threshold: number[], comparator: Comparato
   }
   if (comparator === Comparator.OUTSIDE_RANGE && threshold.length === 2) {
     return {
-      source: `params.value < params.threshold0 && params.value > params.threshold1 ? 1 : 0`,
+      // OUTSIDE_RANGE/NOT BETWEEN is the opposite of BETWEEN. Use the BETWEEN condition and switch the 1 and 0
+      source: `params.value > params.threshold0 && params.value < params.threshold1 ? 0 : 1`,
       params: {
         threshold0: threshold[0],
         threshold1: threshold[1],

diff --git a/...ck/plugins/observability/server/lib/rules/custom_threshold/lib/create_condition_script.ts b/...ck/plugins/observability/server/lib/rules/custom_threshold/lib/create_condition_script.ts
@@ -19,7 +19,8 @@ export const createConditionScript = (threshold: number[], comparator: Comparato
   }
   if (comparator === Comparator.OUTSIDE_RANGE && threshold.length === 2) {
     return {
-      source: `params.value < params.threshold0 && params.value > params.threshold1 ? 1 : 0`,
+      // OUTSIDE_RANGE/NOT BETWEEN is the opposite of BETWEEN. Use the BETWEEN condition and switch the 1 and 0
+      source: `params.value > params.threshold0 && params.value < params.threshold1 ? 0 : 1`,
       params: {
         threshold0: threshold[0],
         threshold1: threshold[1],