Add Zod max value validation to max_signals

elastic · May 6, 2024 · 209318e · 209318e
1 parent 1303295
commit 209318e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/.../security_solution/common/api/detection_engine/model/rule_schema/common_attributes.gen.ts b/.../security_solution/common/api/detection_engine/model/rule_schema/common_attributes.gen.ts
@@ -200,7 +200,7 @@ export type AlertsIndexNamespace = z.infer<typeof AlertsIndexNamespace>;
 export const AlertsIndexNamespace = z.string();
 
 export type MaxSignals = z.infer<typeof MaxSignals>;
-export const MaxSignals = z.number().int().min(1);
+export const MaxSignals = z.number().int().min(1).max(1000);
 
 export type ThreatSubtechnique = z.infer<typeof ThreatSubtechnique>;
 export const ThreatSubtechnique = z.object({

diff --git a/...curity_solution/common/api/detection_engine/model/rule_schema/rule_request_schema.test.ts b/...curity_solution/common/api/detection_engine/model/rule_schema/rule_request_schema.test.ts
@@ -483,6 +483,19 @@ describe('rules schema', () => {
     );
   });
 
+  test('max_signals cannot be greater than 1000', () => {
+    const payload: RuleCreateProps = {
+      ...getCreateRulesSchemaMock(),
+      max_signals: 1001,
+    };
+
+    const result = RuleCreateProps.safeParse(payload);
+    expectParseError(result);
+    expect(stringifyZodError(result.error)).toEqual(
+      'max_signals: Number must be less than or equal to 1000'
+    );
+  });
+
   test('max_signals can be 1', () => {
     const payload: RuleCreateProps = {
       ...getCreateRulesSchemaMock(),