Skip to content

Commit

Permalink
[Enterprise Search] fix: use full path for search apps nav url (#169014)
Browse files Browse the repository at this point in the history
## Summary

Updated the left nav `to` path for search applications to match the full
path so the isActive check can pass instead of used the base path to
redirect.


![image](https://github.com/elastic/kibana/assets/1972968/9b8ac4fa-8896-43d5-825c-39f5b38d48ee)
  • Loading branch information
TattdCodeMonkey authored Oct 16, 2023
1 parent 48bb5ae commit 1d2cd58
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe('useEnterpriseSearchContentNav', () => {
id: 'applications',
items: [
{
href: '/app/enterprise_search/applications',
href: '/app/enterprise_search/applications/search_applications',
id: 'searchApplications',
name: 'Search Applications',
},
Expand Down Expand Up @@ -226,7 +226,7 @@ describe('useEnterpriseSearchApplicationNav', () => {
id: 'applications',
items: [
{
href: '/app/enterprise_search/applications',
href: '/app/enterprise_search/applications/search_applications',
id: 'searchApplications',
name: 'Search Applications',
},
Expand Down Expand Up @@ -413,7 +413,7 @@ describe('useEnterpriseSearchAnalyticsNav', () => {
id: 'applications',
items: [
{
href: '/app/enterprise_search/applications',
href: '/app/enterprise_search/applications/search_applications',
id: 'searchApplications',
name: 'Search Applications',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const useEnterpriseSearchNav = () => {
}),
...generateNavLink({
shouldNotCreateHref: true,
to: APPLICATIONS_PLUGIN.URL,
to: APPLICATIONS_PLUGIN.URL + SEARCH_APPLICATIONS_PATH,
}),
},
{
Expand Down

0 comments on commit 1d2cd58

Please sign in to comment.