Skip to content

Commit

Permalink
[unified_doc_viewer / unified_search] clean up SASS compilation warni…
Browse files Browse the repository at this point in the history
…ngs (#198876)

## Summary

This PR cleans up two noisy warnings seen when building Kibana:
```
[2024-11-04 21:26:37]    │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
[2024-11-04 21:26:37]    │ warn worker stderr
[2024-11-04 21:26:37]    │ warn worker stderr Recommendation: math.div($euiSizeXS, 2) or calc($euiSizeXS / 2)
[2024-11-04 21:26:37]    │ warn worker stderr
[2024-11-04 21:26:37]    │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div
[2024-11-04 21:26:37]    │ warn worker stderr
[2024-11-04 21:26:37]    │ warn worker stderr    ╷
[2024-11-04 21:26:37]    │ warn worker stderr 94 │     padding: $euiSizeXS / 2 0 0 $euiSizeXS;
[2024-11-04 21:26:37]    │ warn worker stderr    │              ^^^^^^^^^^^^^^
[2024-11-04 21:26:37]    │ warn worker stderr    ╵
[2024-11-04 21:26:37]    │ warn worker stderr     file:///home/tim/kibana/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss 94:14  root stylesheet
[2024-11-04 21:26:37]    │ warn worker stderr
[2024-11-04 21:35:27]    │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
[2024-11-04 21:35:27]    │ warn worker stderr
[2024-11-04 21:35:27]    │ warn worker stderr Recommendation: math.div($euiSizeM, 2) or calc($euiSizeM / 2)
[2024-11-04 21:35:27]    │ warn worker stderr
[2024-11-04 21:35:27]    │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div
[2024-11-04 21:35:27]    │ warn worker stderr
[2024-11-04 21:35:27]    │ warn worker stderr    ╷
[2024-11-04 21:35:27]    │ warn worker stderr 11 │   padding-block: $euiSizeM / 2;
[2024-11-04 21:35:27]    │ warn worker stderr    │                  ^^^^^^^^^^^^^
[2024-11-04 21:35:27]    │ warn worker stderr    ╵
[2024-11-04 21:35:27]    │ warn worker stderr     file:///home/tim/kibana/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss 11:18  root stylesheet
```

(cherry picked from commit 7a3a2b3)
  • Loading branch information
tsullivan committed Nov 5, 2024
1 parent 7c8fe2f commit 18a9098
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
}

& [data-gridcell-column-id='pin_field'] .euiDataGridRowCell__content {
padding: $euiSizeXS / 2 0 0 $euiSizeXS;
padding: calc($euiSizeXS / 2) 0 0 $euiSizeXS;
}

.kbnDocViewer__fieldsGrid__pinAction {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
.globalFilterItem {
line-height: $euiSize;
color: $euiTextColor;
padding-block: $euiSizeM / 2;
padding-block: calc($euiSizeM / 2);
white-space: normal; /* 1 */

&:not(.globalFilterItem-isDisabled) {
Expand Down

0 comments on commit 18a9098

Please sign in to comment.