[deprecations] Remove/update core-api deprecations targeted for remov…

…al by 8.8 (#147723) Co-authored-by: Kibana Machine <[email protected]>
elastic · Jan 22, 2023 · 188009f · 188009f
1 parent 2352b14
commit 188009f
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 17 deletions.
diff --git a/packages/core/application/core-application-browser/src/app_leave.ts b/packages/core/application/core-application-browser/src/app_leave.ts
@@ -17,9 +17,9 @@ import type { EuiButtonColor } from '@elastic/eui';
  *
  * See {@link AppMountParameters} for detailed usage examples.
  *
+ * @remarks prefer {@link ScopedHistory.block} instead
+ *
  * @public
- * @deprecated {@link AppMountParameters.onAppLeave} has been deprecated in favor of {@link ScopedHistory.block}
- * @removeBy 8.8.0
  */
 export type AppLeaveHandler = (
   factory: AppLeaveActionFactory,

diff --git a/packages/core/application/core-application-browser/src/app_mount.ts b/packages/core/application/core-application-browser/src/app_mount.ts
@@ -142,6 +142,7 @@ export interface AppMountParameters<HistoryLocationState = unknown> {
    * This will be called either when the user goes to another application, or when
    * trying to close the tab or manually changing the url.
    *
+   *
    * @example
    *
    * ```ts
@@ -165,8 +166,10 @@ export interface AppMountParameters<HistoryLocationState = unknown> {
    * }
    * ```
    *
-   * @deprecated {@link ScopedHistory.block} should be used instead.
-   * @removeBy 8.8.0
+   * @remarks prefer {@link ScopedHistory.block} instead
+   * Resources with names containing percent sign with other special characters or
+   * containing `%25` sequence can experience navigation issues. Refs https://github.com/elastic/kibana/issues/82440 and https://github.com/elastic/kibana/issues/132600
+
    */
   onAppLeave: (handler: AppLeaveHandler) => void;
 

diff --git a/packages/core/metrics/core-metrics-server/src/metrics.ts b/packages/core/metrics/core-metrics-server/src/metrics.ts
@@ -191,8 +191,7 @@ export interface OpsMetrics {
   elasticsearch_client: ElasticsearchClientsMetrics;
   /**
    * Process related metrics.
-   * @deprecated use the processes field instead.
-   * @removeBy 8.8.0
+   * @remarks processes field preferred
    */
   process: OpsProcessMetrics;
   /** Process related metrics. Reports an array of objects for each kibana pid.*/

diff --git a/...d-objects/core-saved-objects-migration-server-internal/src/core/document_migrator.test.ts b/...d-objects/core-saved-objects-migration-server-internal/src/core/document_migrator.test.ts
@@ -738,7 +738,7 @@ describe('DocumentMigrator', () => {
           migrations: {
             '1.2.3': (doc, { log }) => {
               log.info(logTestMsg);
-              log.warning(logTestMsg);
+              log.warn(logTestMsg);
               return doc;
             },
           },

diff --git a/...e/saved-objects/core-saved-objects-migration-server-internal/src/core/migration_logger.ts b/...e/saved-objects/core-saved-objects-migration-server-internal/src/core/migration_logger.ts
@@ -25,7 +25,6 @@ export class MigrationLogger implements SavedObjectsMigrationLogger {
 
   public info = (msg: string) => this.logger.info(msg);
   public debug = (msg: string) => this.logger.debug(msg);
-  public warning = (msg: string) => this.logger.warn(msg);
   public warn = (msg: string) => this.logger.warn(msg);
   public error = (msg: string, meta: LogMeta) => this.logger.error(msg, meta);
 }
diff --git a/packages/core/saved-objects/core-saved-objects-migration-server-mocks/src/migration.mocks.ts b/packages/core/saved-objects/core-saved-objects-migration-server-mocks/src/migration.mocks.ts
@@ -16,7 +16,6 @@ export const createSavedObjectsMigrationLoggerMock =
     const mock = {
       debug: jest.fn(),
       info: jest.fn(),
-      warning: jest.fn(),
       warn: jest.fn(),
       error: jest.fn(),
     };

diff --git a/packages/core/saved-objects/core-saved-objects-server/src/migration.ts b/packages/core/saved-objects/core-saved-objects-server/src/migration.ts
@@ -51,11 +51,6 @@ export type SavedObjectMigrationFn<InputAttributes = unknown, MigratedAttributes
 export interface SavedObjectsMigrationLogger {
   debug: (msg: string) => void;
   info: (msg: string) => void;
-  /**
-   * @deprecated Use `warn` instead.
-   * @removeBy 8.8.0
-   */
-  warning: (msg: string) => void;
   warn: (msg: string) => void;
   error: <Meta extends LogMeta = LogMeta>(msg: string, meta: Meta) => void;
 }

diff --git a/...ugins/dashboard/server/dashboard_saved_object/migrations/migrate_to_730/migrations_730.ts b/...ugins/dashboard/server/dashboard_saved_object/migrations/migrate_to_730/migrations_730.ts
@@ -53,7 +53,7 @@ export const migrations730 = (doc: DashboardDoc700To720, { log }: SavedObjectMig
       moveFiltersToQuery(searchSource)
     );
   } catch (e) {
-    log.warning(
+    log.warn(
       `Exception @ migrations730 while trying to migrate dashboard query filters!\n` +
         `${e.stack}\n` +
         `dashboard: ${inspect(doc, false, null)}`
@@ -80,7 +80,7 @@ export const migrations730 = (doc: DashboardDoc700To720, { log }: SavedObjectMig
 
     delete doc.attributes.uiStateJSON;
   } catch (e) {
-    log.warning(
+    log.warn(
       `Exception @ migrations730 while trying to migrate dashboard panels!\n` +
         `Error: ${e.stack}\n` +
         `dashboard: ${inspect(doc, false, null)}`

diff --git a/x-pack/plugins/maps/server/saved_objects/saved_object_migrations.ts b/x-pack/plugins/maps/server/saved_objects/saved_object_migrations.ts
@@ -28,7 +28,7 @@ function logMigrationWarning(
   errorMsg: string,
   doc: SavedObjectUnsanitizedDoc<MapSavedObjectAttributes>
 ) {
-  context.log.warning(
+  context.log.warn(
     `map migration failed (${context.migrationVersion}). ${errorMsg}. attributes: ${JSON.stringify(
       doc
     )}`