fix flaky tests (#202289)

## Summary Changes in #201443 with some tweaks Closes #201210 Closes #200786 Closes #191804 Closes #199204
elastic · Dec 2, 2024 · 16f2d7a · 16f2d7a
1 parent 99463c7
commit 16f2d7a
Show file tree

Hide file tree

Showing 7 changed files with 111 additions and 127 deletions.
diff --git a/...eet/public/applications/fleet/sections/settings/components/multi_row_input/index.test.tsx b/...eet/public/applications/fleet/sections/settings/components/multi_row_input/index.test.tsx
@@ -6,7 +6,7 @@
  */
 
 import React from 'react';
-import { fireEvent, act } from '@testing-library/react';
+import { fireEvent, waitFor } from '@testing-library/react';
 
 import { createFleetTestRendererMock } from '../../../../../../mock';
 
@@ -44,13 +44,9 @@ test('it should allow to add a new host', async () => {
 test('it should allow to remove an host', async () => {
   const { utils, mockOnChange } = renderInput(['http://host1.com', 'http://host2.com']);
 
-  await act(async () => {
-    const deleteRowEl = await utils.container.querySelector('[aria-label="Delete row"]');
-    if (!deleteRowEl) {
-      throw new Error('Delete row button not found');
-    }
-    fireEvent.click(deleteRowEl);
-  });
+  const deleteRowEl = await utils.container.querySelector('[aria-label="Delete row"]');
+  expect(deleteRowEl).not.toBeNull();
+  fireEvent.click(deleteRowEl!);
 
   expect(mockOnChange).toHaveBeenCalledWith(['http://host2.com']);
 });
@@ -95,7 +91,7 @@ test('Should display errors in order', async () => {
       { message: 'Error 3', index: 2 },
     ]
   );
-  await act(async () => {
+  await waitFor(async () => {
     const errors = await utils.queryAllByText(/Error [1-3]/);
     expect(errors[0]).toHaveTextContent('Error 1');
     expect(errors[1]).toHaveTextContent('Error 2');
@@ -126,18 +122,14 @@ test('Should remove error when item deleted', async () => {
     );
   });
 
-  await act(async () => {
-    const deleteRowButtons = await utils.container.querySelectorAll('[aria-label="Delete row"]');
-    if (deleteRowButtons.length !== 3) {
-      throw new Error('Delete row buttons not found');
-    }
+  const deleteRowButtons = await utils.container.querySelectorAll('[aria-label="Delete row"]');
+  expect(deleteRowButtons.length).toEqual(3);
 
-    fireEvent.click(deleteRowButtons[1]);
-    expect(mockOnChange).toHaveBeenCalled();
+  fireEvent.click(deleteRowButtons[1]);
+  expect(mockOnChange).toHaveBeenCalled();
 
-    const renderedErrors = await utils.queryAllByText(/Error [1-3]/);
-    expect(renderedErrors).toHaveLength(2);
-    expect(renderedErrors[0]).toHaveTextContent('Error 1');
-    expect(renderedErrors[1]).toHaveTextContent('Error 3');
-  });
+  const renderedErrors = await utils.queryAllByText(/Error [1-3]/);
+  expect(renderedErrors).toHaveLength(2);
+  expect(renderedErrors[0]).toHaveTextContent('Error 1');
+  expect(renderedErrors[1]).toHaveTextContent('Error 3');
 });
diff --git a/...plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.test.tsx b/...plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.test.tsx
@@ -7,7 +7,7 @@
 
 import React, { lazy, memo } from 'react';
 import { Route } from '@kbn/shared-ux-router';
-import { act, cleanup } from '@testing-library/react';
+import { act } from '@testing-library/react';
 
 import { INTEGRATIONS_ROUTING_PATHS, pagePathGetters } from '../../../../constants';
 import type {
@@ -65,10 +65,6 @@ describe('When on integration detail', () => {
     act(() => testRenderer.mountHistory.push(detailPageUrlPath));
   });
 
-  afterEach(() => {
-    cleanup();
-  });
-
   describe('and the package is installed', () => {
     beforeEach(async () => {
       await render();

diff --git a/.../plugins/fleet/public/components/agent_enrollment_flyout/agent_enrollment_flyout.test.tsx b/.../plugins/fleet/public/components/agent_enrollment_flyout/agent_enrollment_flyout.test.tsx
@@ -8,7 +8,7 @@
 import './agent_enrollment_flyout.test.mocks';
 
 import React from 'react';
-import { act, cleanup, fireEvent, waitFor } from '@testing-library/react';
+import { fireEvent, waitFor } from '@testing-library/react';
 import type { RenderResult } from '@testing-library/react';
 
 import { createFleetTestRendererMock } from '../../mock';
@@ -23,11 +23,8 @@ import type { FlyOutProps } from './types';
 import { AgentEnrollmentFlyout } from '.';
 
 const render = (props?: Partial<FlyOutProps>) => {
-  cleanup();
   const renderer = createFleetTestRendererMock();
-  const results = renderer.render(<AgentEnrollmentFlyout onClose={jest.fn()} {...props} />);
-
-  return results;
+  return renderer.render(<AgentEnrollmentFlyout onClose={jest.fn()} {...props} />);
 };
 
 const testAgentPolicy: AgentPolicy = {
@@ -46,7 +43,7 @@ const testAgentPolicy: AgentPolicy = {
 describe('<AgentEnrollmentFlyout />', () => {
   let results: RenderResult;
 
-  beforeEach(async () => {
+  beforeEach(() => {
     jest.mocked(useAuthz).mockReturnValue({
       fleet: {
         readAgentPolicies: true,
@@ -88,10 +85,6 @@ describe('<AgentEnrollmentFlyout />', () => {
       agentPolicies: [{ id: 'fleet-server-policy' } as AgentPolicy],
       refreshAgentPolicies: jest.fn(),
     });
-
-    act(() => {
-      results = render();
-    });
   });
 
   afterEach(() => {
@@ -113,6 +106,8 @@ describe('<AgentEnrollmentFlyout />', () => {
 
   describe('managed instructions', () => {
     it('uses the agent policy selection step', () => {
+      results = render();
+
       expect(results.queryByTestId('agentEnrollmentFlyout')).not.toBeNull();
       expect(results.queryByTestId('agent-policy-selection-step')).not.toBeNull();
       expect(results.queryByTestId('agent-enrollment-key-selection-step')).toBeNull();
@@ -154,24 +149,22 @@ describe('<AgentEnrollmentFlyout />', () => {
 
     describe('standalone instructions', () => {
       function goToStandaloneTab() {
-        act(() => {
-          fireEvent.click(results.getByTestId('standaloneTab'));
-        });
+        fireEvent.click(results.getByTestId('standaloneTab'));
       }
 
-      beforeEach(() => {
+      it('uses the agent policy selection step', async () => {
         results = render({
           isIntegrationFlow: true,
         });
-      });
 
-      it('uses the agent policy selection step', async () => {
         goToStandaloneTab();
 
-        expect(results.queryByTestId('agentEnrollmentFlyout')).not.toBeNull();
-        expect(results.queryByTestId('agent-policy-selection-step')).not.toBeNull();
-        expect(results.queryByTestId('agent-enrollment-key-selection-step')).toBeNull();
-        expect(results.queryByTestId('configure-standalone-step')).not.toBeNull();
+        await waitFor(() => {
+          expect(results.queryByTestId('agentEnrollmentFlyout')).not.toBeNull();
+          expect(results.queryByTestId('agent-policy-selection-step')).not.toBeNull();
+          expect(results.queryByTestId('agent-enrollment-key-selection-step')).toBeNull();
+          expect(results.queryByTestId('configure-standalone-step')).not.toBeNull();
+        });
       });
 
       describe('with a specific policy', () => {
@@ -185,13 +178,15 @@ describe('<AgentEnrollmentFlyout />', () => {
           });
         });
 
-        it('does not use either of the agent policy selection or enrollment key steps', () => {
+        it('does not use either of the agent policy selection or enrollment key steps', async () => {
           goToStandaloneTab();
 
-          expect(results.queryByTestId('agentEnrollmentFlyout')).not.toBeNull();
-          expect(results.queryByTestId('agent-policy-selection-step')).toBeNull();
-          expect(results.queryByTestId('agent-enrollment-key-selection-step')).toBeNull();
-          expect(results.queryByTestId('configure-standalone-step')).not.toBeNull();
+          await waitFor(() => {
+            expect(results.queryByTestId('agentEnrollmentFlyout')).not.toBeNull();
+            expect(results.queryByTestId('agent-policy-selection-step')).toBeNull();
+            expect(results.queryByTestId('agent-enrollment-key-selection-step')).toBeNull();
+            expect(results.queryByTestId('configure-standalone-step')).not.toBeNull();
+          });
         });
       });
     });

diff --git a/.../plugins/fleet/public/components/enrollment_instructions/root_privileges_callout.test.tsx b/.../plugins/fleet/public/components/enrollment_instructions/root_privileges_callout.test.tsx
@@ -7,16 +7,14 @@
 
 import React from 'react';
 
-import { cleanup, waitFor } from '@testing-library/react';
+import { waitFor } from '@testing-library/react';
 
 import { createFleetTestRendererMock } from '../../mock';
 
 import { RootPrivilegesCallout } from './root_privileges_callout';
 
-// FLAKY: https://github.com/elastic/kibana/issues/201210
-describe.skip('RootPrivilegesCallout', () => {
+describe('RootPrivilegesCallout', () => {
   function render(rootIntegrations?: Array<{ name: string; title: string }>) {
-    cleanup();
     const renderer = createFleetTestRendererMock();
     const results = renderer.render(<RootPrivilegesCallout rootIntegrations={rootIntegrations} />);
 

diff --git a/x-pack/plugins/fleet/public/components/multiple_agent_policy_summary_line.test.tsx b/x-pack/plugins/fleet/public/components/multiple_agent_policy_summary_line.test.tsx
@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { act, fireEvent } from '@testing-library/react';
+import { fireEvent, waitFor } from '@testing-library/react';
 import React from 'react';
 
 import type { TestRenderer } from '../mock';
@@ -15,8 +15,7 @@ import type { AgentPolicy } from '../types';
 
 import { MultipleAgentPoliciesSummaryLine } from './multiple_agent_policy_summary_line';
 
-// FLAKY: https://github.com/elastic/kibana/issues/200786
-describe.skip('MultipleAgentPolicySummaryLine', () => {
+describe('MultipleAgentPolicySummaryLine', () => {
   let testRenderer: TestRenderer;
 
   const render = (agentPolicies: AgentPolicy[]) =>
@@ -32,7 +31,7 @@ describe.skip('MultipleAgentPolicySummaryLine', () => {
     testRenderer = createFleetTestRendererMock();
   });
 
-  test('it should only render the policy name when there is only one policy', async () => {
+  test('it should only render the policy name when there is only one policy', () => {
     const results = render([{ name: 'Test policy', revision: 2 }] as AgentPolicy[]);
     expect(results.container.textContent).toBe('Test policyrev. 2');
     expect(results.queryByTestId('agentPolicyNameLink')).toBeInTheDocument();
@@ -49,19 +48,18 @@ describe.skip('MultipleAgentPolicySummaryLine', () => {
     expect(results.queryByTestId('agentPoliciesNumberBadge')).toBeInTheDocument();
     expect(results.container.textContent).toBe('Test policy 1+2');
 
-    await act(async () => {
-      fireEvent.click(results.getByTestId('agentPoliciesNumberBadge'));
-    });
-    expect(results.queryByTestId('agentPoliciesPopover')).toBeInTheDocument();
-    expect(results.queryByTestId('agentPoliciesPopoverButton')).toBeInTheDocument();
-    expect(results.queryByTestId('policy-0001')).toBeInTheDocument();
-    expect(results.queryByTestId('policy-0002')).toBeInTheDocument();
-    expect(results.queryByTestId('policy-0003')).toBeInTheDocument();
+    fireEvent.click(results.getByTestId('agentPoliciesNumberBadge'));
 
-    await act(async () => {
-      fireEvent.click(results.getByTestId('agentPoliciesPopoverButton'));
+    await waitFor(() => {
+      expect(results.queryByTestId('agentPoliciesPopover')).toBeInTheDocument();
+      expect(results.queryByTestId('agentPoliciesPopoverButton')).toBeInTheDocument();
+      expect(results.queryByTestId('policy-0001')).toBeInTheDocument();
+      expect(results.queryByTestId('policy-0002')).toBeInTheDocument();
+      expect(results.queryByTestId('policy-0003')).toBeInTheDocument();
     });
 
+    fireEvent.click(results.getByTestId('agentPoliciesPopoverButton'));
+
     expect(results.queryByTestId('manageAgentPoliciesModal')).toBeInTheDocument();
   });
 });
diff --git a/x-pack/plugins/fleet/public/components/package_policy_actions_menu.test.tsx b/x-pack/plugins/fleet/public/components/package_policy_actions_menu.test.tsx
@@ -7,7 +7,7 @@
 
 import React from 'react';
 
-import { act } from '@testing-library/react';
+import { waitFor } from '@testing-library/react';
 
 import type { AgentPolicy, InMemoryPackagePolicy } from '../types';
 import { createIntegrationsTestRendererMock } from '../mock';
@@ -109,8 +109,8 @@ function createMockPackagePolicy(
     ...props,
   };
 }
-// FLAKY: https://github.com/elastic/kibana/issues/191804
-describe.skip('PackagePolicyActionsMenu', () => {
+
+describe('PackagePolicyActionsMenu', () => {
   beforeAll(() => {
     useMultipleAgentPoliciesMock.mockReturnValue({ canUseMultipleAgentPolicies: false });
   });
@@ -119,7 +119,8 @@ describe.skip('PackagePolicyActionsMenu', () => {
     const agentPolicies = createMockAgentPolicies();
     const packagePolicy = createMockPackagePolicy({ hasUpgrade: false });
     const { utils } = renderMenu({ agentPolicies, packagePolicy });
-    await act(async () => {
+
+    await waitFor(() => {
       expect(utils.queryByTestId('PackagePolicyActionsUpgradeItem')).toBeNull();
     });
   });
@@ -129,7 +130,7 @@ describe.skip('PackagePolicyActionsMenu', () => {
     const packagePolicy = createMockPackagePolicy({ hasUpgrade: true });
     const { utils } = renderMenu({ agentPolicies, packagePolicy });
 
-    await act(async () => {
+    await waitFor(() => {
       const upgradeButton = utils.getByTestId('PackagePolicyActionsUpgradeItem');
       expect(upgradeButton).not.toBeDisabled();
     });
@@ -140,7 +141,7 @@ describe.skip('PackagePolicyActionsMenu', () => {
     const packagePolicy = createMockPackagePolicy({ hasUpgrade: true });
     const { utils } = renderMenu({ agentPolicies, packagePolicy });
 
-    await act(async () => {
+    await waitFor(() => {
       const upgradeButton = utils.getByTestId('PackagePolicyActionsUpgradeItem');
       expect(upgradeButton).toBeDisabled();
     });
@@ -150,7 +151,7 @@ describe.skip('PackagePolicyActionsMenu', () => {
     const agentPolicies = createMockAgentPolicies({ is_managed: true });
     const packagePolicy = createMockPackagePolicy();
     const { utils } = renderMenu({ agentPolicies, packagePolicy });
-    await act(async () => {
+    await waitFor(() => {
       expect(utils.queryByText('Delete integration')).toBeNull();
     });
   });
@@ -159,7 +160,7 @@ describe.skip('PackagePolicyActionsMenu', () => {
     const agentPolicies = createMockAgentPolicies({ is_managed: false });
     const packagePolicy = createMockPackagePolicy();
     const { utils } = renderMenu({ agentPolicies, packagePolicy });
-    await act(async () => {
+    await waitFor(() => {
       expect(utils.queryByText('Delete integration')).not.toBeNull();
     });
   });
@@ -168,7 +169,7 @@ describe.skip('PackagePolicyActionsMenu', () => {
     const agentPolicies = createMockAgentPolicies({ is_managed: false, supports_agentless: true });
     const packagePolicy = createMockPackagePolicy();
     const { utils } = renderMenu({ agentPolicies, packagePolicy });
-    await act(async () => {
+    await waitFor(() => {
       expect(utils.queryByText('Delete integration')).not.toBeNull();
     });
   });
@@ -177,7 +178,7 @@ describe.skip('PackagePolicyActionsMenu', () => {
     const agentPolicies = createMockAgentPolicies();
     const packagePolicy = createMockPackagePolicy({ hasUpgrade: true });
     const { utils } = renderMenu({ agentPolicies, packagePolicy, showAddAgent: true });
-    await act(async () => {
+    await waitFor(() => {
       expect(utils.queryByText('Add agent')).not.toBeNull();
     });
   });
@@ -186,7 +187,7 @@ describe.skip('PackagePolicyActionsMenu', () => {
     const agentPolicies = createMockAgentPolicies({ is_managed: true });
     const packagePolicy = createMockPackagePolicy({ hasUpgrade: true });
     const { utils } = renderMenu({ agentPolicies, packagePolicy, showAddAgent: true });
-    await act(async () => {
+    await waitFor(() => {
       expect(utils.queryByText('Add agent')).toBeNull();
     });
   });
@@ -195,7 +196,7 @@ describe.skip('PackagePolicyActionsMenu', () => {
     const agentPolicies = createMockAgentPolicies({ supports_agentless: true });
     const packagePolicy = createMockPackagePolicy({ hasUpgrade: true });
     const { utils } = renderMenu({ agentPolicies, packagePolicy, showAddAgent: true });
-    await act(async () => {
+    await waitFor(() => {
       expect(utils.queryByText('Add agent')).toBeNull();
     });
   });
@@ -204,7 +205,7 @@ describe.skip('PackagePolicyActionsMenu', () => {
     const agentPolicies = createMockAgentPolicies();
     const packagePolicy = createMockPackagePolicy();
     const { utils } = renderMenu({ agentPolicies, packagePolicy });
-    await act(async () => {
+    await waitFor(() => {
       const editButton = utils.getByTestId('PackagePolicyActionsEditItem');
       expect(editButton).not.toHaveAttribute('disabled');
       expect(editButton).toHaveAttribute('href');
@@ -227,7 +228,7 @@ describe.skip('PackagePolicyActionsMenu', () => {
       agentPolicies: [],
       packagePolicy,
     });
-    await act(async () => {
+    await waitFor(() => {
       const editButton = utils.getByTestId('PackagePolicyActionsEditItem');
       expect(editButton).not.toHaveAttribute('disabled');
       expect(editButton).toHaveAttribute('href');