Skip to content

Commit

Permalink
[8.12] [Discover] Unskip field tokens tests (#172794) (#172841)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Discover] Unskip field tokens tests
(#172794)](#172794)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T15:22:02Z","message":"[Discover]
Unskip field tokens tests (#172794)\n\n- Closes
https://github.com/elastic/kibana/issues/172756\r\n\r\n##
Summary\r\n\r\nLooks like ES|QL now supports geo
fields.\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4240","sha":"c3864a5d1001526f0da05bd0fe4d1f23a8bcb503","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.13.0"],"number":172794,"url":"https://github.com/elastic/kibana/pull/172794","mergeCommit":{"message":"[Discover]
Unskip field tokens tests (#172794)\n\n- Closes
https://github.com/elastic/kibana/issues/172756\r\n\r\n##
Summary\r\n\r\nLooks like ES|QL now supports geo
fields.\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4240","sha":"c3864a5d1001526f0da05bd0fe4d1f23a8bcb503"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172794","number":172794,"mergeCommit":{"message":"[Discover]
Unskip field tokens tests (#172794)\n\n- Closes
https://github.com/elastic/kibana/issues/172756\r\n\r\n##
Summary\r\n\r\nLooks like ES|QL now supports geo
fields.\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4240","sha":"c3864a5d1001526f0da05bd0fe4d1f23a8bcb503"}}]}]
BACKPORT-->

---------

Co-authored-by: Julia Rechkunova <[email protected]>
Co-authored-by: Julia Rechkunova <[email protected]>
  • Loading branch information
3 people authored Dec 8, 2023
1 parent a1aac56 commit 16c3bbe
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions test/functional/apps/discover/group2/_data_grid_field_tokens.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
return firstFieldIcons;
}

// FAILING ES PROMOTION: https://github.com/elastic/kibana/issues/172874
describe.skip('discover data grid field tokens', function () {
describe('discover data grid field tokens', function () {
before(async () => {
await security.testUser.setRoles(['kibana_admin', 'test_logstash_reader']);
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
Expand Down Expand Up @@ -129,21 +128,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.unifiedFieldList.clickFieldListItemAdd('bytes');
await PageObjects.unifiedFieldList.clickFieldListItemAdd('extension');
await PageObjects.unifiedFieldList.clickFieldListItemAdd('ip');
await PageObjects.unifiedFieldList.clickFieldListItemAdd('geo.coordinates');

expect(await findFirstColumnTokens()).to.eql(['Number', 'String', 'String']);

expect(await findFirstDocViewerTokens()).to.eql([
const docViewerTokens = await findFirstDocViewerTokens();
expect(docViewerTokens?.slice(0, 6)).to.eql([
'String',
'String',
'Date',
'String',
'Number',
'String',
'String',
'Unknown field',
'String',
'String',
]);
});

Expand Down

0 comments on commit 16c3bbe

Please sign in to comment.