Skip to content

Commit

Permalink
[8.11] [Enterprise Search] fix: use full path for search apps nav url (
Browse files Browse the repository at this point in the history
…#169014) (#169028)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Enterprise Search] fix: use full path for search apps nav url
(#169014)](#169014)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rodney
Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-16T20:10:00Z","message":"[Enterprise
Search] fix: use full path for search apps nav url (#169014)\n\n##
Summary\r\n\r\nUpdated the left nav `to` path for search applications to
match the full\r\npath so the isActive check can pass instead of used
the base path
to\r\nredirect.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/1972968/9b8ac4fa-8896-43d5-825c-39f5b38d48ee)","sha":"1d2cd5889df34ac7a04218e38ab0f927ba2d3ab8","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.11.0","v8.12.0"],"number":169014,"url":"https://github.com/elastic/kibana/pull/169014","mergeCommit":{"message":"[Enterprise
Search] fix: use full path for search apps nav url (#169014)\n\n##
Summary\r\n\r\nUpdated the left nav `to` path for search applications to
match the full\r\npath so the isActive check can pass instead of used
the base path
to\r\nredirect.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/1972968/9b8ac4fa-8896-43d5-825c-39f5b38d48ee)","sha":"1d2cd5889df34ac7a04218e38ab0f927ba2d3ab8"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169014","number":169014,"mergeCommit":{"message":"[Enterprise
Search] fix: use full path for search apps nav url (#169014)\n\n##
Summary\r\n\r\nUpdated the left nav `to` path for search applications to
match the full\r\npath so the isActive check can pass instead of used
the base path
to\r\nredirect.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/1972968/9b8ac4fa-8896-43d5-825c-39f5b38d48ee)","sha":"1d2cd5889df34ac7a04218e38ab0f927ba2d3ab8"}}]}]
BACKPORT-->

Co-authored-by: Rodney Norris <[email protected]>
  • Loading branch information
kibanamachine and TattdCodeMonkey authored Oct 16, 2023
1 parent eb2a11f commit 12145fc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe('useEnterpriseSearchContentNav', () => {
id: 'applications',
items: [
{
href: '/app/enterprise_search/applications',
href: '/app/enterprise_search/applications/search_applications',
id: 'searchApplications',
name: 'Search Applications',
},
Expand Down Expand Up @@ -226,7 +226,7 @@ describe('useEnterpriseSearchApplicationNav', () => {
id: 'applications',
items: [
{
href: '/app/enterprise_search/applications',
href: '/app/enterprise_search/applications/search_applications',
id: 'searchApplications',
name: 'Search Applications',
},
Expand Down Expand Up @@ -413,7 +413,7 @@ describe('useEnterpriseSearchAnalyticsNav', () => {
id: 'applications',
items: [
{
href: '/app/enterprise_search/applications',
href: '/app/enterprise_search/applications/search_applications',
id: 'searchApplications',
name: 'Search Applications',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const useEnterpriseSearchNav = () => {
}),
...generateNavLink({
shouldNotCreateHref: true,
to: APPLICATIONS_PLUGIN.URL,
to: APPLICATIONS_PLUGIN.URL + SEARCH_APPLICATIONS_PATH,
}),
},
{
Expand Down

0 comments on commit 12145fc

Please sign in to comment.