Skip to content

Commit

Permalink
[ci] re-enabled 'transaction-details' tests (#198689)
Browse files Browse the repository at this point in the history
## Summary

Reenables `transaction_details` and adds additional timeout.
I went through cypress tests history and it appears the initial attempt
to fix this didn't add a timeout increase to `'shows top errors table'`.
I've added this and it appears the issue is resolved in both locally and
on the ci.
  • Loading branch information
bryce-b authored Nov 5, 2024
1 parent 4869b8f commit 0f6c961
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# APM E2E

APM uses [FTR](../../../../../packages/kbn-test/README.md) (functional test runner) and [Cypress](https://www.cypress.io/) to run the e2e tests. The tests are located at `kibana/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/integration`.
APM uses [FTR](../../../../../packages/kbn-test/README.mdx) (functional test runner) and [Cypress](https://www.cypress.io/) to run the e2e tests. The tests are located at `kibana/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/integration`.

## Tips and best practices

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const timeRange = {
rangeTo: end,
};
// flaky
describe.skip('Transaction details', () => {
describe('Transaction details', () => {
before(() => {
synthtrace.index(
opbeans({
Expand All @@ -34,8 +34,7 @@ describe.skip('Transaction details', () => {
cy.loginAsViewerUser();
});

// skipping this as it´s been failing a lot lately, more information here https://github.com/elastic/kibana/issues/197386
it.skip('shows transaction name and transaction charts', () => {
it('shows transaction name and transaction charts', () => {
cy.intercept('GET', '/internal/apm/services/opbeans-java/transactions/charts/latency?*').as(
'transactionLatencyRequest'
);
Expand All @@ -61,7 +60,7 @@ describe.skip('Transaction details', () => {
'@transactionThroughputRequest',
'@transactionFailureRateRequest',
],
{ timeout: 60000 }
{ timeout: 30000 }
).spread((latencyInterception, throughputInterception, failureRateInterception) => {
expect(latencyInterception.request.query.transactionName).to.be.eql('GET /api/product');

Expand Down Expand Up @@ -107,16 +106,15 @@ describe.skip('Transaction details', () => {
);
cy.contains('Create SLO');
});
// skipping this as it´s been failing a lot lately, more information here https://github.com/elastic/kibana/issues/197386
it.skip('shows top errors table', () => {
it('shows top errors table', () => {
cy.visitKibana(
`/app/apm/services/opbeans-java/transactions/view?${new URLSearchParams({
...timeRange,
transactionName: 'GET /api/product',
})}`
);

cy.contains('Top 5 errors');
cy.contains('Top 5 errors', { timeout: 30000 });
cy.getByTestSubj('topErrorsForTransactionTable').contains('a', '[MockError] Foo').click();
cy.url().should('include', 'opbeans-java/errors');
});
Expand Down

0 comments on commit 0f6c961

Please sign in to comment.