Skip to content

Commit

Permalink
[8.11] [HTTP] versionResolution doc comment with information about …
Browse files Browse the repository at this point in the history
…internal routes (#171971) (#172250)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[HTTP] `versionResolution` doc comment with information about
internal routes
(#171971)](#171971)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-30T06:39:32Z","message":"[HTTP]
`versionResolution` doc comment with information about internal routes
(#171971)","sha":"df6e8ddaed3d32207d9e4ce7c3d0d961428b60a3","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:http","Team:Core","release_note:skip","v8.1.3","v8.12.0"],"number":171971,"url":"https://github.com/elastic/kibana/pull/171971","mergeCommit":{"message":"[HTTP]
`versionResolution` doc comment with information about internal routes
(#171971)","sha":"df6e8ddaed3d32207d9e4ce7c3d0d961428b60a3"}},"sourceBranch":"main","suggestedTargetBranches":["8.1"],"targetPullRequestStates":[{"branch":"8.1","label":"v8.1.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171971","number":171971,"mergeCommit":{"message":"[HTTP]
`versionResolution` doc comment with information about internal routes
(#171971)","sha":"df6e8ddaed3d32207d9e4ce7c3d0d961428b60a3"}}]}]
BACKPORT-->

Co-authored-by: Jean-Louis Leysens <[email protected]>
  • Loading branch information
kibanamachine and jloleysens authored Nov 30, 2023
1 parent e5a6958 commit 0e1d692
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,10 @@ const configSchema = schema.object(

versioned: schema.object({
/**
* Which handler resolution algo to use: "newest" or "oldest".
* Which handler resolution algo to use for public routes: "newest" or "oldest".
*
* @note in development we have an additional option "none" which is also the default.
* @note Internal routes always require a version to be specified.
* @note in development we have an additional option "none" which is also the default in dev.
* This prevents any fallbacks and requires that a version specified.
* Useful for ensuring that a given client always specifies a version.
*/
Expand Down

0 comments on commit 0e1d692

Please sign in to comment.