Rename data-test-subj and page objects

docs/developer/plugin-list.asciidoc

@@ -648,7 +648,7 @@ using the CURL scripts in the scripts folder.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/observability_solution/logs_explorer/README.md[logsExplorer]
-|This plugin is home to the <LogExplorer /> component and related types. It implements several of the underlying concepts that the Observability Log Explorer app builds upon.
+|This plugin is home to the <LogExplorer /> component and related types. It implements several of the underlying concepts that the Observability Logs Explorer app builds upon.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/logs_shared/README.md[logsShared]

src/plugins/discover/public/application/main/components/top_nav/discover_topnav_serverless.test.tsx

@@ -130,8 +130,8 @@ describe('DiscoverTopNavServerless', () => {
     });
   });
 
-  describe('LogExplorerTabs', () => {
-    it('should render when showLogExplorerTabs is true', async () => {
+  describe('LogsExplorerTabs', () => {
+    it('should render when showLogsExplorerTabs is true', async () => {
       mockUseKibana.mockReturnValue({
         services: {
           ...mockDiscoverService,
@@ -148,12 +148,12 @@ describe('DiscoverTopNavServerless', () => {
       const topNav = screen.queryByTestId('discoverTopNavServerless');
       expect(topNav).not.toBeNull();
       await waitFor(() => {
-        const logExplorerTabs = screen.queryByTestId('logExplorerTabs');
+        const logExplorerTabs = screen.queryByTestId('logsExplorerTabs');
         expect(logExplorerTabs).not.toBeNull();
       });
     });
 
-    it('should not render when showLogExplorerTabs is false', async () => {
+    it('should not render when showLogsExplorerTabs is false', async () => {
       mockUseKibana.mockReturnValue({
         services: {
           ...mockDiscoverService,
@@ -169,7 +169,7 @@ describe('DiscoverTopNavServerless', () => {
       const topNav = screen.queryByTestId('discoverTopNavServerless');
       expect(topNav).not.toBeNull();
       await waitFor(() => {
-        const logExplorerTabs = screen.queryByTestId('logExplorerTabs');
+        const logExplorerTabs = screen.queryByTestId('logsExplorerTabs');
         expect(logExplorerTabs).toBeNull();
       });
     });

src/plugins/discover/public/components/log_explorer_tabs/log_explorer_tabs.tsx

@@ -41,15 +41,15 @@ export const LogExplorerTabs = ({ services, selectedTab }: LogExplorerTabsProps)
   });
 
   return (
-    <EuiTabs bottomBorder={false} data-test-subj="logExplorerTabs">
+    <EuiTabs bottomBorder={false} data-test-subj="logsExplorerTabs">
       <EuiTab
         isSelected={selectedTab === 'discover'}
         href={discoverUrl}
         onClick={navigateToDiscover}
         css={{ '.euiTab__content': { lineHeight: euiTheme.size.xxxl } }}
         data-test-subj="discoverTab"
       >
-        {i18n.translate('discover.logExplorerTabs.discover', {
+        {i18n.translate('discover.logsExplorerTabs.discover', {
           defaultMessage: 'Discover',
         })}
       </EuiTab>
@@ -58,9 +58,9 @@ export const LogExplorerTabs = ({ services, selectedTab }: LogExplorerTabsProps)
         href={logExplorerUrl}
         onClick={navigateToLogExplorer}
         css={{ '.euiTab__content': { lineHeight: euiTheme.size.xxxl } }}
-        data-test-subj="logExplorerTab"
+        data-test-subj="logsExplorerTab"
       >
-        {i18n.translate('discover.logExplorerTabs.logExplorer', {
+        {i18n.translate('discover.logsExplorerTabs.logsExplorer', {
           defaultMessage: 'Logs Explorer',
         })}
       </EuiTab>

x-pack/plugins/observability_onboarding/e2e/cypress/e2e/logs/custom_logs/install_elastic_agent.cy.ts

@@ -618,7 +618,7 @@ describe('[Logs onboarding] Custom logs - install elastic agent', () => {
         .should('exist');
     });
 
-    it('when user clicks on Explore Logs it navigates to observability log explorer', () => {
+    it('when user clicks on Explore Logs it navigates to observability logs explorer', () => {
       cy.wait('@checkOnboardingProgress');
       cy.getByTestSubj('obltOnboardingExploreLogs').should('exist').click();
 

x-pack/plugins/observability_onboarding/e2e/cypress/e2e/logs/system_logs.cy.ts

@@ -673,7 +673,7 @@ describe('[Logs onboarding] System logs', () => {
         cy.visitKibana('/app/observabilityOnboarding/systemLogs');
       });
 
-      it('when users clicks on Explore logs they navigate to log explorer - All logs', () => {
+      it('when users clicks on Explore logs they navigate to logs explorer - All logs', () => {
         cy.wait('@systemIntegrationInstall');
         cy.getByTestSubj('obltOnboardingExploreLogs').should('exist').click();
 
@@ -692,7 +692,7 @@ describe('[Logs onboarding] System logs', () => {
         cy.visitKibana('/app/observabilityOnboarding/systemLogs');
       });
 
-      it('when users clicks on Explore logs they navigate to log explorer and System integration is selected', () => {
+      it('when users clicks on Explore logs they navigate to logs explorer and System integration is selected', () => {
         cy.wait('@systemIntegrationInstall');
         cy.getByTestSubj('obltOnboardingExploreLogs').should('exist').click();
 

x-pack/plugins/observability_solution/logs_explorer/README.md

@@ -1,10 +1,10 @@
-# Log Explorer
+# Logs Explorer
 
-This plugin is home to the `<LogExplorer />` component and related types. It implements several of the underlying concepts that the [Observability Log Explorer app](../observability_solution/observability_logs_explorer) builds upon.
+This plugin is home to the `<LogExplorer />` component and related types. It implements several of the underlying concepts that the [Observability Logs Explorer app](../observability_solution/observability_logs_explorer) builds upon.
 
 ## Developing the `<LogExplorer />` component
 
-⚠ The Log Explorer is in early stages of development, so the following partly describes the current situation and partly the intended future scenario.
+⚠ The Logs Explorer is in early stages of development, so the following partly describes the current situation and partly the intended future scenario.
 
 ### Dependencies
 
@@ -20,11 +20,11 @@ While not fully realized yet, the dependency graph would roughly resemble the fo
 ```mermaid
 flowchart TD
 
-obs_log_explorer_app(Observability Log Explorer app)
+obs_log_explorer_app(Observability Logs Explorer app)
 obs_apps(Other Observability apps)
-obs_log_explorer_component(Observability Log Explorer component)
+obs_log_explorer_component(Observability Logs Explorer component)
 other_apps(Other non-Observability apps)
-log_explorer_component(Log Explorer component)
+log_explorer_component(Logs Explorer component)
 platform(Kibana Platform)
 discover(Discover Main container)
 fleet(Fleet / EPM)
@@ -47,7 +47,7 @@ When designing the API we face two conflicting goals:
 - It should be easy to consume by any non-observability app. This means...
   - its API needs to be relatively stable and straightforward.
   - it should not perform any page-wide changes that could interfere with consuming app's page state (such as URL changes).
-- It should be extensible so the Observability Log Explorer can build on top of this.
+- It should be extensible so the Observability Logs Explorer can build on top of this.
 
 In its current state the `<LogExplorer />` achieves neither goal. To resolve the tension in the future we could export two variants with different sets of properties.
 

x-pack/plugins/observability_solution/logs_explorer/public/components/flyout_detail/flyout_header.tsx

@@ -54,7 +54,7 @@ export function FlyoutHeader({ doc }: { doc: FlyoutDoc }) {
                 <LogLevel
                   level={doc[constants.LOG_LEVEL_FIELD]}
                   renderInFlyout={true}
-                  dataTestSubj="logExplorerFlyoutLogLevel"
+                  dataTestSubj="logsExplorerFlyoutLogLevel"
                 />
               </EuiFlexItem>
             </HoverActionPopover>
@@ -71,7 +71,7 @@ export function FlyoutHeader({ doc }: { doc: FlyoutDoc }) {
 
   const contentField = hasMessageField && (
     <EuiFlexItem grow={false}>
-      <EuiFlexGroup direction="column" gutterSize="s" data-test-subj="logExplorerFlyoutLogMessage">
+      <EuiFlexGroup direction="column" gutterSize="s" data-test-subj="logsExplorerFlyoutLogMessage">
         <EuiFlexItem>
           <EuiFlexGroup alignItems="flexEnd" gutterSize="none" justifyContent="spaceBetween">
             <EuiFlexItem grow={false}>
@@ -110,9 +110,9 @@ export function FlyoutHeader({ doc }: { doc: FlyoutDoc }) {
       buttonContent={accordionTitle}
       paddingSize="m"
       initialIsOpen={true}
-      data-test-subj={`logExplorerFlyoutHeaderSection${flyoutContentLabel}`}
+      data-test-subj={`logsExplorerFlyoutHeaderSection${flyoutContentLabel}`}
     >
-      <EuiFlexGroup direction="column" gutterSize="none" data-test-subj="logExplorerFlyoutDetail">
+      <EuiFlexGroup direction="column" gutterSize="none" data-test-subj="logsExplorerFlyoutDetail">
         {hasMessageField ? contentField : logLevelAndTimestamp}
       </EuiFlexGroup>
     </EuiAccordion>

x-pack/plugins/observability_solution/logs_explorer/public/components/flyout_detail/flyout_highlights.tsx

@@ -49,11 +49,11 @@ export function FlyoutHighlights({
       <HighlightSection
         title={serviceInfraAccordionTitle}
         columns={columns}
-        data-test-subj="logExplorerFlyoutHighlightSectionServiceInfra"
+        data-test-subj="logsExplorerFlyoutHighlightSectionServiceInfra"
       >
         {formattedDoc[constants.SERVICE_NAME_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutService"
+            data-test-subj="logsExplorerFlyoutService"
             field={constants.SERVICE_NAME_FIELD}
             formattedValue={formattedDoc[constants.SERVICE_NAME_FIELD]}
             label={flyoutServiceLabel}
@@ -63,7 +63,7 @@ export function FlyoutHighlights({
         )}
         {formattedDoc[constants.HOST_NAME_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutHostName"
+            data-test-subj="logsExplorerFlyoutHostName"
             field={constants.HOST_NAME_FIELD}
             formattedValue={formattedDoc[constants.HOST_NAME_FIELD]}
             label={flyoutHostNameLabel}
@@ -73,7 +73,7 @@ export function FlyoutHighlights({
         )}
         {formattedDoc[constants.TRACE_ID_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutTrace"
+            data-test-subj="logsExplorerFlyoutTrace"
             field={constants.TRACE_ID_FIELD}
             formattedValue={formattedDoc[constants.TRACE_ID_FIELD]}
             label={flyoutTraceLabel}
@@ -83,7 +83,7 @@ export function FlyoutHighlights({
         )}
         {formattedDoc[constants.ORCHESTRATOR_CLUSTER_NAME_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutClusterName"
+            data-test-subj="logsExplorerFlyoutClusterName"
             field={constants.ORCHESTRATOR_CLUSTER_NAME_FIELD}
             formattedValue={formattedDoc[constants.ORCHESTRATOR_CLUSTER_NAME_FIELD]}
             label={flyoutOrchestratorClusterNameLabel}
@@ -93,7 +93,7 @@ export function FlyoutHighlights({
         )}
         {formattedDoc[constants.ORCHESTRATOR_RESOURCE_ID_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutResourceId"
+            data-test-subj="logsExplorerFlyoutResourceId"
             field={constants.ORCHESTRATOR_RESOURCE_ID_FIELD}
             formattedValue={formattedDoc[constants.ORCHESTRATOR_RESOURCE_ID_FIELD]}
             label={flyoutOrchestratorResourceIdLabel}
@@ -106,11 +106,11 @@ export function FlyoutHighlights({
       <HighlightSection
         title={cloudAccordionTitle}
         columns={columns}
-        data-test-subj="logExplorerFlyoutHighlightSectionCloud"
+        data-test-subj="logsExplorerFlyoutHighlightSectionCloud"
       >
         {formattedDoc[constants.CLOUD_PROVIDER_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutCloudProvider"
+            data-test-subj="logsExplorerFlyoutCloudProvider"
             field={constants.CLOUD_PROVIDER_FIELD}
             formattedValue={formattedDoc[constants.CLOUD_PROVIDER_FIELD]}
             icon={
@@ -127,7 +127,7 @@ export function FlyoutHighlights({
         )}
         {formattedDoc[constants.CLOUD_REGION_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutCloudRegion"
+            data-test-subj="logsExplorerFlyoutCloudRegion"
             field={constants.CLOUD_REGION_FIELD}
             formattedValue={formattedDoc[constants.CLOUD_REGION_FIELD]}
             label={flyoutCloudRegionLabel}
@@ -137,7 +137,7 @@ export function FlyoutHighlights({
         )}
         {formattedDoc[constants.CLOUD_AVAILABILITY_ZONE_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutCloudAz"
+            data-test-subj="logsExplorerFlyoutCloudAz"
             field={constants.CLOUD_AVAILABILITY_ZONE_FIELD}
             formattedValue={formattedDoc[constants.CLOUD_AVAILABILITY_ZONE_FIELD]}
             label={flyoutCloudAvailabilityZoneLabel}
@@ -147,7 +147,7 @@ export function FlyoutHighlights({
         )}
         {formattedDoc[constants.CLOUD_PROJECT_ID_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutCloudProjectId"
+            data-test-subj="logsExplorerFlyoutCloudProjectId"
             field={constants.CLOUD_PROJECT_ID_FIELD}
             formattedValue={formattedDoc[constants.CLOUD_PROJECT_ID_FIELD]}
             label={flyoutCloudProjectIdLabel}
@@ -157,7 +157,7 @@ export function FlyoutHighlights({
         )}
         {formattedDoc[constants.CLOUD_INSTANCE_ID_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutCloudInstanceId"
+            data-test-subj="logsExplorerFlyoutCloudInstanceId"
             field={constants.CLOUD_INSTANCE_ID_FIELD}
             formattedValue={formattedDoc[constants.CLOUD_INSTANCE_ID_FIELD]}
             label={flyoutCloudInstanceIdLabel}
@@ -170,11 +170,11 @@ export function FlyoutHighlights({
       <HighlightSection
         title={otherAccordionTitle}
         columns={columns}
-        data-test-subj="logExplorerFlyoutHighlightSectionOther"
+        data-test-subj="logsExplorerFlyoutHighlightSectionOther"
       >
         {formattedDoc[constants.LOG_FILE_PATH_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutLogPathFile"
+            data-test-subj="logsExplorerFlyoutLogPathFile"
             field={constants.LOG_FILE_PATH_FIELD}
             formattedValue={formattedDoc[constants.LOG_FILE_PATH_FIELD]}
             label={flyoutLogPathFileLabel}
@@ -184,7 +184,7 @@ export function FlyoutHighlights({
         )}
         {formattedDoc[constants.DATASTREAM_DATASET_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutDataset"
+            data-test-subj="logsExplorerFlyoutDataset"
             field={constants.DATASTREAM_DATASET_FIELD}
             formattedValue={formattedDoc[constants.DATASTREAM_DATASET_FIELD]}
             label={flyoutDatasetLabel}
@@ -194,7 +194,7 @@ export function FlyoutHighlights({
         )}
         {formattedDoc[constants.DATASTREAM_NAMESPACE_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutNamespace"
+            data-test-subj="logsExplorerFlyoutNamespace"
             field={constants.DATASTREAM_NAMESPACE_FIELD}
             formattedValue={formattedDoc[constants.DATASTREAM_NAMESPACE_FIELD]}
             label={flyoutNamespaceLabel}
@@ -205,7 +205,7 @@ export function FlyoutHighlights({
         )}
         {formattedDoc[constants.AGENT_NAME_FIELD] && (
           <HighlightField
-            data-test-subj="logExplorerFlyoutLogShipper"
+            data-test-subj="logsExplorerFlyoutLogShipper"
             field={constants.AGENT_NAME_FIELD}
             formattedValue={formattedDoc[constants.AGENT_NAME_FIELD]}
             label={flyoutShipperLabel}

x-pack/plugins/observability_solution/logs_explorer/public/components/flyout_detail/sub_components/timestamp.tsx

@@ -17,7 +17,7 @@ export function Timestamp({ timestamp }: TimestampProps) {
   if (!timestamp) return null;
 
   return (
-    <EuiBadge color="hollow" data-test-subj="logExplorerFlyoutLogTimestamp">
+    <EuiBadge color="hollow" data-test-subj="logsExplorerFlyoutLogTimestamp">
       {timestamp}
     </EuiBadge>
   );

x-pack/plugins/observability_solution/logs_explorer/public/components/virtual_columns/content.tsx

@@ -31,9 +31,9 @@ const LogMessage = ({ field, value }: { field?: string; value: string }) => {
   return (
     <EuiText size="xs" style={{ display: 'inline', marginLeft: '5px' }}>
       {renderFieldPrefix && (
-        <strong data-test-subj="logExplorerDataTableMessageKey">{field}</strong>
+        <strong data-test-subj="logsExplorerDataTableMessageKey">{field}</strong>
       )}
-      <span data-test-subj="logExplorerDataTableMessageValue" style={{ marginLeft: '5px' }}>
+      <span data-test-subj="logsExplorerDataTableMessageValue" style={{ marginLeft: '5px' }}>
         {value}
       </span>
     </EuiText>
@@ -108,7 +108,7 @@ export const Content = ({
           fieldFormats={fieldFormats}
           shouldShowFieldHandler={shouldShowFieldHandler}
           maxEntries={50}
-          dataTestSubj="logExplorerCellDescriptionList"
+          dataTestSubj="logsExplorerCellDescriptionList"
           className="logsExplorerVirtualColumn__sourceDocument"
         />
       )}

x-pack/plugins/observability_solution/logs_explorer/public/customizations/custom_flyout_content.tsx

@@ -46,7 +46,7 @@ const CustomFlyoutContent = ({
     <>
       <EuiSpacer size="m" />
       <EuiFlexGroup direction="column">
-        {/* Apply custom Log Explorer detail */}
+        {/* Apply custom Logs Explorer detail */}
         {renderCustomizedContent(flyoutContentProps)}
       </EuiFlexGroup>
     </>

x-pack/plugins/observability_solution/logs_explorer/public/utils/get_data_view_test_subj.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-const BASE_DATA_VIEW_TEST_SUBJ = 'logExplorerDataView';
+const BASE_DATA_VIEW_TEST_SUBJ = 'logsExplorerDataView';
 
 const publicDataViewPatternsSet = new Set(['logs-*', 'logstash-*', 'filebeat-*']);
 

x-pack/plugins/observability_solution/observability_logs_explorer/README.md

@@ -1,4 +1,4 @@
-# Observability Log Explorer
+# Observability Logs Explorer
 
 This plugin provides an app based on the `LogExplorer` component from the `logs_explorer` plugin, but adds observability-specific affordances.
 
@@ -39,11 +39,11 @@ yarn test:ftr:runner --config ./x-pack/test_serverless/functional/test_suites/ob
 
 ## Checktypes
 
-#### Log Explorer
+#### Logs Explorer
 ```
 node scripts/type_check.js --project x-pack/plugins/observability_solution/logs_explorer/tsconfig.json
 ```
-#### Observability Log Explorer
+#### Observability Logs Explorer
 ```
 node scripts/type_check.js --project x-pack/plugins/observability_solution/observability_logs_explorer/tsconfig.json
 ```

x-pack/plugins/observability_solution/observability_logs_explorer/public/components/discover_link.tsx

@@ -74,7 +74,7 @@ export const DiscoverLinkForUnknownState = React.memo(() => (
   <EuiHeaderLink
     color="primary"
     iconType="discoverApp"
-    data-test-subj="logExplorerDiscoverFallbackLink"
+    data-test-subj="logsExplorerDiscoverFallbackLink"
     disabled
   >
     {discoverLinkTitle}
@@ -105,7 +105,7 @@ export const DiscoverLink = React.memo(
         {...discoverLinkProps}
         color="primary"
         iconType="discoverApp"
-        data-test-subj="logExplorerDiscoverFallbackLink"
+        data-test-subj="logsExplorerDiscoverFallbackLink"
       >
         {discoverLinkTitle}
       </EuiHeaderLink>