Skip to content

Commit

Permalink
[embeddable] remove export of inspector-plugin types (#204816)
Browse files Browse the repository at this point in the history
  • Loading branch information
nreese authored Dec 18, 2024
1 parent db56f01 commit 07c85dc
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 18 deletions.
1 change: 0 additions & 1 deletion src/plugins/embeddable/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ export {
withEmbeddableSubscription,
} from './lib';
export type {
Adapters,
CellValueContext,
ChartActionContext,
EmbeddableContext,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import * as Rx from 'rxjs';
import { merge } from 'rxjs';
import { debounceTime, distinctUntilChanged, map, skip } from 'rxjs';
import { RenderCompleteDispatcher } from '@kbn/kibana-utils-plugin/public';
import { Adapters } from '../types';
import { Adapters } from '@kbn/inspector-plugin/public';
import { EmbeddableError, EmbeddableOutput, IEmbeddable } from './i_embeddable';
import { EmbeddableInput, ViewMode } from '../../../common/types';
import { genericEmbeddableInputIsEqual, omitGenericEmbeddableInput } from './diff_embeddable_input';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
*/

import { ErrorLike } from '@kbn/expressions-plugin/common';
import { Adapters } from '@kbn/inspector-plugin/public';
import { Observable } from 'rxjs';
import { EmbeddableInput } from '../../../common/types';
import { Adapters } from '../types';

export type EmbeddableError = ErrorLike;
export type { EmbeddableInput };
Expand Down
10 changes: 0 additions & 10 deletions src/plugins/embeddable/public/lib/inspector.ts

This file was deleted.

3 changes: 0 additions & 3 deletions src/plugins/embeddable/public/lib/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

import { Adapters } from './inspector';

export interface Trigger {
id: string;
title?: string;
Expand All @@ -23,7 +21,6 @@ export interface PropertySpec {
value?: string;
}
export { ViewMode } from '../../common/types';
export type { Adapters };

export interface CommonlyUsedRange {
from: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ import { TimefilterContract } from '@kbn/data-plugin/public';
import type { DataView } from '@kbn/data-views-plugin/public';
import { Warnings } from '@kbn/charts-plugin/public';
import { hasUnsupportedDownsampledAggregationFailure } from '@kbn/search-response-warnings';
import { Adapters } from '@kbn/inspector-plugin/public';
import {
Adapters,
Embeddable,
EmbeddableInput,
EmbeddableOutput,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
KibanaExecutionContext,
ScopedHistory,
} from '@kbn/core/public';
import { Adapters } from '@kbn/embeddable-plugin/public';
import { Adapters } from '@kbn/inspector-plugin/public';
import { Subscription } from 'rxjs';
import { type Filter, FilterStateStore, type Query, type TimeRange } from '@kbn/es-query';
import type { DataViewSpec } from '@kbn/data-views-plugin/public';
Expand Down

0 comments on commit 07c85dc

Please sign in to comment.