Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logstash] fix mappings #4594

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Nov 8, 2022

Summary

Regression in mappings were introduced in previous change

Testing

  • build logstash package elastic-package build
  • start a stack elastic-package stack up -v -d --version 8.5.0-SNAPSHOT
  • start logstash service elastic-package service up -v
  • install elasticsearch and logstash packages
  • logstash appears in standalone and elasticsearch cluster

@elasticmachine
Copy link

elasticmachine commented Nov 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-16T11:15:43.507+0000

  • Duration: 17 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 8, 2022

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 8, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (6/6) 💚 2.53
Classes 100.0% (6/6) 💚 2.53
Methods 100.0% (46/46) 💚 9.101
Lines 87.558% (190/217) 👎 -4.139
Conditionals 100.0% (0/0) 💚

@klacabane klacabane self-assigned this Nov 8, 2022
@klacabane klacabane added Integration:logstash Logstash Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Nov 8, 2022
@klacabane klacabane marked this pull request as ready for review November 8, 2022 17:34
@klacabane klacabane requested a review from a team as a code owner November 8, 2022 17:34
@miltonhultgren
Copy link
Contributor

When I first clicked the pipelines page I got this error:

[2022-11-15T14:26:52.411+00:00][ERROR][plugins.monitoring.monitoring] TypeError: Cannot read properties of undefined (reading 'firstSeen')
    at getPipeline (/usr/share/kibana/x-pack/plugins/monitoring/server/lib/logstash/get_pipeline.js:100:109)
    at Object.handler (/usr/share/kibana/x-pack/plugins/monitoring/server/routes/api/v1/logstash/pipeline.js:80:85)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at handler (/usr/share/kibana/x-pack/plugins/monitoring/server/plugin.js:358:28)
    at Router.handle (/usr/share/kibana/node_modules/@kbn/core-http-router-server-internal/target_node/src/router.js:163:30)
    at handler (/usr/share/kibana/node_modules/@kbn/core-http-router-server-internal/target_node/src/router.js:124:50)
    at exports.Manager.execute (/usr/share/kibana/node_modules/@hapi/hapi/lib/toolkit.js:60:28)
    at Object.internals.handler (/usr/share/kibana/node_modules/@hapi/hapi/lib/handler.js:46:20)
    at exports.execute (/usr/share/kibana/node_modules/@hapi/hapi/lib/handler.js:31:20)
    at Request._lifecycle (/usr/share/kibana/node_modules/@hapi/hapi/lib/request.js:371:32)
    at Request._execute (/usr/share/kibana/node_modules/@hapi/hapi/lib/request.js:281:9)

But it quickly resolved itself. Everything else seems to work well.

@klacabane
Copy link
Contributor Author

Was that the only error logged ? This could happen if documents are not ingested yet but I thought we added a guard for that with a user friendly message. Can you reproduce it ?

@miltonhultgren
Copy link
Contributor

I tried to reproduce it but couldn't 🤷🏼 Probably fine then

@klacabane klacabane merged commit 6dd7415 into elastic:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:logstash Logstash Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants