Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for packages with ML Modules to ensure naming is consistent #11165

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Sep 17, 2024

Proposed commit message

This PR updates the README for the packages containing ML Modules.
Changing ML Modules to 'Anomaly Detection Configurations' to be in line with the way we refer to the UI they link to in the assets tab.
As this is not a super high priority change, this can be published later with the next update to these packages.

These changes coincide with the changes to the way we refer to ML Assets (previously 'ML Modules') and the new ML UI for 'Supplied Configurations'.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@alvarezmelissa87 alvarezmelissa87 added enhancement New feature or request Integration:apache Apache HTTP Server Integration:nginx Nginx labels Sep 17, 2024
@alvarezmelissa87 alvarezmelissa87 self-assigned this Sep 17, 2024
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner September 17, 2024 21:01
@andrewkroh andrewkroh added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Sep 17, 2024
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Sep 17, 2024

🚀 Benchmarks report

Package nginx 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
access 2881.84 1855.29 -1026.55 (-35.62%) 💔

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 requested review from alaudazzi and a team September 19, 2024 16:16
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @alvarezmelissa87

Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 merged commit 424e6e6 into elastic:main Sep 19, 2024
5 checks passed
@alvarezmelissa87 alvarezmelissa87 deleted the integration-ml-module-rename branch September 19, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:apache Apache HTTP Server Integration:nginx Nginx Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants