Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub book-level attributes from Fleet & Agent guide #973

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Mar 12, 2024

This removes most of the book-level attributes in the Fleet & Agent guide. I'm leaving a few that have to do with the tab widgets, so for those I'll wait and see how the Observability folks fix things up.

Backporting this to 8.13 so that if I've broken anything we'll know sooner rather than later.

Closes: #974

@kilfoyle kilfoyle requested a review from a team as a code owner March 12, 2024 22:03
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@kilfoyle
Copy link
Contributor Author

@elasticmachine merge upstream

@kilfoyle
Copy link
Contributor Author

@elasticmachine run docs-build

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilfoyle kilfoyle merged commit 973489f into elastic:main Mar 13, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Mar 13, 2024
* Scrub book-level attributes from Fleet & Agent guide

* Remove tab-widgets variables

(cherry picked from commit 973489f)
kilfoyle added a commit that referenced this pull request Mar 14, 2024
* Scrub book-level attributes from Fleet & Agent guide

* Remove tab-widgets variables

(cherry picked from commit 973489f)

Co-authored-by: David Kilfoyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrub book-level variables from the Fleet & Agent guide
2 participants