Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document possible collisions with '@custom ingest pipelines' #840

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Jan 22, 2024

This updates the ingest pipelines section of the docs as well as the Release Notes, to warn about possible naming collisions with the new custom ingest pipelines.

Closes: #841

@kpollich I'm not sure if I've understood or explained this very well, so I'd appreciate if you can add any changes you think we need. Thanks!


Release Notes "New features" update
Screenshot 2024-01-22 at 1 10 06 PM


Release Notes "Breaking changes" update
screen


Data Streams page update
screen

@kilfoyle kilfoyle requested a review from a team as a code owner January 22, 2024 18:31
@kilfoyle kilfoyle requested a review from kpollich January 22, 2024 18:31
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

kpollich
kpollich previously approved these changes Jan 22, 2024
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for getting this together so quickly. Could we link to elastic/kibana#175254 as we'll be posting findings and follow-ups there?

Comment on lines +276 to +278
* `global@custom`
* `traces@custom`
* `traces-apm@custom`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including some examples. I'll work on getting a full set of collision candidates (if it even exceeds this) on elastic/kibana#175254

@kpollich
Copy link
Member

run docs-build

@kilfoyle kilfoyle requested a review from karenzone January 23, 2024 15:27
@kilfoyle kilfoyle merged commit 8517570 into elastic:main Jan 23, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 23, 2024
* Document possible collisions with '@Custom ingest pipelines'

* Add breaking change

* Update breaking change with link to investigation issue 175254

* Change PR link to issue

(cherry picked from commit 8517570)
@kilfoyle
Copy link
Contributor Author

@kpollich I hope I didn't merge this prematurely, but if there are others to add to this list, just let me know and I'll open up a new PR.

global@custom
traces@custom
traces-apm@custom

kilfoyle added a commit that referenced this pull request Jan 23, 2024
…849)

* Document possible collisions with '@Custom ingest pipelines'

* Add breaking change

* Update breaking change with link to investigation issue 175254

* Change PR link to issue

(cherry picked from commit 8517570)

Co-authored-by: David Kilfoyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST]: [Fleet] [APM] Document 8.12.0 breaking change in APM ingest pipelines in 8.12.0 release notes
3 participants