Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document presets for performance tuning to ES output #749

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Document presets for performance tuning to ES output #749

merged 3 commits into from
Dec 12, 2023

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Dec 7, 2023 •
edited
Loading

This adds two new sections to the Fleet Elasticsearch output settings docs page:

  1. Description of the new "Performance tuning" option:

    screen

  2. These two Performance tuning settings tables, one showing the settings and one showing the potential performance impact.

Closes: #720

@kilfoyle kilfoyle requested a review from a team as a code owner December 7, 2023 17:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

A documentation preview will be available soon.
Help us out by validating the Buildkite preview and reporting issues here.

@kilfoyle kilfoyle requested a review from kpollich December 7, 2023 20:48
kpollich
kpollich previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM just two minor comments.

docs/en/ingest-management/fleet/fleet-settings-output-elasticsearch.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/fleet/fleet-settings-output-elasticsearch.asciidoc Outdated Show resolved Hide resolved
karenzone
karenzone previously approved these changes Dec 8, 2023
View reviewed changes
@kpollich
Copy link
Member

@kilfoyle - Should we avoid documenting the much lower throughput numbers for serverless related to stateful? Maybe you know a good person to ask if we have an approach to things like this elsewhere in serverless docs.

cc @joshdover @jlind23 maybe you have input as well.

@jlind23
Copy link
Contributor

jlind23 commented Dec 11, 2023

cc @joshdover @jlind23 maybe you have input as well.

I expect serverless performance to drastically improve over the next weeks/months, so I would indeed avoid documenting them for now.

@kilfoyle kilfoyle dismissed stale reviews from karenzone and kpollich via 1df7941 December 11, 2023 14:52
@kilfoyle
Copy link
Contributor Author

Thanks for the feedback @kpollich.

I've addressed the comments. For the "Potential performance impact" table, I removed the "Serverless throughput (relative to stateful)" row (via 1df7941). Here's how it looks now:

Screenshot 2023-12-11 at 9 57 04 AM

By the way, the security updates in this repo cause new commits to automatically dismiss any previous approvals. Would you mind approving again?

kpollich
kpollich approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing changes! 🚀

@karenzone
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

1 similar comment
@kilfoyle
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@lcawl
Copy link
Contributor

lcawl commented Dec 11, 2023

@elasticmachine run elasticsearch-ci/docs rebuild

karenzone
karenzone approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending passing docs-ci

@kilfoyle
Copy link
Contributor Author

@elasticmachine, run elasticsearch-ci/docs

1 similar comment
@kilfoyle
Copy link
Contributor Author

@elasticmachine, run elasticsearch-ci/docs

@lcawl
Copy link
Contributor

lcawl commented Dec 12, 2023

@elasticmachine run elasticsearch-ci/docs

@kilfoyle
Copy link
Contributor Author

@elasticmachine run buildkite/docs-build-pr

1 similar comment
@jlind23
Copy link
Contributor

jlind23 commented Dec 12, 2023

@elasticmachine run buildkite/docs-build-pr

@kilfoyle
Copy link
Contributor Author

I tried rebuilding directly from the buildkite page but it's still failing. We're investigating...

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Dec 12, 2023 •
edited
Loading

@elasticmachine run docs-build rebuild

@kilfoyle kilfoyle merged commit ffd8a6d into elastic:main Dec 12, 2023
4 checks passed
mergify bot pushed a commit that referenced this pull request Dec 12, 2023
@kilfoyle @mergify
Document presets for performance tuning to ES output (#749)
4998bf7 
* Document presets for performance tuning to ES output

* Typo and link fix

* Address review comments

(cherry picked from commit ffd8a6d)
@mergify mergify bot mentioned this pull request Dec 12, 2023
Merged
kilfoyle added a commit that referenced this pull request Dec 12, 2023
@mergify @kilfoyle
Document presets for performance tuning to ES output (#749) (#754)
edc96b4 
* Document presets for performance tuning to ES output

* Typo and link fix

* Address review comments

(cherry picked from commit ffd8a6d)

Co-authored-by: David Kilfoyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone approved these changes

@kpollich kpollich kpollich approved these changes

Assignees
No one assigned
Labels
backport-8.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQUEST][Fleet] Document presets for performance tuning to ES output configuration
5 participants
@kilfoyle @kpollich @jlind23 @karenzone @lcawl