Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to indicate that providers are no longer enabled by default #1530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kilfoyle
Copy link
Contributor

This updates the Provider docs to indicate that providers are no longer enabled by default, as a result of elastic/elastic-agent#6169


Closes: #1529
Target: 8.18

@kilfoyle kilfoyle requested a review from a team as a code owner December 10, 2024 22:59
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@kilfoyle
Copy link
Contributor Author

@cmacknz @blakerouse Would either of you mind reviewing this when you have a moment?

@@ -35,8 +35,10 @@ providers:
- item: key2
----

Explicitly disable a provider by setting `enabled: false`. All providers
are prefixed without name collisions. The name of the provider is in the key in the configuration.
Providers are disabled by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct.

Suggested change
Providers are disabled by default.
Providers are automatically enabled if a provided is referenced in a policy.

Explicitly disable a provider by setting `enabled: false`. All providers
are prefixed without name collisions. The name of the provider is in the key in the configuration.
Providers are disabled by default.
Explicitly enable a provider by setting `enabled: true`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even this will not cause a provide to run. The provider must be referenced in the policy or it will not run.


Disable all providers by default and only enable explicitly configured providers by setting `agent.providers.initial_default: false`.
Enable all providers by default and only disable explicitly configured providers by setting `agent.providers.initial_default: true`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should really keep this section how it was. As this still applies.

If you set initial_default: false and you have a provider referenced in the policy the provider still will not run.

`enabled`:: (Optional) Defaults to true. To explicitly disable the LeaderElection provider,
set `enabled: false`.
`enabled`:: (Optional) Defaults to false. To explicitly enable the LeaderElection provider,
set `enabled: true`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true. It will turn on if anywhere in the policy references the kubernetes_leaderelection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs to indicate that providers are no longer enabled by default
2 participants