Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed very small typo in air-gapped.asciidoc #1504

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fixed very small typo in air-gapped.asciidoc #1504

merged 1 commit into from
Nov 28, 2024

Conversation

frederikb96
Copy link
Contributor

Typo fix: "om" replaced with "in"

@frederikb96
Fixed very small typo in air-gapped.asciidoc
2dc40bb 
Typo fix: "om" replaced with "in"
@frederikb96 frederikb96 requested a review from a team as a code owner November 27, 2024 16:49
@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Nov 27, 2024 •
edited
Loading

💚 CLA has been signed

@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

kilfoyle
kilfoyle approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks very much @frederikb96!
One request: It looks like for me to merge this PR you'd need to sign the contributor agreement (according to the "CLA" CI check below). Would you mind doing that? If you click on the "details" link I think it should take you to the agreement form.

@frederikb96
Copy link
Contributor Author

Nice. Thanks very much @frederikb96! One request: It looks like for me to merge this PR you'd need to sign the contributor agreement (according to the "CLA" CI check below). Would you mind doing that? If you click on the "details" link I think it should take you to the agreement form.

Yes sure, I did that, but not sure if it will take some time to be updated here :)

@kilfoyle
Copy link
Contributor

Looks like it passed. :-)
Thanks again @frederikb96! I'll merge and backport this one later today or tomorrow.

@frederikb96
Copy link
Contributor Author

Looks like it passed. :-)
Thanks again @frederikb96! I'll merge and backport this one later today or tomorrow.

Perfect, happy to help with this tiny improvement 😄

@kilfoyle
Copy link
Contributor

@elasticmachine run docs-build

@kilfoyle kilfoyle merged commit c5c1277 into elastic:8.16 Nov 28, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Nov 28, 2024
@frederikb96 @mergify
Fixed very small typo in air-gapped.asciidoc (#1504)
3997164 
Typo fix: "om" replaced with "in"

(cherry picked from commit c5c1277)
@mergify mergify bot mentioned this pull request Nov 28, 2024
Merged
kilfoyle pushed a commit that referenced this pull request Nov 28, 2024
@mergify @frederikb96
Fixed very small typo in air-gapped.asciidoc (#1504) (#1506)
cd57109 
Typo fix: "om" replaced with "in"

(cherry picked from commit c5c1277)

Co-authored-by: Frederik Berg <[email protected]>
mergify bot added a commit that referenced this pull request Nov 28, 2024
@mergify
Fixed very small typo in air-gapped.asciidoc (#1504) (#1506)
48b28e7 
Typo fix: "om" replaced with "in"

(cherry picked from commit c5c1277)

Co-authored-by: Frederik Berg <[email protected]>
(cherry picked from commit cd57109)
@mergify mergify bot mentioned this pull request Nov 28, 2024
Merged
mergify bot added a commit that referenced this pull request Nov 28, 2024
@mergify
Fixed very small typo in air-gapped.asciidoc (#1504) (#1506)
64e0db7 
Typo fix: "om" replaced with "in"

(cherry picked from commit c5c1277)

Co-authored-by: Frederik Berg <[email protected]>
(cherry picked from commit cd57109)
@mergify mergify bot mentioned this pull request Nov 28, 2024
Merged
kilfoyle pushed a commit that referenced this pull request Nov 28, 2024
@mergify
Fixed very small typo in air-gapped.asciidoc (#1504) (#1506) (#1508)
9c62535 
Typo fix: "om" replaced with "in"

(cherry picked from commit c5c1277)

Co-authored-by: Frederik Berg <[email protected]>
(cherry picked from commit cd57109)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
kilfoyle pushed a commit that referenced this pull request Nov 28, 2024
@mergify
Fixed very small typo in air-gapped.asciidoc (#1504) (#1506) (#1509)
1e706b1 
Typo fix: "om" replaced with "in"

(cherry picked from commit c5c1277)

Co-authored-by: Frederik Berg <[email protected]>
(cherry picked from commit cd57109)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

Assignees
No one assigned
Labels
backport-main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikb96 @kilfoyle