Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Agent policy settings docs to correct location #1092

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented May 28, 2024

Some settings were missing or documented in the wrong location in the docs. This PR:

  • Moves the "Host name format" setting to the agent policy settings page, here.
  • Adds the missing "Agent binary download" setting to the to the agent policy settings page, here.
  • Adds the missing "Proxy" setting to the Fleet Server settings page, here.

@juliaElastic, @criamico The content isn't really new but rather just moved around. Would you mind taking a look just to make sure the docs are okay?

Closes: #1091

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@kilfoyle
Copy link
Contributor Author

@elasticmachine run docs-build

Copy link
Contributor

mergify bot commented Jun 21, 2024

This pull request is now in conflict. Could you fix it @kilfoyle? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch <remote-repo>
git checkout -b 1091/move-settings <remote-repo>/1091/move-settings
git merge <remote-repo>/main
git push <remote-repo> 1091/move-settings

@kilfoyle
Copy link
Contributor Author

Opened a security docs PR to fix the failing docs CI check.

@kilfoyle
Copy link
Contributor Author

@elasticmachine run docs-build

@kilfoyle kilfoyle marked this pull request as ready for review June 21, 2024 21:24
@kilfoyle kilfoyle requested a review from a team as a code owner June 21, 2024 21:24
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@kilfoyle kilfoyle merged commit 32c5f9c into elastic:main Jun 24, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Jun 24, 2024
* Move Agent policy settings docs to correct location

* Add binary download settings (policy), proxy settings (fleet)

* Fix hostname format link ID to resolve docs build

(cherry picked from commit 32c5f9c)

# Conflicts:
#	docs/en/ingest-management/agent-policies.asciidoc
#	docs/en/ingest-management/fleet/fleet-settings.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings such as "Host name format" and "Agent binary download" in wrong location
3 participants